Pre-Angular 9 upgrade fixes (#5712)

* remove deprecated angular/http

* upgrade adf libs

* fix production builds

* ivy-compatible translate module usage

* improved module usage

* upgrade content services module

* fix process services tests

* upgrade process cloud tests

* lint fixes

* update core max size

* fix insights test module

* remove insights lazy loading workaround

* fix insights module exports

* * Fixed skipped form-cloud unit test and removed duplicated tests

* cleanup the use of services

Co-authored-by: sivakumar414ram <siva.kumar@muraai.com>

lib/core/form/services/ecm-model.service.spec.ts

@@ -19,10 +19,10 @@ import { Observable } from 'rxjs';
 import { FormModel } from './../components/widgets/core/form.model';
 import { EcmModelService } from './ecm-model.service';
 import { setupTestBed } from '../../testing/setup-test-bed';
-import { CoreModule } from '../../core.module';
 import { TestBed } from '@angular/core/testing';
 import { AlfrescoApiService } from '../../services/alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../../mock/alfresco-api.service.mock';
+import { CoreTestingModule } from '../../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -32,7 +32,7 @@ describe('EcmModelService', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/form/services/form.service.spec.ts

@@ -16,13 +16,11 @@
  */
 
 import { TestBed } from '@angular/core/testing';
-import { Response, ResponseOptions } from '@angular/http';
 import { AlfrescoApiService } from '../../services/alfresco-api.service';
 import { formModelTabs, AlfrescoApiServiceMock } from '../../mock';
 import { FormService } from './form.service';
 import { setupTestBed } from '../../testing/setup-test-bed';
-import { CoreModule } from '../../core.module';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { CoreTestingModule } from '../../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -58,8 +56,7 @@ describe('Form service', () => {
 
     setupTestBed({
         imports: [
-            NoopAnimationsModule,
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }
@@ -246,32 +243,6 @@ describe('Form service', () => {
             });
         });
 
-        it('should not get form id from response', () => {
-            let response = new Response(new ResponseOptions({ body: null }));
-            expect(service.getFormId(response)).toBeNull();
-
-            response = new Response(new ResponseOptions({ body: {} }));
-            expect(service.getFormId(response)).toBeNull();
-
-            response = new Response(new ResponseOptions({ body: { data: null } }));
-            expect(service.getFormId(response)).toBeNull();
-
-            response = new Response(new ResponseOptions({ body: { data: [] } }));
-            expect(service.getFormId(response)).toBeNull();
-
-            expect(service.getFormId(null)).toBeNull();
-        });
-
-        it('should fallback to empty json array', () => {
-            expect(service.toJsonArray(null)).toEqual([]);
-
-            let response = new Response(new ResponseOptions({ body: {} }));
-            expect(service.toJsonArray(response)).toEqual([]);
-
-            response = new Response(new ResponseOptions({ body: { data: null } }));
-            expect(service.toJsonArray(response)).toEqual([]);
-        });
-
         it('should handle error with generic message', () => {
             service.handleError(null).subscribe(() => {
             }, (error) => {

lib/core/form/services/node.service.spec.ts

@@ -20,10 +20,9 @@ import { NodeMetadata } from '../../models/node-metadata.model';
 import { EcmModelService } from './ecm-model.service';
 import { NodeService } from './node.service';
 import { setupTestBed } from '../../testing/setup-test-bed';
-import { CoreModule } from '../../core.module';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { AlfrescoApiService } from '../../services/alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../../mock/alfresco-api.service.mock';
+import { CoreTestingModule } from '../../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -33,8 +32,7 @@ describe('NodeService', () => {
 
     setupTestBed({
         imports: [
-            NoopAnimationsModule,
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/form/services/process-content.service.spec.ts

@@ -19,10 +19,9 @@ import { TestBed } from '@angular/core/testing';
 import { of } from 'rxjs';
 import { ProcessContentService } from './process-content.service';
 import { setupTestBed } from '../../testing/setup-test-bed';
-import { CoreModule } from '../../core.module';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { AlfrescoApiService } from '../../services/alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../../mock/alfresco-api.service.mock';
+import { CoreTestingModule } from '../../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -71,8 +70,7 @@ describe('ProcessContentService', () => {
 
     setupTestBed({
         imports: [
-            NoopAnimationsModule,
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/form/services/widget-visibility-cloud.service.spec.ts

@@ -27,8 +27,6 @@ import { TaskProcessVariableModel } from './../models/task-process-variable.mode
 import { WidgetVisibilityModel, WidgetTypeEnum } from './../models/widget-visibility.model';
 import { WidgetVisibilityService } from './widget-visibility.service';
 import { setupTestBed } from '../../testing/setup-test-bed';
-import { CoreModule } from '../../core.module';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { AlfrescoApiService } from '../../services/alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../../mock/alfresco-api.service.mock';
 import {
@@ -36,6 +34,7 @@ import {
     formTest, formValues, complexVisibilityJsonVisible,
     nextConditionForm, complexVisibilityJsonNotVisible,
     headerVisibilityCond } from 'core/mock/form/widget-visibility-cloud.service.mock';
+import { CoreTestingModule } from '../../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -47,8 +46,7 @@ describe('WidgetVisibilityCloudService', () => {
 
     setupTestBed({
         imports: [
-            NoopAnimationsModule,
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/form/services/widget-visibility.service.spec.ts

@@ -27,8 +27,6 @@ import { TaskProcessVariableModel } from './../models/task-process-variable.mode
 import { WidgetVisibilityModel } from './../models/widget-visibility.model';
 import { WidgetVisibilityService } from './widget-visibility.service';
 import { setupTestBed } from '../../testing/setup-test-bed';
-import { CoreModule } from '../../core.module';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { AlfrescoApiService } from '../../services/alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../../mock/alfresco-api.service.mock';
 import { fakeTaskProcessVariableModels,
@@ -37,6 +35,7 @@ import { fakeTaskProcessVariableModels,
         complexVisibilityJsonNotVisible, tabVisibilityJsonMock,
         tabInvalidFormVisibility } from 'core/mock/form/widget-visibility.service.mock';
 import { formWithOneVisibleAndOneInvisibleFieldMock, formWithOneVisibleAndOneInvisibleTabMock } from '../components/mock/form-renderer.component.mock';
+import { CoreTestingModule } from '../../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -48,8 +47,7 @@ describe('WidgetVisibilityService', () => {
 
     setupTestBed({
         imports: [
-            NoopAnimationsModule,
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }