Pre-Angular 9 upgrade fixes (#5712)

* remove deprecated angular/http

* upgrade adf libs

* fix production builds

* ivy-compatible translate module usage

* improved module usage

* upgrade content services module

* fix process services tests

* upgrade process cloud tests

* lint fixes

* update core max size

* fix insights test module

* remove insights lazy loading workaround

* fix insights module exports

* * Fixed skipped form-cloud unit test and removed duplicated tests

* cleanup the use of services

Co-authored-by: sivakumar414ram <siva.kumar@muraai.com>

lib/core/services/bpm-user.service.spec.ts

@@ -19,9 +19,9 @@ import { TestBed } from '@angular/core/testing';
 import { BpmUserModel } from '../models/bpm-user.model';
 import { BpmUserService } from '../services/bpm-user.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
 import { AlfrescoApiService } from './alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -31,7 +31,7 @@ describe('Bpm user service', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/services/content.service.spec.ts

@@ -16,19 +16,13 @@
  */
 
 import { TestBed } from '@angular/core/testing';
-import { CookieServiceMock } from '../mock/cookie.service.mock';
 import { ContentService } from './content.service';
 import { AppConfigService } from '../app-config/app-config.service';
 import { AuthenticationService } from './authentication.service';
-import { CookieService } from './cookie.service';
 import { StorageService } from './storage.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
-import { AlfrescoApiService } from './alfresco-api.service';
-import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
-import { TranslationService } from './translation.service';
-import { TranslationMock } from '../mock/translation.service.mock';
 import { Node } from '@alfresco/js-api';
+import { CoreTestingModule } from '../testing';
 
 declare let jasmine: any;
 
@@ -43,12 +37,7 @@ describe('ContentService', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
-        ],
-        providers: [
-            { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
-            { provide: TranslationService, useClass: TranslationMock },
-            { provide: CookieService, useClass: CookieServiceMock }
+            CoreTestingModule
         ]
     });
 

lib/core/services/ecm-user.service.spec.ts

@@ -20,8 +20,8 @@ import { AuthenticationService, ContentService, AlfrescoApiService  } from '.';
 import { fakeEcmUser } from '../mock/ecm-user.service.mock';
 import { EcmUserService } from '../services/ecm-user.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
 import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -33,7 +33,7 @@ describe('EcmUserService', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/services/identity-group.service.spec.ts

@@ -18,7 +18,6 @@
 import { async, TestBed } from '@angular/core/testing';
 import {
     AlfrescoApiServiceMock,
-    CoreModule,
     setupTestBed,
     AlfrescoApiService,
     LogService,
@@ -42,6 +41,7 @@ import {
     deleteGroupMappingApi,
     mockIdentityGroupsCount
 } from '../mock/identity-group.service.mock';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 describe('IdentityGroupService', () => {
     let service: IdentityGroupService;
@@ -49,7 +49,9 @@ describe('IdentityGroupService', () => {
     let logService: LogService;
 
     setupTestBed({
-        imports: [CoreModule.forRoot()],
+        imports: [
+            CoreTestingModule
+        ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }
         ]

lib/core/services/identity-user.service.spec.ts

@@ -39,11 +39,11 @@ import {
 } from 'core/mock/identity-user.service.mock';
 import { IdentityUserService } from '../services/identity-user.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
 import { AlfrescoApiService } from './alfresco-api.service';
 import { mockToken } from '../mock/jwt-helper.service.spec';
 import { IdentityRoleModel } from '../models/identity-role.model';
 import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 describe('IdentityUserService', () => {
 
@@ -60,7 +60,7 @@ describe('IdentityUserService', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/services/login-dialog.service.spec.ts

@@ -20,7 +20,7 @@ import { setupTestBed } from '../testing/setup-test-bed';
 import { MatDialog } from '@angular/material';
 import { LoginDialogService } from './login-dialog.service';
 import { Subject, of } from 'rxjs';
-import { CoreModule } from '../core.module';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 describe('LoginDialogService', () => {
 
@@ -29,7 +29,9 @@ describe('LoginDialogService', () => {
     let spyOnDialogOpen: jasmine.Spy;
 
     setupTestBed({
-        imports: [CoreModule.forRoot()]
+        imports: [
+            CoreTestingModule
+        ]
     });
 
     beforeEach(() => {

lib/core/services/nodes-api.service.spec.ts

@@ -16,13 +16,12 @@
  */
 
 import { TestBed } from '@angular/core/testing';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { NodesApiService } from './nodes-api.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
 import { AlfrescoApiService } from './alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
 import { NodeMetadata } from '../models/node-metadata.model';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 describe('NodesApiService', () => {
     let service: NodesApiService;
@@ -51,8 +50,7 @@ describe('NodesApiService', () => {
 
     setupTestBed({
         imports: [
-            NoopAnimationsModule,
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/services/page-title.service.spec.ts

@@ -17,11 +17,12 @@
 
 import { TestBed } from '@angular/core/testing';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
 import { AppConfigService } from '../app-config/app-config.service';
 import { PageTitleService } from './page-title.service';
 import { TranslationService } from './translation.service';
 import { Title } from '@angular/platform-browser';
+import { CoreModule } from '../core.module';
+import { TranslateModule } from '@ngx-translate/core';
 
 describe('PageTitleService', () => {
 
@@ -33,6 +34,7 @@ describe('PageTitleService', () => {
 
     setupTestBed({
         imports: [
+            TranslateModule.forRoot(),
             CoreModule.forRoot()
         ]
     });

lib/core/services/renditions.service.spec.ts

@@ -19,10 +19,10 @@ import { TestBed } from '@angular/core/testing';
 import { fakeRendition, fakeRenditionCreated, fakeRenditionsList, fakeRenditionsListWithACreated } from '../mock/renditions-service.mock';
 import { RenditionsService } from './renditions.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
 import { AlfrescoApiService } from './alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
 import { RenditionEntry } from '@alfresco/js-api';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -31,7 +31,7 @@ describe('RenditionsService', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
+            CoreTestingModule
         ],
         providers: [
             { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }

lib/core/services/search.service.spec.ts

@@ -17,15 +17,10 @@
 
 import { TestBed } from '@angular/core/testing';
 import { searchMockApi, mockError, fakeSearch } from '../mock/search.service.mock';
-import { CookieServiceMock } from './../mock/cookie.service.mock';
-import { CookieService } from './cookie.service';
 import { SearchService } from './search.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
 import { AlfrescoApiService } from './alfresco-api.service';
-import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
-import { TranslationService } from './translation.service';
-import { TranslationMock } from '../mock/translation.service.mock';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 describe('SearchService', () => {
 
@@ -34,12 +29,7 @@ describe('SearchService', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
-        ],
-        providers: [
-            { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
-            { provide: TranslationService, useClass: TranslationMock },
-            { provide: CookieService, useClass: CookieServiceMock }
+            CoreTestingModule
         ]
     });
 

lib/core/services/translate-loader.spec.ts

@@ -19,7 +19,7 @@ import { TestBed } from '@angular/core/testing';
 import { TranslateLoaderService } from './translate-loader.service';
 import { TranslationService } from './translation.service';
 import { setupTestBed } from '../testing/setup-test-bed';
-import { CoreModule } from '../core.module';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 declare let jasmine: any;
 
@@ -29,7 +29,10 @@ describe('TranslateLoader', () => {
 
     setupTestBed({
         imports: [
-            CoreModule.forRoot()
+            CoreTestingModule
+        ],
+        providers: [
+            TranslationService
         ]
     });