Pre-Angular 9 upgrade fixes (#5712)

* remove deprecated angular/http

* upgrade adf libs

* fix production builds

* ivy-compatible translate module usage

* improved module usage

* upgrade content services module

* fix process services tests

* upgrade process cloud tests

* lint fixes

* update core max size

* fix insights test module

* remove insights lazy loading workaround

* fix insights module exports

* * Fixed skipped form-cloud unit test and removed duplicated tests

* cleanup the use of services

Co-authored-by: sivakumar414ram <siva.kumar@muraai.com>

lib/insights/package.json

@@ -19,7 +19,6 @@
     "@angular/core": ">=7.0.3",
     "@angular/flex-layout": ">=7.0.0-beta.19",
     "@angular/forms": ">=7.0.3",
-    "@angular/http": ">=7.0.3",
     "@angular/material": ">=7.0.3",
     "@angular/material-moment-adapter": ">=7.0.3",
     "@angular/platform-browser": ">=7.0.3",

lib/insights/src/lib/insights.module.ts

@@ -35,21 +35,7 @@ import { MaterialModule } from './material.module';
         DiagramsModule,
         AnalyticsProcessModule
     ],
-    providers: [
-        {
-            provide: TRANSLATION_PROVIDER,
-            multi: true,
-            useValue: {
-                name: 'adf-insights',
-                source: 'assets/adf-insights'
-            }
-        }
-    ],
     exports: [
-        CommonModule,
-        FormsModule,
-        ReactiveFormsModule,
-        MaterialModule,
         DiagramsModule,
         AnalyticsProcessModule
     ]
@@ -73,28 +59,7 @@ export class InsightsModule {
 
     static forChild(): ModuleWithProviders {
         return {
-            ngModule: InsightsModuleLazy
+            ngModule: InsightsModule
         };
     }
 }
-
-@NgModule({
-    imports: [
-        CoreModule,
-        CommonModule,
-        FormsModule,
-        ReactiveFormsModule,
-        MaterialModule,
-        DiagramsModule,
-        AnalyticsProcessModule
-    ],
-    exports: [
-        CommonModule,
-        FormsModule,
-        ReactiveFormsModule,
-        MaterialModule,
-        DiagramsModule,
-        AnalyticsProcessModule
-    ]
-})
-export class InsightsModuleLazy {}

lib/insights/src/lib/testing/insights.testing.module.ts

@@ -17,6 +17,7 @@
 
 import { NgModule } from '@angular/core';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { TranslateModule } from '@ngx-translate/core';
 import { InsightsModule } from '../insights.module';
 import {
     AlfrescoApiService,
@@ -31,6 +32,7 @@ import {
 @NgModule({
     imports: [
         NoopAnimationsModule,
+        TranslateModule.forRoot(),
         CoreModule.forRoot(),
         InsightsModule.forRoot()
     ],
@@ -38,6 +40,12 @@ import {
         { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
         { provide: AppConfigService, useClass: AppConfigServiceMock },
         { provide: TranslationService, useClass: TranslationMock }
+    ],
+    exports: [
+        NoopAnimationsModule,
+        TranslateModule,
+        CoreModule,
+        InsightsModule
     ]
 })
 export class InsightsTestingModule {}