inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-1287] compatibility with the new noUnusedLocals rule (#2170)

Browse Source 
* support for noUnusedLocals rule

* clean diagram components

* code cleanup

* Viewer fixes

* code fixes

* code fixes
This commit is contained in:
Denys Vuika
2017-08-04 15:35:15 +01:00
committed by Eugenio Romano
parent c5feae5de3
commit 66de20dd21
113 changed files with 190 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ng2-components/ng2-activiti-tasklist/src/components/apps-list.component.ts
View File

@@ -23,8 +23,6 @@ import { AppDefinitionRepresentationModel } from '../models/filter.model';
import { IconModel } from '../models/icon.model';
import { TaskListService } from './../services/tasklist.service';
declare let componentHandler: any;
@Component({
selector: 'adf-apps, activiti-apps',
templateUrl: 'apps-list.component.html',
@@ -67,7 +65,7 @@ export class AppsListComponent implements OnInit {
* @param translate Translate service
* @param activitiTaskList Task service
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService) {
if (translateService) {

7
ng2-components/ng2-activiti-tasklist/src/components/checklist.component.ts
View File

@@ -16,7 +16,7 @@
*/
import { Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges, ViewChild } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable, Observer } from 'rxjs/Rx';
import { TaskDetailsModel } from '../models/task-details.model';
import { TaskListService } from './../services/tasklist.service';
@@ -64,9 +64,8 @@ export class ChecklistComponent implements OnInit, OnChanges {
* @param auth
* @param translate
*/
constructor(private translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService,
private logService: LogService) {
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');

2
ng2-components/ng2-activiti-tasklist/src/components/comments.component.ts
View File

@@ -52,7 +52,7 @@ export class CommentsComponent implements OnChanges {
* @param translate Translation service
* @param activitiTaskList Task service
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService) {
if (translateService) {

2
ng2-components/ng2-activiti-tasklist/src/components/create-task-attachment.component.ts
View File

@@ -35,7 +35,7 @@ export class AttachmentComponent implements OnChanges {
@Output()
success: EventEmitter<any> = new EventEmitter<any>();
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService) {
if (translateService) {

4
ng2-components/ng2-activiti-tasklist/src/components/no-task-detail-template.directive.spec.ts
View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { TaskDetailsComponent } from './task-details.component';
import { NoTaskDetailsTemplateDirective } from './no-task-detail-template.directive';
import { TaskDetailsComponent } from './task-details.component';
describe('NoTaskDetailsTemplateDirective', () => {
@@ -24,7 +24,7 @@ describe('NoTaskDetailsTemplateDirective', () => {
let detailsComponent: TaskDetailsComponent;
beforeEach(() => {
detailsComponent = new TaskDetailsComponent(null, null, null, null, null, null);
detailsComponent = new TaskDetailsComponent(null, null, null, null);
component = new NoTaskDetailsTemplateDirective(detailsComponent);
});

3
ng2-components/ng2-activiti-tasklist/src/components/people-search.component.ts
View File

@@ -22,7 +22,6 @@ import { Observable } from 'rxjs/Observable';
import { User } from '../models/user.model';
declare let componentHandler: any;
declare var require: any;
@Component({
selector: 'adf-people-search, activiti-people-search',
@@ -50,7 +49,7 @@ export class PeopleSearchComponent implements OnInit, AfterViewInit {
selectedUser: User;
constructor(private translateService: AlfrescoTranslationService) {
constructor(translateService: AlfrescoTranslationService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');
}

2
ng2-components/ng2-activiti-tasklist/src/components/people.component.ts
View File

@@ -55,7 +55,7 @@ export class PeopleComponent implements AfterViewInit {
* @param translate
* @param people service
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private peopleService: PeopleService,
private logService: LogService) {
if (translateService) {

2
ng2-components/ng2-activiti-tasklist/src/components/start-task.component.spec.ts
View File

@@ -26,8 +26,6 @@ import { TaskListService } from '../services/tasklist.service';
import { startTaskMock } from './../assets/start-task.mock';
import { StartTaskComponent } from './start-task.component';
declare let jasmine: any;
describe('StartTaskComponent', () => {
let activitiStartTaskComponent: StartTaskComponent;

2
ng2-components/ng2-activiti-tasklist/src/components/start-task.component.ts
View File

@@ -62,7 +62,7 @@ export class StartTaskComponent implements OnInit {
* @param translate
* @param taskService
*/
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private taskService: TaskListService,
private peopleService: PeopleService,
private logService: LogService) {

2
ng2-components/ng2-activiti-tasklist/src/components/task-attachment-list.component.ts
View File

@@ -41,7 +41,7 @@ export class TaskAttachmentListComponent implements OnChanges {
attachments: any[] = [];
isLoading: boolean = true;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService,
private contentService: ContentService,
private thumbnailService: ThumbnailService) {

2
ng2-components/ng2-activiti-tasklist/src/components/task-audit.directive.spec.ts
View File

@@ -22,7 +22,6 @@ import {
fakeAsync,
TestBed
} from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import { CoreModule } from 'ng2-alfresco-core';
import { Observable } from 'rxjs/Rx';
import { TaskListService } from './../services/tasklist.service';
@@ -34,7 +33,6 @@ describe('TaskAuditDirective', () => {
let fixture: ComponentFixture<BasicButtonComponent>;
let component: BasicButtonComponent;
let auditDirective: TaskAuditDirective;
let service: TaskListService;
function createFakePdfBlob(): Blob {

21
ng2-components/ng2-activiti-tasklist/src/components/task-details.component.ts
View File

@@ -26,15 +26,14 @@ import { Component,
TemplateRef,
ViewChild
} from '@angular/core';
import { ContentLinkModel, FormModel, FormOutcomeEvent, FormService } from 'ng2-activiti-form';
import { AlfrescoAuthenticationService, AlfrescoTranslationService, CardViewUpdateService, ClickNotification, LogService, UpdateNotification } from 'ng2-alfresco-core';
import { ContentLinkModel, FormModel, FormOutcomeEvent } from 'ng2-activiti-form';
import { AlfrescoAuthenticationService, AlfrescoTranslationService, CardViewUpdateService, ClickNotification, UpdateNotification } from 'ng2-alfresco-core';
import { TaskQueryRequestRepresentationModel } from '../models/filter.model';
import { TaskDetailsModel } from '../models/task-details.model';
import { User } from '../models/user.model';
import { TaskListService } from './../services/tasklist.service';
declare var require: any;
declare let dialogPolyfill: any;
@Component({
selector: 'adf-task-details, activiti-task-details',
@@ -128,22 +127,10 @@ export class TaskDetailsComponent implements OnInit, OnChanges {
noTaskDetailsTemplateComponent: TemplateRef<any>;
/**
*
* @param translateService
* @param activitiForm
* @param activitiTaskList
* @param logService
* @param authService
*/
constructor(private translateService: AlfrescoTranslationService,
private activitiForm: FormService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskList: TaskListService,
private logService: LogService,
private authService: AlfrescoAuthenticationService,
private cardViewUpdateService: CardViewUpdateService
) {
private cardViewUpdateService: CardViewUpdateService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');
}

2
ng2-components/ng2-activiti-tasklist/src/components/task-filters.component.spec.ts
View File

@@ -66,7 +66,7 @@ describe('TaskFiltersComponent', () => {
beforeEach(() => {
logService = new LogServiceMock();
activitiService = new TaskListService(null, logService);
filterList = new TaskFiltersComponent(null, activitiService, logService);
filterList = new TaskFiltersComponent(null, activitiService);
});
it('should return the filter task list', (done) => {

13
ng2-components/ng2-activiti-tasklist/src/components/task-filters.component.ts
View File

@@ -16,13 +16,11 @@
*/
import { Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable, Observer } from 'rxjs/Rx';
import { FilterParamsModel, FilterRepresentationModel } from '../models/filter.model';
import { TaskListService } from './../services/tasklist.service';
declare let componentHandler: any;
@Component({
selector: 'adf-filters, activiti-filters',
templateUrl: './task-filters.component.html',
@@ -59,9 +57,8 @@ export class TaskFiltersComponent implements OnInit, OnChanges {
filters: FilterRepresentationModel [] = [];
constructor(private translateService: AlfrescoTranslationService,
private activiti: TaskListService,
private logService: LogService) {
constructor(translateService: AlfrescoTranslationService,
private activiti: TaskListService) {
this.filter$ = new Observable<FilterRepresentationModel>(observer => this.filterObserver = observer).share();
if (translateService) {
@@ -235,8 +232,4 @@ export class TaskFiltersComponent implements OnInit, OnChanges {
this.filters = [];
this.currentFilter = undefined;
}
private isCurrentFilterEmpty(): boolean {
return this.currentFilter === undefined || null ? true : false;
}
}

2
ng2-components/ng2-activiti-tasklist/src/components/task-header.component.ts
View File

@@ -39,7 +39,7 @@ export class TaskHeaderComponent implements OnChanges {
properties: CardViewItem [];
inEdit: boolean = false;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiTaskService: TaskListService,
private logService: LogService) {
if (translateService) {

7
ng2-components/ng2-activiti-tasklist/src/components/tasklist.component.ts
View File

@@ -25,7 +25,7 @@ import {
Output,
SimpleChanges
} from '@angular/core';
import { AlfrescoTranslationService, DataColumnListComponent, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService, DataColumnListComponent } from 'ng2-alfresco-core';
import {
DataColumn,
DataRowEvent,
@@ -99,9 +99,8 @@ export class TaskListComponent implements OnChanges, AfterContentInit {
{ type: 'text', key: 'created', title: 'Created', cssClass: 'hidden', sortable: true }
];
constructor(private translateService: AlfrescoTranslationService,
private taskListService: TaskListService,
private logService: LogService) {
constructor(translateService: AlfrescoTranslationService,
private taskListService: TaskListService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-tasklist', 'assets/ng2-activiti-tasklist');
}

3
ng2-components/ng2-activiti-tasklist/tsconfig.json
View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",