inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AAE-8086] Add form field changed event (#7584)

Browse Source 
* [AAE-8086] Add form field changed event

* [AAE-8086] Send field changed event only qhen value changes (not in visibility check)
This commit is contained in:
Pablo Martinez Garcia
2022-04-19 13:35:08 +02:00
committed by GitHub
parent 7141230649
commit 6963bef092
5 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/core/form/components/form-field/form-field.component.spec.ts
View File

@@ -113,8 +113,9 @@ describe('FormFieldComponent', () => {
component.field.isVisible = false; component.field.isVisible = false;
fixture.detectChanges(); fixture.detectChanges();
fixture.whenStable().then(() => { fixture.whenStable().then(() => {
const debugElement = fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.visibility; const debugElement = fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style;
expect(debugElement).toEqual('hidden'); expect(debugElement.visibility).toEqual('hidden');
expect(debugElement.display).toEqual('none');
done(); done();
}); });
}); });
@@ -130,6 +131,7 @@ describe('FormFieldComponent', () => {
fixture.whenStable().then(() => { fixture.whenStable().then(() => {
expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.visibility).toEqual('visible'); expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.visibility).toEqual('visible');
expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.display).toEqual('block');
done(); done();
}); });
}); });
@@ -143,9 +145,11 @@ describe('FormFieldComponent', () => {
component.field = field; component.field = field;
fixture.detectChanges(); fixture.detectChanges();
expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.visibility).toEqual('visible'); expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.visibility).toEqual('visible');
expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.display).toEqual('block');
component.field.isVisible = false; component.field.isVisible = false;
fixture.detectChanges(); fixture.detectChanges();
expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.visibility).toEqual('hidden'); expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.visibility).toEqual('hidden');
expect(fixture.nativeElement.querySelector('#field-FAKE-TXT-WIDGET-container').style.display).toEqual('none');
}); });
it('[C213878] - Should fields be correctly rendered when filled with process variables', async () => { it('[C213878] - Should fields be correctly rendered when filled with process variables', async () => {

1
lib/core/form/components/form-field/form-field.component.ts
View File

@@ -41,6 +41,7 @@ declare const adf: any;
template: ` template: `
<div [id]="'field-'+field?.id+'-container'" <div [id]="'field-'+field?.id+'-container'"
[style.visibility]="!field?.isVisible ? 'hidden' : 'visible'" [style.visibility]="!field?.isVisible ? 'hidden' : 'visible'"
[style.display]="!field?.isVisible ? 'none' : 'block'"
[class.adf-focus]="focus" [class.adf-focus]="focus"
(focusin)="focusToggle()" (focusin)="focusToggle()"
(focusout)="focusToggle()"> (focusout)="focusToggle()">

2
lib/core/form/components/widgets/core/form.model.ts
View File

@@ -429,7 +429,7 @@ export class FormModel implements ProcessFormModel {
visibilityRule.operator = visibility ? 'empty' : '!empty'; visibilityRule.operator = visibility ? 'empty' : '!empty';
visibilityRule.leftType = WidgetTypeEnum.field; visibilityRule.leftType = WidgetTypeEnum.field;
field.visibilityCondition = visibilityRule; field.visibilityCondition = visibilityRule;
field.isVisible = false; field.isVisible = visibility;
} }
} }

17
lib/core/form/components/widgets/widget.component.spec.ts
View File

@@ -22,8 +22,9 @@ import { WidgetComponent } from './widget.component';
import { setupTestBed } from '../../../testing/setup-test-bed'; import { setupTestBed } from '../../../testing/setup-test-bed';
import { CoreTestingModule } from '../../../testing'; import { CoreTestingModule } from '../../../testing';
import { TranslateModule } from '@ngx-translate/core'; import { TranslateModule } from '@ngx-translate/core';
import { filter } from 'rxjs/operators';
describe('WidgetComponent', () => { fdescribe('WidgetComponent', () => {
let widget: WidgetComponent; let widget: WidgetComponent;
let fixture: ComponentFixture<WidgetComponent>; let fixture: ComponentFixture<WidgetComponent>;
@@ -56,8 +57,7 @@ describe('WidgetComponent', () => {
}); });
it('should click event be redirect on the form rules event service', (done) => { it('should click event be redirect on the form rules event service', (done) => {
widget.formService.formRulesEvent.subscribe((event) => { widget.formService.formRulesEvent.pipe(filter(event => event.type === 'click')).subscribe(() => {
expect(event.type).toEqual('click');
done(); done();
}); });
@@ -99,6 +99,17 @@ describe('WidgetComponent', () => {
widget.onFieldChanged(fakeField); widget.onFieldChanged(fakeField);
}); });
it('should send a rule event when a field is changed', (done) => {
const fakeForm = new FormModel();
const fakeField = new FormFieldModel(fakeForm, { id: 'fakeField', value: 'fakeValue' });
widget.formService.formRulesEvent.subscribe((event) => {
expect(event.type).toEqual('fieldValueChanged');
done();
});
widget.onFieldChanged(fakeField);
});
it('should eval isRequired state of the field', () => { it('should eval isRequired state of the field', () => {
expect(widget.isRequired()).toBeFalsy(); expect(widget.isRequired()).toBeFalsy();

1
lib/core/form/components/widgets/widget.component.ts
View File

@@ -104,6 +104,7 @@ export class WidgetComponent implements AfterViewInit {
onFieldChanged(field: FormFieldModel) { onFieldChanged(field: FormFieldModel) {
this.fieldChanged.emit(field); this.fieldChanged.emit(field);
this.formService.formRulesEvent.next(new FormRulesEvent('fieldValueChanged', new FormFieldEvent(this.field?.form, this.field), null));
} }
event(event: Event): void { event(event: Event): void {