[ADF-3299] and [ADF-3300] upgrade to Angular and Material 6 (#3579)

* upgrade to HttpClient

* upgrade to Renderer2

* upgrade Document reference

* remove useless test with deprecated ReflectiveInjector

* upgrade to latest typescript

* upgrade libs

* upgrade package scripts

* remove rxjs blacklists and duplicate rules

* add rxjs compat to help with migration

* fix breaking changes

* fix breaking changes in material

* fix breaking changes (material 6)

* upgrade rxjs, ngx-translate and flex layout

* update unit tests

* restore providers

* upgrade deprecated Observable.error

* rebase
fix first configuration problems

* fix style issues commented

* fix core build

* fix lib template errors

* move lib test execution in angular.json

* ignore

* karma conf files

* fix import statement test

* single run option

* update packages reporter

* restore report

* increase timeout

* improve karma conf test configuration

* fix test issues about lint

* fix test analytics

* fix process service test

* content service fix test

* fix logout directive test

* fix core test

* fix build

* update node-sass to latest

* update angular cli dependencies

* improve build script

create directorites and move files only if previous command succeded

* upgrade individual libs to 6.0

* remove old webpack files

* revert sass change

* fix type issues
fix style issues

* fix tslint demo shell issue

* fix peerdependencies

* fix test e2e BC

* package upate

* fix style import issue

* extract-text-webpack-plugin beta

* fix test dist build command

* remove alpha js-api

* fix tslint issue
add banner tslint rule

* upload service fix

* change BC script

* fix test dist script

* increase demo shell timeout test

* verbose copy

* path absolute

* fix script bc

* fix copy part

* fix path warning
fix monaco editor

* remove duplicate header

* remove unused import

* fix align and check ago tests

* add missing import

* fix notification button selector

* [ANGULAR6] fixed core tests

* fix CS test

* fix cs test step 2

* increase travis_wait for dist

* fix attachment PS

* fix checklist test

* use pdf min

lib/content-services/content-node-selector/content-node-dialog.service.spec.ts

@@ -21,8 +21,7 @@ import { AppConfigService, SitesService, setupTestBed } from '@alfresco/adf-core
 import { DocumentListService } from '../document-list/services/document-list.service';
 import { ContentNodeDialogService } from './content-node-dialog.service';
 import { MatDialog } from '@angular/material';
-import { Observable } from 'rxjs/Observable';
-import { Subject } from 'rxjs/Subject';
+import { Subject, of } from 'rxjs';
 import { ContentTestingModule } from '../testing/content.testing.module';
 
 const fakeNode: MinimalNodeEntryEntity = <MinimalNodeEntryEntity> {
@@ -75,7 +74,7 @@ describe('ContentNodeDialogService', () => {
         afterOpenObservable = new Subject<any>();
         spyOnDialogOpen = spyOn(materialDialog, 'open').and.returnValue({
             afterOpen: () => afterOpenObservable,
-            afterClosed: () => Observable.of({}),
+            afterClosed: () => of({}),
             componentInstance: {
                 error: new Subject<any>()
             }
@@ -112,23 +111,23 @@ describe('ContentNodeDialogService', () => {
     });
 
     it('should be able to open the dialog using a folder id', fakeAsync(() => {
-        spyOn(documentListService, 'getFolderNode').and.returnValue(Observable.of(fakeNode));
+        spyOn(documentListService, 'getFolderNode').and.returnValue(of(fakeNode));
         service.openFileBrowseDialogByFolderId('fake-folder-id').subscribe();
         tick();
         expect(spyOnDialogOpen).toHaveBeenCalled();
     }));
 
     it('should be able to open the dialog for files using the first user site', fakeAsync(() => {
-        spyOn(sitesService, 'getSites').and.returnValue(Observable.of(fakeSiteList));
-        spyOn(documentListService, 'getFolderNode').and.returnValue(Observable.of(fakeNode));
+        spyOn(sitesService, 'getSites').and.returnValue(of(fakeSiteList));
+        spyOn(documentListService, 'getFolderNode').and.returnValue(of(fakeNode));
         service.openFileBrowseDialogBySite().subscribe();
         tick();
         expect(spyOnDialogOpen).toHaveBeenCalled();
     }));
 
     it('should be able to open the dialog for folder using the first user site', fakeAsync(() => {
-        spyOn(sitesService, 'getSites').and.returnValue(Observable.of(fakeSiteList));
-        spyOn(documentListService, 'getFolderNode').and.returnValue(Observable.of(fakeNode));
+        spyOn(sitesService, 'getSites').and.returnValue(of(fakeSiteList));
+        spyOn(documentListService, 'getFolderNode').and.returnValue(of(fakeNode));
         service.openFolderBrowseDialogBySite().subscribe();
         tick();
         expect(spyOnDialogOpen).toHaveBeenCalled();