[ADF-3299] and [ADF-3300] upgrade to Angular and Material 6 (#3579)

* upgrade to HttpClient

* upgrade to Renderer2

* upgrade Document reference

* remove useless test with deprecated ReflectiveInjector

* upgrade to latest typescript

* upgrade libs

* upgrade package scripts

* remove rxjs blacklists and duplicate rules

* add rxjs compat to help with migration

* fix breaking changes

* fix breaking changes in material

* fix breaking changes (material 6)

* upgrade rxjs, ngx-translate and flex layout

* update unit tests

* restore providers

* upgrade deprecated Observable.error

* rebase
fix first configuration problems

* fix style issues commented

* fix core build

* fix lib template errors

* move lib test execution in angular.json

* ignore

* karma conf files

* fix import statement test

* single run option

* update packages reporter

* restore report

* increase timeout

* improve karma conf test configuration

* fix test issues about lint

* fix test analytics

* fix process service test

* content service fix test

* fix logout directive test

* fix core test

* fix build

* update node-sass to latest

* update angular cli dependencies

* improve build script

create directorites and move files only if previous command succeded

* upgrade individual libs to 6.0

* remove old webpack files

* revert sass change

* fix type issues
fix style issues

* fix tslint demo shell issue

* fix peerdependencies

* fix test e2e BC

* package upate

* fix style import issue

* extract-text-webpack-plugin beta

* fix test dist build command

* remove alpha js-api

* fix tslint issue
add banner tslint rule

* upload service fix

* change BC script

* fix test dist script

* increase demo shell timeout test

* verbose copy

* path absolute

* fix script bc

* fix copy part

* fix path warning
fix monaco editor

* remove duplicate header

* remove unused import

* fix align and check ago tests

* add missing import

* fix notification button selector

* [ANGULAR6] fixed core tests

* fix CS test

* fix cs test step 2

* increase travis_wait for dist

* fix attachment PS

* fix checklist test

* use pdf min

lib/core/services/authentication.service.ts

@@ -16,17 +16,14 @@
  */
 
 import { Injectable } from '@angular/core';
-import { Observable } from 'rxjs/Observable';
-import { Subject } from 'rxjs/Subject';
+import { Observable, Subject, from, throwError } from 'rxjs';
 import { AlfrescoApiService } from './alfresco-api.service';
 import { CookieService } from './cookie.service';
 import { LogService } from './log.service';
 import { RedirectionModel } from '../models/redirection.model';
 import { AppConfigService, AppConfigValues } from '../app-config/app-config.service';
-import 'rxjs/add/observable/fromPromise';
-import 'rxjs/add/operator/catch';
-import 'rxjs/add/observable/throw';
 import { UserRepresentation } from 'alfresco-js-api';
+import { map, catchError, tap } from 'rxjs/operators';
 
 const REMEMBER_ME_COOKIE_KEY = 'ALFRESCO_REMEMBER_ME';
 const REMEMBER_ME_UNTIL = 1000 * 60 * 60 * 24 * 30 ;
@@ -80,16 +77,18 @@ export class AuthenticationService {
      * @returns Object with auth type ("ECM", "BPM" or "ALL") and auth ticket
      */
     login(username: string, password: string, rememberMe: boolean = false): Observable<{ type: string, ticket: any }> {
-        return Observable.fromPromise(this.alfrescoApi.getInstance().login(username, password))
-            .map((response: any) => {
-                this.saveRememberMeCookie(rememberMe);
-                this.onLogin.next(response);
-                return {
-                    type: this.appConfig.get(AppConfigValues.PROVIDERS),
-                    ticket: response
-                };
-            })
-            .catch(err => this.handleError(err));
+        return from(this.alfrescoApi.getInstance().login(username, password))
+            .pipe(
+                map((response: any) => {
+                    this.saveRememberMeCookie(rememberMe);
+                    this.onLogin.next(response);
+                    return {
+                        type: this.appConfig.get(AppConfigValues.PROVIDERS),
+                        ticket: response
+                    };
+                }),
+                catchError(err => this.handleError(err))
+            );
     }
 
     /**
@@ -128,12 +127,14 @@ export class AuthenticationService {
      * @returns Response event called when logout is complete
      */
     logout() {
-        return Observable.fromPromise(this.callApiLogout())
-            .do(response => {
-                this.onLogout.next(response);
-                return response;
-            })
-            .catch(err => this.handleError(err));
+        return from(this.callApiLogout())
+            .pipe(
+                tap(response => {
+                    this.onLogout.next(response);
+                    return response;
+                }),
+                catchError(err => this.handleError(err))
+            );
     }
 
     /**
@@ -233,7 +234,7 @@ export class AuthenticationService {
     }
 
     getBpmLoggedUser(): Observable<UserRepresentation> {
-        return Observable.fromPromise(this.alfrescoApi.getInstance().activiti.profileApi.getProfile());
+        return from(this.alfrescoApi.getInstance().activiti.profileApi.getProfile());
     }
 
     private hasValidRedirection(provider: string): boolean {
@@ -251,6 +252,6 @@ export class AuthenticationService {
      */
     handleError(error: any): Observable<any> {
         this.logService.error('Error when logging in', error);
-        return Observable.throw(error || 'Server error');
+        return throwError(error || 'Server error');
     }
 }