[ADF-3299] and [ADF-3300] upgrade to Angular and Material 6 (#3579)

* upgrade to HttpClient

* upgrade to Renderer2

* upgrade Document reference

* remove useless test with deprecated ReflectiveInjector

* upgrade to latest typescript

* upgrade libs

* upgrade package scripts

* remove rxjs blacklists and duplicate rules

* add rxjs compat to help with migration

* fix breaking changes

* fix breaking changes in material

* fix breaking changes (material 6)

* upgrade rxjs, ngx-translate and flex layout

* update unit tests

* restore providers

* upgrade deprecated Observable.error

* rebase
fix first configuration problems

* fix style issues commented

* fix core build

* fix lib template errors

* move lib test execution in angular.json

* ignore

* karma conf files

* fix import statement test

* single run option

* update packages reporter

* restore report

* increase timeout

* improve karma conf test configuration

* fix test issues about lint

* fix test analytics

* fix process service test

* content service fix test

* fix logout directive test

* fix core test

* fix build

* update node-sass to latest

* update angular cli dependencies

* improve build script

create directorites and move files only if previous command succeded

* upgrade individual libs to 6.0

* remove old webpack files

* revert sass change

* fix type issues
fix style issues

* fix tslint demo shell issue

* fix peerdependencies

* fix test e2e BC

* package upate

* fix style import issue

* extract-text-webpack-plugin beta

* fix test dist build command

* remove alpha js-api

* fix tslint issue
add banner tslint rule

* upload service fix

* change BC script

* fix test dist script

* increase demo shell timeout test

* verbose copy

* path absolute

* fix script bc

* fix copy part

* fix path warning
fix monaco editor

* remove duplicate header

* remove unused import

* fix align and check ago tests

* add missing import

* fix notification button selector

* [ANGULAR6] fixed core tests

* fix CS test

* fix cs test step 2

* increase travis_wait for dist

* fix attachment PS

* fix checklist test

* use pdf min

lib/core/services/comment-content.service.ts

@@ -16,13 +16,11 @@
  */
 
 import { Injectable } from '@angular/core';
-import { Observable } from 'rxjs/Observable';
+import { Observable, from, throwError } from 'rxjs';
 import { CommentModel } from '../models/comment.model';
 import { AlfrescoApiService } from '../services/alfresco-api.service';
 import { LogService } from '../services/log.service';
-import 'rxjs/add/observable/fromPromise';
-import 'rxjs/add/operator/catch';
-import 'rxjs/add/observable/throw';
+import { map, catchError } from 'rxjs/operators';
 
 @Injectable()
 export class CommentContentService {
@@ -38,15 +36,18 @@ export class CommentContentService {
      * @returns Details of the comment added
      */
     addNodeComment(nodeId: string, message: string): Observable<CommentModel> {
-        return Observable.fromPromise(this.apiService.getInstance().core.commentsApi.addComment(nodeId, {content: message}))
-            .map((response: any) => {
-                return new CommentModel({
-                    id: response.entry.id,
-                    message: response.entry.content,
-                    created: response.entry.createdAt,
-                    createdBy: response.entry.createdBy
-                });
-            }).catch(err => this.handleError(err));
+        return from(this.apiService.getInstance().core.commentsApi.addComment(nodeId, {content: message}))
+            .pipe(
+                map((response: any) => {
+                    return new CommentModel({
+                        id: response.entry.id,
+                        message: response.entry.content,
+                        created: response.entry.createdAt,
+                        createdBy: response.entry.createdBy
+                    });
+                }),
+                catchError(err => this.handleError(err))
+            );
     }
 
     /**
@@ -55,24 +56,27 @@ export class CommentContentService {
      * @returns Details for each comment
      */
     getNodeComments(nodeId: string): Observable<CommentModel[]> {
-        return Observable.fromPromise(this.apiService.getInstance().core.commentsApi.getComments(nodeId))
-            .map((response: any) => {
-                const comments: CommentModel[] = [];
-                response.list.entries.forEach((comment: any) => {
-                    comments.push(new CommentModel({
-                        id: comment.entry.id,
-                        message: comment.entry.content,
-                        created: comment.entry.createdAt,
-                        createdBy: comment.entry.createdBy
-                    }));
-                });
-                return comments;
-            }).catch(err => this.handleError(err));
+        return from(this.apiService.getInstance().core.commentsApi.getComments(nodeId))
+            .pipe(
+                map((response: any) => {
+                    const comments: CommentModel[] = [];
+                    response.list.entries.forEach((comment: any) => {
+                        comments.push(new CommentModel({
+                            id: comment.entry.id,
+                            message: comment.entry.content,
+                            created: comment.entry.createdAt,
+                            createdBy: comment.entry.createdBy
+                        }));
+                    });
+                    return comments;
+                }),
+                catchError(err => this.handleError(err))
+            );
     }
 
     private handleError(error: any) {
         this.logService.error(error);
-        return Observable.throw(error || 'Server error');
+        return throwError(error || 'Server error');
     }
 
 }