[ADF-3299] and [ADF-3300] upgrade to Angular and Material 6 (#3579)

* upgrade to HttpClient

* upgrade to Renderer2

* upgrade Document reference

* remove useless test with deprecated ReflectiveInjector

* upgrade to latest typescript

* upgrade libs

* upgrade package scripts

* remove rxjs blacklists and duplicate rules

* add rxjs compat to help with migration

* fix breaking changes

* fix breaking changes in material

* fix breaking changes (material 6)

* upgrade rxjs, ngx-translate and flex layout

* update unit tests

* restore providers

* upgrade deprecated Observable.error

* rebase
fix first configuration problems

* fix style issues commented

* fix core build

* fix lib template errors

* move lib test execution in angular.json

* ignore

* karma conf files

* fix import statement test

* single run option

* update packages reporter

* restore report

* increase timeout

* improve karma conf test configuration

* fix test issues about lint

* fix test analytics

* fix process service test

* content service fix test

* fix logout directive test

* fix core test

* fix build

* update node-sass to latest

* update angular cli dependencies

* improve build script

create directorites and move files only if previous command succeded

* upgrade individual libs to 6.0

* remove old webpack files

* revert sass change

* fix type issues
fix style issues

* fix tslint demo shell issue

* fix peerdependencies

* fix test e2e BC

* package upate

* fix style import issue

* extract-text-webpack-plugin beta

* fix test dist build command

* remove alpha js-api

* fix tslint issue
add banner tslint rule

* upload service fix

* change BC script

* fix test dist script

* increase demo shell timeout test

* verbose copy

* path absolute

* fix script bc

* fix copy part

* fix path warning
fix monaco editor

* remove duplicate header

* remove unused import

* fix align and check ago tests

* add missing import

* fix notification button selector

* [ANGULAR6] fixed core tests

* fix CS test

* fix cs test step 2

* increase travis_wait for dist

* fix attachment PS

* fix checklist test

* use pdf min

lib/process-services/app-list/apps-list.component.spec.ts

@@ -19,7 +19,7 @@ import { DebugElement, Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { AppsProcessService, setupTestBed } from '@alfresco/adf-core';
-import { Observable } from 'rxjs/Observable';
+import { of, throwError } from 'rxjs';
 
 import { defaultApp, deployedApps, nonDeployedApps } from '../mock/apps-list.mock';
 import { AppsListComponent } from './apps-list.component';
@@ -43,7 +43,7 @@ describe('AppsListComponent', () => {
         debugElement = fixture.debugElement;
 
         service = TestBed.get(AppsProcessService);
-        getAppsSpy = spyOn(service, 'getDeployedApplications').and.returnValue(Observable.of(deployedApps));
+        getAppsSpy = spyOn(service, 'getDeployedApplications').and.returnValue(of(deployedApps));
     });
 
     it('should define layoutType with the default value', () => {
@@ -125,7 +125,7 @@ describe('AppsListComponent', () => {
 
     it('should emit an error when an error occurs loading apps', () => {
         let emitSpy = spyOn(component.error, 'emit');
-        getAppsSpy.and.returnValue(Observable.throw({}));
+        getAppsSpy.and.returnValue(throwError({}));
         fixture.detectChanges();
         expect(emitSpy).toHaveBeenCalled();
     });
@@ -185,19 +185,19 @@ describe('AppsListComponent', () => {
     describe('display apps', () => {
 
         it('should display all deployed apps', () => {
-            getAppsSpy.and.returnValue(Observable.of(deployedApps));
+            getAppsSpy.and.returnValue(of(deployedApps));
             fixture.detectChanges();
             expect(debugElement.queryAll(By.css('h1')).length).toBe(6);
         });
 
         it('should not display undeployed apps', () => {
-            getAppsSpy.and.returnValue(Observable.of(nonDeployedApps));
+            getAppsSpy.and.returnValue(of(nonDeployedApps));
             fixture.detectChanges();
             expect(debugElement.queryAll(By.css('h1')).length).toBe(0);
         });
 
         it('should display default app', () => {
-            getAppsSpy.and.returnValue(Observable.of(defaultApp));
+            getAppsSpy.and.returnValue(of(defaultApp));
             fixture.detectChanges();
             expect(debugElement.queryAll(By.css('h1')).length).toBe(1);
         });
@@ -207,7 +207,7 @@ describe('AppsListComponent', () => {
     describe('select apps', () => {
 
         beforeEach(() => {
-            getAppsSpy.and.returnValue(Observable.of(deployedApps));
+            getAppsSpy.and.returnValue(of(deployedApps));
             fixture.detectChanges();
         });
 

lib/process-services/app-list/apps-list.component.ts

@@ -17,10 +17,10 @@
 
 import { AppsProcessService, TranslationService, EmptyCustomContentDirective } from '@alfresco/adf-core';
 import { AfterContentInit, Component, EventEmitter, Input, OnInit, Output, ContentChild } from '@angular/core';
-import { Observable } from 'rxjs/Observable';
-import { Observer } from 'rxjs/Observer';
+import { Observable, Observer, of } from 'rxjs';
 import { AppDefinitionRepresentationModel } from '../task-list';
 import { IconModel } from './icon.model';
+import { share } from 'rxjs/operators';
 
 @Component({
     selector: 'adf-apps',
@@ -74,7 +74,8 @@ export class AppsListComponent implements OnInit, AfterContentInit {
     constructor(
         private appsProcessService: AppsProcessService,
         private translationService: TranslationService) {
-            this.apps$ = new Observable<AppDefinitionRepresentationModel>(observer => this.appsObserver = observer).share();
+            this.apps$ = new Observable<AppDefinitionRepresentationModel>(observer => this.appsObserver = observer)
+                .pipe(share());
     }
 
     ngOnInit() {
@@ -125,7 +126,7 @@ export class AppsListComponent implements OnInit, AfterContentInit {
     getAppName(app) {
         return this.isDefaultApp(app)
             ? this.translationService.get(AppsListComponent.DEFAULT_TASKS_APP_NAME)
-            : Observable.of(app.name);
+            : of(app.name);
     }
 
     /**

lib/process-services/app-list/select-apps-dialog-component.spec.ts

@@ -23,7 +23,7 @@ import { MatDialog } from '@angular/material';
 import { OverlayContainer } from '@angular/cdk/overlay';
 import { AppsProcessService, setupTestBed } from '@alfresco/adf-core';
 import { deployedApps } from '../mock/apps-list.mock';
-import { Observable } from 'rxjs/Observable';
+import { of } from 'rxjs';
 
 import { SelectAppsDialogComponent } from './select-apps-dialog-component';
 import { ProcessTestingModule } from '../testing/process.testing.module';
@@ -90,7 +90,7 @@ describe('Select app dialog', () => {
         service = TestBed.get(AppsProcessService);
 
         spyOn(service, 'getDeployedApplications').and.returnValue(
-            Observable.of(deployedApps)
+            of(deployedApps)
         );
     });