[ADF-3299] and [ADF-3300] upgrade to Angular and Material 6 (#3579)

* upgrade to HttpClient

* upgrade to Renderer2

* upgrade Document reference

* remove useless test with deprecated ReflectiveInjector

* upgrade to latest typescript

* upgrade libs

* upgrade package scripts

* remove rxjs blacklists and duplicate rules

* add rxjs compat to help with migration

* fix breaking changes

* fix breaking changes in material

* fix breaking changes (material 6)

* upgrade rxjs, ngx-translate and flex layout

* update unit tests

* restore providers

* upgrade deprecated Observable.error

* rebase
fix first configuration problems

* fix style issues commented

* fix core build

* fix lib template errors

* move lib test execution in angular.json

* ignore

* karma conf files

* fix import statement test

* single run option

* update packages reporter

* restore report

* increase timeout

* improve karma conf test configuration

* fix test issues about lint

* fix test analytics

* fix process service test

* content service fix test

* fix logout directive test

* fix core test

* fix build

* update node-sass to latest

* update angular cli dependencies

* improve build script

create directorites and move files only if previous command succeded

* upgrade individual libs to 6.0

* remove old webpack files

* revert sass change

* fix type issues
fix style issues

* fix tslint demo shell issue

* fix peerdependencies

* fix test e2e BC

* package upate

* fix style import issue

* extract-text-webpack-plugin beta

* fix test dist build command

* remove alpha js-api

* fix tslint issue
add banner tslint rule

* upload service fix

* change BC script

* fix test dist script

* increase demo shell timeout test

* verbose copy

* path absolute

* fix script bc

* fix copy part

* fix path warning
fix monaco editor

* remove duplicate header

* remove unused import

* fix align and check ago tests

* add missing import

* fix notification button selector

* [ANGULAR6] fixed core tests

* fix CS test

* fix cs test step 2

* increase travis_wait for dist

* fix attachment PS

* fix checklist test

* use pdf min

lib/process-services/task-list/components/checklist.component.spec.ts

@@ -22,7 +22,7 @@ import { ChecklistComponent } from './checklist.component';
 import { setupTestBed } from '@alfresco/adf-core';
 import { ProcessTestingModule } from '../../testing/process.testing.module';
 import { TaskListService } from './../services/tasklist.service';
-import { Observable } from 'rxjs/Observable';
+import { of } from 'rxjs';
 
 describe('ChecklistComponent', () => {
 
@@ -38,7 +38,10 @@ describe('ChecklistComponent', () => {
 
     beforeEach(async(() => {
         service = TestBed.get(TaskListService);
-        spyOn(service, 'getTaskChecklist').and.returnValue(Observable.of([{ id: 'fake-check-changed-id', name: 'fake-check-changed-name' }] ));
+        spyOn(service, 'getTaskChecklist').and.returnValue(of([{
+            id: 'fake-check-changed-id',
+            name: 'fake-check-changed-name'
+        }]));
 
         fixture = TestBed.createComponent(ChecklistComponent);
         checklistComponent = fixture.componentInstance;
@@ -48,8 +51,8 @@ describe('ChecklistComponent', () => {
     }));
 
     it('should show checklist component title', () => {
-        expect(element.querySelector('#checklist-label')).toBeDefined();
-        expect(element.querySelector('#checklist-label')).not.toBeNull();
+        expect(element.querySelector('[data-automation-id=checklist-label]')).toBeDefined();
+        expect(element.querySelector('[data-automation-id=checklist-label]')).not.toBeNull();
     });
 
     it('should show no checklist message', () => {
@@ -167,8 +170,8 @@ describe('ChecklistComponent', () => {
         });
 
         it('should add checklist', async(() => {
-            spyOn(service, 'addTask').and.returnValue(Observable.of({
-              id: 'fake-check-added-id', name: 'fake-check-added-name'
+            spyOn(service, 'addTask').and.returnValue(of({
+                id: 'fake-check-added-id', name: 'fake-check-added-name'
             }));
 
             showChecklistDialog.click();
@@ -183,7 +186,7 @@ describe('ChecklistComponent', () => {
         }));
 
         it('should remove a checklist element', async(() => {
-            spyOn(service, 'deleteTask').and.returnValue(Observable.of(''));
+            spyOn(service, 'deleteTask').and.returnValue(of(''));
 
             checklistComponent.taskId = 'new-fake-task-id';
             checklistComponent.checklist.push(new TaskDetailsModel({
@@ -203,7 +206,7 @@ describe('ChecklistComponent', () => {
         }));
 
         it('should send an event when the checklist is deleted', (done) => {
-            spyOn(service, 'deleteTask').and.returnValue(Observable.of(''));
+            spyOn(service, 'deleteTask').and.returnValue(of(''));
             let disposableDelete = checklistComponent.checklistTaskDeleted.subscribe(() => {
                 expect(element.querySelector('#fake-check-id')).toBeNull();
                 disposableDelete.unsubscribe();
@@ -262,7 +265,7 @@ describe('ChecklistComponent', () => {
         }));
 
         it('should emit checklist task created event when the checklist is successfully added', (done) => {
-            spyOn(service, 'addTask').and.returnValue(Observable.of({ id: 'fake-check-added-id', name: 'fake-check-added-name' }));
+            spyOn(service, 'addTask').and.returnValue(of({ id: 'fake-check-added-id', name: 'fake-check-added-name' }));
 
             let disposableCreated = checklistComponent.checklistTaskCreated.subscribe((taskAdded: TaskDetailsModel) => {
                 fixture.detectChanges();