[ADF-3299] and [ADF-3300] upgrade to Angular and Material 6 (#3579)

* upgrade to HttpClient

* upgrade to Renderer2

* upgrade Document reference

* remove useless test with deprecated ReflectiveInjector

* upgrade to latest typescript

* upgrade libs

* upgrade package scripts

* remove rxjs blacklists and duplicate rules

* add rxjs compat to help with migration

* fix breaking changes

* fix breaking changes in material

* fix breaking changes (material 6)

* upgrade rxjs, ngx-translate and flex layout

* update unit tests

* restore providers

* upgrade deprecated Observable.error

* rebase
fix first configuration problems

* fix style issues commented

* fix core build

* fix lib template errors

* move lib test execution in angular.json

* ignore

* karma conf files

* fix import statement test

* single run option

* update packages reporter

* restore report

* increase timeout

* improve karma conf test configuration

* fix test issues about lint

* fix test analytics

* fix process service test

* content service fix test

* fix logout directive test

* fix core test

* fix build

* update node-sass to latest

* update angular cli dependencies

* improve build script

create directorites and move files only if previous command succeded

* upgrade individual libs to 6.0

* remove old webpack files

* revert sass change

* fix type issues
fix style issues

* fix tslint demo shell issue

* fix peerdependencies

* fix test e2e BC

* package upate

* fix style import issue

* extract-text-webpack-plugin beta

* fix test dist build command

* remove alpha js-api

* fix tslint issue
add banner tslint rule

* upload service fix

* change BC script

* fix test dist script

* increase demo shell timeout test

* verbose copy

* path absolute

* fix script bc

* fix copy part

* fix path warning
fix monaco editor

* remove duplicate header

* remove unused import

* fix align and check ago tests

* add missing import

* fix notification button selector

* [ANGULAR6] fixed core tests

* fix CS test

* fix cs test step 2

* increase travis_wait for dist

* fix attachment PS

* fix checklist test

* use pdf min

lib/process-services/task-list/components/start-task.component.ts

@@ -21,11 +21,12 @@ import { DateAdapter, MAT_DATE_FORMATS } from '@angular/material/core';
 import { MOMENT_DATE_FORMATS, MomentDateAdapter } from '@alfresco/adf-core';
 import moment from 'moment-es6';
 import { Moment } from 'moment';
-import { Observable } from 'rxjs/Observable';
+import { Observable, of } from 'rxjs';
 import { Form } from '../models/form.model';
 import { StartTaskModel } from '../models/start-task.model';
 import { TaskDetailsModel } from '../models/task-details.model';
 import { TaskListService } from './../services/tasklist.service';
+import { switchMap, defaultIfEmpty } from 'rxjs/operators';
 
 @Component({
     selector: 'adf-start-task',
@@ -96,11 +97,17 @@ export class StartTaskComponent implements OnInit {
                 this.startTaskmodel.category = this.appId.toString();
             }
             this.taskService.createNewTask(new TaskDetailsModel(this.startTaskmodel))
-                .switchMap((createRes: any) =>
-                    this.attachForm(createRes.id, this.formKey).defaultIfEmpty(createRes)
-                        .switchMap((attachRes: any) =>
-                            this.assignTaskByUserId(createRes.id, this.assigneeId).defaultIfEmpty(attachRes ? attachRes : createRes)
+                .pipe(
+                    switchMap((createRes: any) =>
+                        this.attachForm(createRes.id, this.formKey).pipe(
+                            defaultIfEmpty(createRes),
+                            switchMap((attachRes: any) =>
+                                this.assignTaskByUserId(createRes.id, this.assigneeId).pipe(
+                                    defaultIfEmpty(attachRes ? attachRes : createRes)
+                                )
+                            )
                         )
+                    )
                 )
                 .subscribe(
                     (res: any) => {
@@ -118,7 +125,7 @@ export class StartTaskComponent implements OnInit {
     }
 
     private attachForm(taskId: string, formKey: number): Observable<any> {
-        let response = Observable.of();
+        let response = of();
         if (taskId && formKey) {
             response = this.taskService.attachFormToATask(taskId, formKey);
         }
@@ -126,7 +133,7 @@ export class StartTaskComponent implements OnInit {
     }
 
     private assignTaskByUserId(taskId: string, userId: any): Observable<any> {
-        let response = Observable.of();
+        let response = of();
         if (taskId && userId) {
             response = this.taskService.assignTaskByUserId(taskId, userId);
         }