From 70c523546ab997eddaf738ebd24f1bc4f446c040 Mon Sep 17 00:00:00 2001 From: gmandakini <45559635+gmandakini@users.noreply.github.com> Date: Mon, 25 Feb 2019 11:35:55 +0000 Subject: [PATCH] [ADF-4066] Start task form with no assignee is saved as unassigned task (#4347) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * in progress * in progress * ADF-4012 pull request ready * crc's * crc's - moved the methods ProcessListCloudComponent to dataTablePage, to keep it common. * crc's - moved the methods ProcessListCloudComponent to dataTablePage, to keep it common. * changed the locator to use data-automation-id * linting fix * test automated - C268974 * test automated - C268974 * crc's * crc's * crc's * crc's * linting fix * added automation for C276980 - Duplicate User or Group * merged the overlapping testcases * Changed checkUserHasRoleSelected to use datatable methods * changed hte usernames to something more relevant and readable. * [ADF-4066] Should create a task unassigned when assignee field is empty … (#4334) * C297675 Should create a task unassigned when assignee field is empty in Start Task form automated * linting fixes and updated some locators which are returning more than 1 result back when running this test, as part of best practices. * using hte new method added as it's more efficient, getIdCellValue * linting fixes * updates * updated the taskname variables to more meaningful ones. * added data-automation-id for better test locators. --- .../task-details-cloud-demo.component.html | 2 +- .../process-services/taskDetailsPage.ts | 46 +++++++++++++++++++ .../process-cloud/taskListCloudComponent.ts | 14 +++++- .../start-task-custom-app-cloud.e2e.ts | 42 +++++++++++++---- 4 files changed, 91 insertions(+), 13 deletions(-) create mode 100644 e2e/pages/adf/demo-shell/process-services/taskDetailsPage.ts diff --git a/demo-shell/src/app/components/app-layout/cloud/task-details-cloud-demo.component.html b/demo-shell/src/app/components/app-layout/cloud/task-details-cloud-demo.component.html index fbf0675087..c3f4a4d399 100644 --- a/demo-shell/src/app/components/app-layout/cloud/task-details-cloud-demo.component.html +++ b/demo-shell/src/app/components/app-layout/cloud/task-details-cloud-demo.component.html @@ -3,7 +3,7 @@ arrow_back Go Back -

Simple page to show the taskId: {{ taskId }} of the app: {{ appName }}

+

Simple page to show the taskId: {{ taskId }} of the app: {{ appName }}

{ const settingsPage = new SettingsPage(); const loginSSOPage = new LoginSSOPage(); + const taskDetailsPage = new TaskDetailsPage(); const navigationBarPage = new NavigationBarPage(); const appListCloudComponent = new AppListCloudComponent(); const tasksCloudDemoPage = new TasksCloudDemoPage(); const startTask = new StartTasksCloudComponent(); - const standaloneTaskName1 = Util.generateRandomString(5); - const standaloneTaskName2 = Util.generateRandomString(5); + const standaloneTaskName = Util.generateRandomString(5); + const unassignedTaskName = Util.generateRandomString(5); const taskName255Characters = Util.generateRandomString(255); const taskNameBiggerThen255Characters = Util.generateRandomString(256); const lengthValidationError = 'Length exceeded, 255 characters max.'; @@ -61,22 +63,22 @@ describe('Start Task', () => { startTask.checkStartButtonIsDisabled() .blur(startTask.name) .checkValidationErrorIsDisplayed(requiredError); - startTask.addName(standaloneTaskName1) + startTask.addName(standaloneTaskName) .addDescription('descriptions') .addDueDate('12/12/2018'); startTask.checkStartButtonIsEnabled(); startTask.clickCancelButton(); - tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsNotDisplayed(standaloneTaskName1); + tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsNotDisplayed(standaloneTaskName); }); it('[C290180] Should be able to create a new standalone task', () => { tasksCloudDemoPage.openNewTaskForm(); - startTask.addName(standaloneTaskName1) + startTask.addName(standaloneTaskName) .addDescription('descriptions') .addDueDate('12/12/2018') .addPriority('50') .clickStartButton(); - tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsDisplayed(standaloneTaskName1); + tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsDisplayed(standaloneTaskName); }); it('[C290181] Should be displayed an error message if task name exceed 255 characters', () => { @@ -103,12 +105,12 @@ describe('Start Task', () => { it('[C290182] Should be possible to assign the task to another user', () => { tasksCloudDemoPage.openNewTaskForm(); - startTask.addName(standaloneTaskName1) + startTask.addName(standaloneTaskName) .addAssignee('Super Admin') .clickStartButton(); tasksCloudDemoPage.myTasksFilter().clickTaskFilter(); expect(tasksCloudDemoPage.getActiveFilterName()).toBe('My Tasks'); - tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsNotDisplayed(standaloneTaskName1); + tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsNotDisplayed(standaloneTaskName); }); it('[C291953] Assignee field should display the logged user as default', () => { @@ -119,14 +121,34 @@ describe('Start Task', () => { it('[C291956] Should be able to create a new standalone task without assignee', () => { tasksCloudDemoPage.openNewTaskForm(); - startTask.addName(standaloneTaskName2); + startTask.addName(unassignedTaskName); startTask.clearField(startTask.assignee); startTask.clickStartButton(); tasksCloudDemoPage.editTaskFilterCloudComponent() .clickCustomiseFilterHeader() .setStateFilterDropDown('CREATED') .clearAssignment(); - tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsDisplayed(standaloneTaskName2); + tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsDisplayed(unassignedTaskName); + }); + + it('[C297675] Should create a task unassigned when assignee field is empty in Start Task form', () => { + + tasksCloudDemoPage.openNewTaskForm(); + startTask.addName(unassignedTaskName); + startTask.clearField(startTask.assignee); + startTask.clickStartButton(); + tasksCloudDemoPage.editTaskFilterCloudComponent() + .clickCustomiseFilterHeader() + .setStateFilterDropDown('CREATED') + .clearAssignment(); + tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody(); + tasksCloudDemoPage.taskListCloudComponent().getDataTable().checkContentIsDisplayed(unassignedTaskName); + let taskId = tasksCloudDemoPage.taskListCloudComponent().getIdCellValue(unassignedTaskName); + tasksCloudDemoPage.taskListCloudComponent().getDataTable().selectRowByContentName(unassignedTaskName); + expect(taskDetailsPage.getTaskDetailsHeader()).toContain(taskId); + expect(taskDetailsPage.getPropertyLabel('assignee')).toBe('Assignee'); + expect(taskDetailsPage.getPropertyValue('assignee')).toBe('No assignee'); + }); });