From 718b3e88175eed4514193ac4a17db828f5c4906e Mon Sep 17 00:00:00 2001
From: Eugenio Romano <eromano@users.noreply.github.com>
Date: Wed, 3 Oct 2018 15:20:37 +0100
Subject: [PATCH] rename hasIcon to shoIcon to be equal to process-filter
 (#3855)

---
 .../process-service/process-service.component.html        | 2 +-
 docs/process-services/task-filters.component.md           | 2 +-
 .../task-list/components/task-filters.component.html      | 2 +-
 .../task-list/components/task-filters.component.spec.ts   | 8 ++++----
 .../task-list/components/task-filters.component.ts        | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/demo-shell/src/app/components/process-service/process-service.component.html b/demo-shell/src/app/components/process-service/process-service.component.html
index 7f645c83bd..93f262e5f6 100644
--- a/demo-shell/src/app/components/process-service/process-service.component.html
+++ b/demo-shell/src/app/components/process-service/process-service.component.html
@@ -22,7 +22,7 @@
                             <adf-task-filters
                                 [filterParam]="filterSelected"
                                 [appId]="appId"
-                                [hasIcon]="showTaskFilterIcon"
+                                [showIcon]="showTaskFilterIcon"
                                 (filterClick)="onTaskFilterClick($event)"
                                 (success)="onSuccessTaskFilterList($event)"
                                 #activitifilter>
diff --git a/docs/process-services/task-filters.component.md b/docs/process-services/task-filters.component.md
index 67bb4ba9fd..289324a8d4 100644
--- a/docs/process-services/task-filters.component.md
+++ b/docs/process-services/task-filters.component.md
@@ -34,7 +34,7 @@ Shows all available filters.
 | appId | `number` |  | Display filters available to the current user for the application with the specified ID. |
 | appName | `string` |  | Display filters available to the current user for the application with the specified name. |
 | filterParam | [`FilterParamsModel`](../../lib/process-services/task-list/models/filter.model.ts) |  | Parameters to use for the task filter. If there is no match then the default filter (the first one the list) is selected. |
-| hasIcon | `boolean` | true | Toggles display of the filter's icon. |
+| showIcon| `boolean` | true | Toggles display of the filter's icon. |
 
 ### Events
 
diff --git a/lib/process-services/task-list/components/task-filters.component.html b/lib/process-services/task-list/components/task-filters.component.html
index d10cbb7da3..92062150a7 100644
--- a/lib/process-services/task-list/components/task-filters.component.html
+++ b/lib/process-services/task-list/components/task-filters.component.html
@@ -2,7 +2,7 @@
     <mat-list class="adf-menu-list">
         <mat-list-item (click)="selectFilterAndEmit(filter)" *ngFor="let filter of filters"
                       class="adf-filters__entry" [class.active]="currentFilter === filter">
-            <mat-icon *ngIf="hasIcon" matListIcon class="adf-filters__entry-icon">{{getFilterIcon(filter.icon)}}</mat-icon>
+            <mat-icon *ngIf="showIcon" matListIcon class="adf-filters__entry-icon">{{getFilterIcon(filter.icon)}}</mat-icon>
             <span matLine [attr.data-automation-id]="filter.name + '_filter'">{{filter.name}}</span>
         </mat-list-item>
     </mat-list>
diff --git a/lib/process-services/task-list/components/task-filters.component.spec.ts b/lib/process-services/task-list/components/task-filters.component.spec.ts
index e98b70b0b5..6b51b96483 100644
--- a/lib/process-services/task-list/components/task-filters.component.spec.ts
+++ b/lib/process-services/task-list/components/task-filters.component.spec.ts
@@ -355,9 +355,9 @@ describe('TaskFiltersComponent', () => {
         expect(component.currentFilter).toBe(filter);
     }));
 
-    it('should attach specific icon for each filter if hasIcon is true', (done) => {
+    it('should attach specific icon for each filter if showIcon is true', (done) => {
         spyOn(taskFilterService, 'getTaskListFilters').and.returnValue(from(fakeGlobalFilterPromise));
-        component.hasIcon = true;
+        component.showIcon = true;
         let change = new SimpleChange(undefined, 1, true);
         component.ngOnChanges({ 'appId': change });
         fixture.detectChanges();
@@ -373,9 +373,9 @@ describe('TaskFiltersComponent', () => {
         });
     });
 
-    it('should not attach icons for each filter if hasIcon is false', (done) => {
+    it('should not attach icons for each filter if showIcon is false', (done) => {
         spyOn(taskFilterService, 'getTaskListFilters').and.returnValue(from(fakeGlobalFilterPromise));
-        component.hasIcon = false;
+        component.showIcon = false;
         let change = new SimpleChange(undefined, 1, true);
         component.ngOnChanges({ 'appId': change });
         fixture.detectChanges();
diff --git a/lib/process-services/task-list/components/task-filters.component.ts b/lib/process-services/task-list/components/task-filters.component.ts
index 05fc1e1f2d..5f4a220e90 100644
--- a/lib/process-services/task-list/components/task-filters.component.ts
+++ b/lib/process-services/task-list/components/task-filters.component.ts
@@ -61,7 +61,7 @@ export class TaskFiltersComponent implements OnInit, OnChanges {
 
     /** Toggles display of the filter's icon. */
     @Input()
-    hasIcon: boolean;
+    showIcon: boolean;
 
     filter$: Observable<FilterRepresentationModel>;