[ACA-3107] add possibility to hide task name from the sidenav (#5883)

* [ACA-3107] add possibility to hide task name from the sidenav

* add unit tesT

* add task header spinner

* update documentation

* fix unit test

* change expect

* add another check

* replace expect condition

* additional expect

* use ToBeTruthy

* simplify expect

* add unit tesT

* add task header spinner

* fix unit test

* change expect

* add another check

* additional expect

* use ToBeTruthy

* simplify expect

Co-authored-by: Silviu Popa <p3701014@L3700101120.ness.com>
This commit is contained in:
Silviu Popa 2020-07-27 14:12:44 +03:00 committed by GitHub
parent 6fa62fd62d
commit 7399704d57
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 42 additions and 1 deletions

View File

@ -27,6 +27,7 @@ Shows all the information related to a task.
| Name | Type | Default value | Description | | Name | Type | Default value | Description |
| ---- | ---- | ------------- | ----------- | | ---- | ---- | ------------- | ----------- |
| appName | `string` | "" | (Required) The name of the application. | | appName | `string` | "" | (Required) The name of the application. |
| showTitle | `boolean` | true | Show/Hide the task title |
| taskId | `string` | | (Required) The id of the task. | | taskId | `string` | | (Required) The id of the task. |
### Events ### Events

View File

@ -1,9 +1,10 @@
<h3 class="adf-task-title">{{ taskDetails?.name }}</h3> <h3 *ngIf="showTitle" class="adf-task-title">{{ taskDetails?.name }}</h3>
<div class="adf-task-header-container"> <div class="adf-task-header-container">
<mat-card *ngIf="isTaskValid()" class="adf-card-container"> <mat-card *ngIf="isTaskValid()" class="adf-card-container">
<mat-card-content> <mat-card-content>
<adf-card-view <adf-card-view
*ngIf="properties; else loadingTemplate"
[properties]="properties" [properties]="properties"
[editable]="isTaskEditable()" [editable]="isTaskEditable()"
[displayClearAction]="displayDateClearAction"> [displayClearAction]="displayDateClearAction">
@ -11,3 +12,9 @@
</mat-card-content> </mat-card-content>
</mat-card> </mat-card>
</div> </div>
<ng-template #loadingTemplate>
<div class="adf-task-header-loading">
<mat-spinner></mat-spinner>
</div>
</ng-template>

View File

@ -22,6 +22,11 @@
&-claim-controls { &-claim-controls {
color: rgb(131, 131, 131); color: rgb(131, 131, 131);
} }
&-task-header-loading {
display: flex;
justify-content: center;
}
} }
@media screen and ($mat-small) { @media screen and ($mat-small) {
@ -32,3 +37,8 @@
} }
} }
} }
.adf-task-header-loading {
display: flex;
justify-content: center;
}

View File

@ -73,6 +73,18 @@ describe('TaskHeaderCloudComponent', () => {
component.ngOnChanges(); component.ngOnChanges();
}); });
it('should hide the title if showTitle is false', () => {
component.showTitle = false;
fixture.detectChanges();
let taskTitle = fixture.debugElement.query(By.css('.adf-task-title'));
expect(taskTitle).toBeNull();
component.showTitle = true;
fixture.detectChanges();
taskTitle = fixture.debugElement.query(By.css('.adf-task-title'));
expect(taskTitle).toBeTruthy();
});
it('should fectch task details when appName and taskId defined', async(() => { it('should fectch task details when appName and taskId defined', async(() => {
fixture.detectChanges(); fixture.detectChanges();
fixture.whenStable().then(() => { fixture.whenStable().then(() => {
@ -188,6 +200,13 @@ describe('TaskHeaderCloudComponent', () => {
description = fixture.debugElement.query(By.css('[data-automation-id="card-textitem-value-description"]')); description = fixture.debugElement.query(By.css('[data-automation-id="card-textitem-value-description"]'));
expect(description.nativeElement.value.trim()).toEqual('This is the description'); expect(description.nativeElement.value.trim()).toEqual('This is the description');
}); });
it('should show loading spinner when properties are not loaded', () => {
component.properties = null;
fixture.detectChanges();
const loading = fixture.debugElement.query(By.css('.adf-task-header-loading'));
expect(loading).toBeTruthy();
});
}); });
describe('Task with parentTaskId', () => { describe('Task with parentTaskId', () => {

View File

@ -50,6 +50,10 @@ export class TaskHeaderCloudComponent implements OnInit, OnDestroy, OnChanges {
@Input() @Input()
taskId: string; taskId: string;
/** Show/Hide the task title */
@Input()
showTitle: boolean = true;
/** Emitted when the task is claimed. */ /** Emitted when the task is claimed. */
@Output() @Output()
claim: EventEmitter<any> = new EventEmitter<any>(); claim: EventEmitter<any> = new EventEmitter<any>();