From 749d133bfe867ea8f0189c3339ebf0b149c3e49a Mon Sep 17 00:00:00 2001 From: Denys Vuika Date: Mon, 31 Jul 2023 15:16:22 -0400 Subject: [PATCH] cleanup upload dialog page --- e2e/core/pages/dialog/upload-dialog.page.ts | 42 ++------------------- 1 file changed, 3 insertions(+), 39 deletions(-) diff --git a/e2e/core/pages/dialog/upload-dialog.page.ts b/e2e/core/pages/dialog/upload-dialog.page.ts index 6ab54c162a..6317e4086b 100644 --- a/e2e/core/pages/dialog/upload-dialog.page.ts +++ b/e2e/core/pages/dialog/upload-dialog.page.ts @@ -15,7 +15,7 @@ * limitations under the License. */ -import { element, by, browser, ElementFinder, $, $$ } from 'protractor'; +import { by, browser, ElementFinder, $, $$ } from 'protractor'; import { BrowserVisibility, BrowserActions } from '@alfresco/adf-testing'; export class UploadDialogPage { @@ -31,12 +31,6 @@ export class UploadDialogPage { title = $('span[class*="upload-dialog__title"]'); minimizeButton = $('mat-icon[title="Minimize"]'); maximizeButton = $('mat-icon[title="Maximize"]'); - canUploadConfirmationTitle = $('.upload-dialog__confirmation--title'); - canUploadConfirmationDescription = $('.upload-dialog__confirmation--text'); - confirmationDialogNoButton = element(by.partialButtonText('No')); - confirmationDialogYesButton = element(by.partialButtonText('Yes')); - cancelUploadsElement = $('footer[class*="upload-dialog__actions"] button[id="adf-upload-dialog-cancel-all"]'); - cancelUploadInProgressButton = $('div[data-automation-id="cancel-upload-progress"]'); async clickOnCloseButton(): Promise { await this.checkCloseButtonIsDisplayed(); @@ -76,8 +70,8 @@ export class UploadDialogPage { } async filesAreUploaded(content: string[]): Promise { - for (let i = 0; i < content.length; i++) { - await this.fileIsUploaded(content[i]); + for (const item of content) { + await this.fileIsUploaded(item); } } @@ -85,18 +79,6 @@ export class UploadDialogPage { await BrowserVisibility.waitUntilElementIsNotVisible($(`div[class*='uploading-row'] span[title="${content}"]`)); } - async cancelUploads(): Promise { - await BrowserActions.click(this.cancelUploadsElement); - } - - async cancelProgress(): Promise { - await BrowserActions.click(this.cancelUploadInProgressButton); - } - - async checkCancelProgressIsVisible(): Promise { - await BrowserVisibility.waitUntilElementIsVisible(this.cancelUploadInProgressButton); - } - async fileIsCancelled(content: string): Promise { const row: ElementFinder = await this.getRowByRowName(content); await BrowserVisibility.waitUntilElementIsVisible(row); @@ -115,24 +97,6 @@ export class UploadDialogPage { return this.title.getText(); } - async getConfirmationDialogTitleText(): Promise { - await BrowserVisibility.waitUntilElementIsVisible(this.canUploadConfirmationTitle); - return this.canUploadConfirmationTitle.getText(); - } - - async getConfirmationDialogDescriptionText(): Promise { - await BrowserVisibility.waitUntilElementIsVisible(this.canUploadConfirmationDescription); - return this.canUploadConfirmationDescription.getText(); - } - - async clickOnConfirmationDialogYesButton(): Promise { - await BrowserActions.click(this.confirmationDialogYesButton); - } - - async clickOnConfirmationDialogNoButton(): Promise { - await BrowserActions.click(this.confirmationDialogNoButton); - } - async numberOfCurrentFilesUploaded(): Promise { const text = await this.getTitleText(); return text.split('Uploaded ')[1].split(' / ')[0];