From 75e27ccb366c9cb664a02d259f47e53c4bd342a2 Mon Sep 17 00:00:00 2001 From: Denys Vuika Date: Fri, 6 Jul 2018 10:01:43 +0100 Subject: [PATCH] fix title translation (#3565) --- lib/core/services/page-title.service.spec.ts | 12 ++++++++++++ lib/core/services/page-title.service.ts | 1 + 2 files changed, 13 insertions(+) diff --git a/lib/core/services/page-title.service.spec.ts b/lib/core/services/page-title.service.spec.ts index 107c1f50bf..c9e1e22084 100644 --- a/lib/core/services/page-title.service.spec.ts +++ b/lib/core/services/page-title.service.spec.ts @@ -75,4 +75,16 @@ describe('AppTitle service', () => { translationService.translate.onLangChange.next( {}); expect(titleServiceSpy).toHaveBeenCalledWith('привет - My application'); }); + + it('should update title on new content download', () => { + spyOn(translationService, 'instant').and.returnValues('hello', 'привет'); + + pageTitleService.setTitle('key'); + expect(titleServiceSpy).toHaveBeenCalledWith('hello - My application'); + + ( titleService).setTitle.calls.reset(); + + translationService.translate.onTranslationChange.next( {}); + expect(titleServiceSpy).toHaveBeenCalledWith('привет - My application'); + }); }); diff --git a/lib/core/services/page-title.service.ts b/lib/core/services/page-title.service.ts index 822ebd0e65..7377cebd27 100644 --- a/lib/core/services/page-title.service.ts +++ b/lib/core/services/page-title.service.ts @@ -31,6 +31,7 @@ export class PageTitleService { private appConfig: AppConfigService, private translationService: TranslationService) { translationService.translate.onLangChange.subscribe(() => this.onLanguageChanged()); + translationService.translate.onTranslationChange.subscribe(() => this.onLanguageChanged()); } /**