From 76e8a5d52d25d1efe2a5942052268f9178b0db43 Mon Sep 17 00:00:00 2001 From: Mercy Chrysolite <48274621+mcchrys@users.noreply.github.com> Date: Mon, 3 Aug 2020 16:22:18 +0530 Subject: [PATCH] [ACA-3728] Remove the filter name from the custom filter header (#5940) * [ACA-3728] Remove the filter name from the custom filter header * Updated docs --- .../components/edit-task-filter-cloud.component.md | 1 + .../components/edit-task-filter-cloud.component.html | 2 +- .../edit-task-filter-cloud.component.spec.ts | 12 ++++++++++++ .../components/edit-task-filter-cloud.component.ts | 4 ++++ 4 files changed, 18 insertions(+), 1 deletion(-) diff --git a/docs/process-services-cloud/components/edit-task-filter-cloud.component.md b/docs/process-services-cloud/components/edit-task-filter-cloud.component.md index 389bc3fee5..c136fad060 100644 --- a/docs/process-services-cloud/components/edit-task-filter-cloud.component.md +++ b/docs/process-services-cloud/components/edit-task-filter-cloud.component.md @@ -49,6 +49,7 @@ Edits task filter details. | id | `string` | | (required) ID of the task filter. | | role | `string` | "" | user role. | | showFilterActions | `boolean` | true | Toggles the filter actions. | +| showTaskFilterName | `boolean` | true | Toggles display of task filter name | | showTitle | `boolean` | true | Toggles the title. | | sortProperties | `string[]` | | List of sort properties to display. | diff --git a/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.html b/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.html index 9441c33b8f..4e0ddb0fc9 100644 --- a/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.html +++ b/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.html @@ -2,7 +2,7 @@ - {{taskFilter.name | translate}} + {{taskFilter.name | translate}} {{ 'ADF_CLOUD_EDIT_TASK_FILTER.TITLE' | translate}}
diff --git a/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.spec.ts b/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.spec.ts index c4577da30f..357161300a 100644 --- a/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.spec.ts +++ b/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.spec.ts @@ -99,6 +99,18 @@ describe('EditTaskFilterCloudComponent', () => { expect(subTitle.innerText.trim()).toEqual('ADF_CLOUD_EDIT_TASK_FILTER.TITLE'); })); + it('should not display filter name if showFilterName is false', async(() => { + const taskFilterIdChange = new SimpleChange(null, 'mock-task-filter-id', true); + component.showTaskFilterName = false; + component.ngOnChanges({ 'id': taskFilterIdChange }); + fixture.detectChanges(); + const title = fixture.debugElement.nativeElement.querySelector('#adf-edit-task-filter-title-id'); + + fixture.whenStable().then(() => { + expect(title).toBeNull(); + }); + })); + it('should not display mat-spinner if isloading set to false', async(() => { const taskFilterIdChange = new SimpleChange(null, 'mock-task-filter-id', true); component.ngOnChanges({ 'id': taskFilterIdChange }); diff --git a/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.ts b/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.ts index b32c735016..f452f74596 100644 --- a/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.ts +++ b/lib/process-services-cloud/src/lib/task/task-filters/components/edit-task-filter-cloud.component.ts @@ -83,6 +83,10 @@ export class EditTaskFilterCloudComponent implements OnInit, OnChanges, OnDestro @Input() showTitle = true; + /** Toggles display of task filter name */ + @Input() + showTaskFilterName = true; + /** Emitted when a task filter property changes. */ @Output() filterChange: EventEmitter = new EventEmitter();