[AAE-46514] - Migration to PNPM (#11926)

* [AAE-46514] - using by default ignore-scripts and have a trusted list for those who are trusted

* [AAE-46514] - Improved the checks to cover more cases

* [AAE-46514] - Fixed copilot comments

* [AAE-46514] - OTher fixes

* [AAE-46514] - Fixing other improvements and comments

* [AAE-46514] - npmrc should be versioned to enforce the audit

* [AAE-46514] - Improved code

* [AAE-46514] - Removed the check on CI as we have other tools

* [AAE-46514] - Improved check, updated descriptions, skip check on CI as there is already Sonar

* [AAE-46514] - Reduced functions in smaller pieces

* [AAE-46514] - Migrating to Pnpm to increase safety

* [ci:force] - Checking

* [ci:force] - Fixed complexity of the scripts

* [ci:force] - Fixed complexity of the scripts

* [ci:force] - Fixed wrong typing on yml

* [ci:force] - Fixed sonar comments and added correct version to sha pinned action

* [ci:force] - Fixed cache hit for npmn

* [ci:force] - Improved eslint plugin so it can be built with standard action

* [ci:force] - Improved eslint plugin so it can be built with standard action

* [ci:force] - Added minimatch

* [ci:force] - Fixing issues

* [ci:force] - Removed 'run' as it is not needed

* [ci:force] - Using audit in place of custom scripts

* [ci:force] - Fixed vulnerabilities and removed custom scripts in favor of audit --critical

* [ci:force] - Added minimum time for publishing to install

* [ci:force] - Address issue with too new packages

* [ci:force] - Address issue with too new packages

lib/eslint-angular/main.js

@@ -1,8 +1 @@
-require('ts-node').register({
-    compilerOptions: {
-        module: 'commonjs',
-        target: 'es2019',
-    },
-});
-
-module.exports = require('./index.ts');
+module.exports = require('./dist/index.js');

lib/eslint-angular/project.json

@@ -9,16 +9,9 @@
       "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
       "options": {
-        "outputPath": "dist/libs/eslint-plugin-eslint-angular",
+        "outputPath": "lib/eslint-angular/dist",
         "main": "lib/eslint-angular/index.ts",
-        "tsConfig": "lib/eslint-angular/tsconfig.lib.prod.json"
-      },
-      "configurations": {
-        "production": {
-          "optimization": true,
-          "sourceMap": false,
-          "extractLicenses": true
-        }
+        "tsConfig": "lib/eslint-angular/tsconfig.lib.json"
       }
     },
     "lint": {

lib/eslint-angular/src/rules/use-none-component-view-encapsulation/use-none-component-view-encapsulation.ts

@@ -41,7 +41,8 @@ const nodeToReport = (node: TSESTree.Node) => {
     if (!ASTUtils.isProperty(node)) {
         return node;
     }
-    return ASTUtils.isMemberExpression(node.value) ? node.value.property : node.value;
+    const propertyNode = node as TSESTree.Property;
+    return ASTUtils.isMemberExpression(propertyNode.value) ? propertyNode.value.property : propertyNode.value;
 };
 
 /**
@@ -88,9 +89,12 @@ export default createESLintRule<unknown[], MessageIds>({
                                             moduleName: '@angular/core',
                                             node: node.parent
                                         }),
-                                        ASTUtils.isMemberExpression(node.value)
-                                            ? fixer.replaceText(node.value.property, 'None')
-                                            : fixer.replaceText(node.value, viewEncapsulationNone)
+                                        (() => {
+                                            const propValue = (node as TSESTree.Property).value;
+                                            return ASTUtils.isMemberExpression(propValue)
+                                                ? fixer.replaceText(propValue.property, 'None')
+                                                : fixer.replaceText(propValue, viewEncapsulationNone);
+                                        })()
                                     ].filter(isNotNullOrUndefined);
                                 }
 

lib/eslint-angular/tsconfig.lib.json

@@ -1,9 +1,9 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
-    "declarationMap": true
+    "outDir": "./dist",
+    "declaration": true
   },
-  "exclude": ["src/test.ts", "**/*.spec.ts", "**/*.test.ts"],
+  "exclude": ["src/test.ts", "**/*.spec.ts", "**/*.test.ts", "dist"],
   "include": ["**/*.ts"]
 }