inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-09-24 14:31:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update tests to reflect expected external behaviour of the service

Browse Source 
Refs #850
This commit is contained in:
Will Abson
2016-10-10 16:20:55 +01:00
parent a1407d8159
commit 7bb1bfe220
2 changed files with 34 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
ng2-components/ng2-activiti-processlist/src/services/activiti-process.service.spec.ts
View File

@@ -21,11 +21,13 @@ import {
AlfrescoSettingsService, AlfrescoSettingsService,
AlfrescoApiService AlfrescoApiService
} from 'ng2-alfresco-core'; } from 'ng2-alfresco-core';
import { UserProcessInstanceFilterRepresentationModel } from '../models/filter.model';
import { ActivitiProcessService } from './activiti-process.service'; import { ActivitiProcessService } from './activiti-process.service';
describe('ActivitiProcessService', () => { describe('ActivitiProcessService', () => {
let service: ActivitiProcessService; let service: ActivitiProcessService;
let authenticationService: AlfrescoAuthenticationService;
let injector: ReflectiveInjector; let injector: ReflectiveInjector;
let fakeEmptyFilters = { let fakeEmptyFilters = {
@@ -33,6 +35,15 @@ describe('ActivitiProcessService', () => {
data: [ ] data: [ ]
}; };
let fakeApi = {
activiti: {
userFiltersApi: {
getUserProcessInstanceFilters: (filterOpts) => Promise.resolve({}),
createUserProcessInstanceFilter: (filter: UserProcessInstanceFilterRepresentationModel) => Promise.resolve(filter)
}
}
};
beforeEach(() => { beforeEach(() => {
injector = ReflectiveInjector.resolveAndCreate([ injector = ReflectiveInjector.resolveAndCreate([
ActivitiProcessService, ActivitiProcessService,
@@ -41,32 +52,42 @@ describe('ActivitiProcessService', () => {
AlfrescoSettingsService AlfrescoSettingsService
]); ]);
service = injector.get(ActivitiProcessService); service = injector.get(ActivitiProcessService);
authenticationService = injector.get(AlfrescoAuthenticationService);
}); });
it('should get process instances', (done) => { xit('should get process instances', (done) => {
expect(true).toBe(true); expect(true).toBe(true);
done(); done();
}); });
it('should call createDefaultFilters() when the returned filter list is empty', (done) => { it('should return the default filters when none are returned by the API', (done) => {
spyOn(service, 'createDefaultFilters'); spyOn(fakeApi.activiti.userFiltersApi, 'getUserProcessInstanceFilters').
spyOn(service, 'callApiGetUserProcessInstanceFilters').and.returnValue(Promise.resolve(fakeEmptyFilters)); and.returnValue(Promise.resolve(fakeEmptyFilters));
spyOn(service, 'callApiAddFilter').and.returnValue(Promise.resolve({})); spyOn(fakeApi.activiti.userFiltersApi, 'createUserProcessInstanceFilter').
and.returnValue(Promise.resolve({}));
spyOn(authenticationService, 'getAlfrescoApi').and.returnValue(fakeApi);
service.getProcessFilters(null).subscribe( service.getProcessFilters(null).subscribe(
(res) => { (res) => {
expect(service.createDefaultFilters).toHaveBeenCalled(); expect(fakeApi.activiti.userFiltersApi.createUserProcessInstanceFilter).toHaveBeenCalledTimes(3);
done(); done();
} }
); );
}); });
it('should return the default filters', () => { it('should create the default filters when none are returned by the API', (done) => {
spyOn(service, 'addFilter').and.returnValue(Promise.resolve({})); spyOn(fakeApi.activiti.userFiltersApi, 'getUserProcessInstanceFilters').
let filters = service.createDefaultFilters(null); and.returnValue(Promise.resolve(fakeEmptyFilters));
expect(service.addFilter).toHaveBeenCalledTimes(3); spyOn(fakeApi.activiti.userFiltersApi, 'createUserProcessInstanceFilter').
expect(filters).toBeDefined(); and.returnValue(Promise.resolve({}));
expect(filters.length).toEqual(3); spyOn(authenticationService, 'getAlfrescoApi').and.returnValue(fakeApi);
service.getProcessFilters(null).subscribe(
(res) => {
expect(res.length).toBe(3);
done();
}
);
}); });
}); });

2
ng2-components/ng2-activiti-processlist/src/services/activiti-process.service.ts
View File

@@ -79,7 +79,7 @@ export class ActivitiProcessService {
* @param appId * @param appId
* @returns {UserProcessInstanceFilterRepresentationModel[]} * @returns {UserProcessInstanceFilterRepresentationModel[]}
*/ */
createDefaultFilters(appId: string): UserProcessInstanceFilterRepresentationModel[] { private createDefaultFilters(appId: string): UserProcessInstanceFilterRepresentationModel[] {
let filters: UserProcessInstanceFilterRepresentationModel[] = []; let filters: UserProcessInstanceFilterRepresentationModel[] = [];
let involvedTasksFilter = this.getRunningFilterInstance(appId); let involvedTasksFilter = this.getRunningFilterInstance(appId);