From 7bb3c00a750f77593dce5fe5c95fa429c8f732fb Mon Sep 17 00:00:00 2001 From: arditdomi <32884230+arditdomi@users.noreply.github.com> Date: Fri, 5 Apr 2019 10:38:56 +0100 Subject: [PATCH] [ADF-4270] Fix empty name cell in process header cloud (#4557) --- lib/process-services-cloud/src/lib/i18n/en.json | 1 + .../process-header-cloud.component.spec.ts | 14 +++++++++++++- .../components/process-header-cloud.component.ts | 3 ++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/lib/process-services-cloud/src/lib/i18n/en.json b/lib/process-services-cloud/src/lib/i18n/en.json index 5dd174f465..fe7dd527a6 100644 --- a/lib/process-services-cloud/src/lib/i18n/en.json +++ b/lib/process-services-cloud/src/lib/i18n/en.json @@ -209,6 +209,7 @@ "PROPERTIES": { "ID": "ID", "NAME": "Name", + "NAME_DEFAULT": "No name", "DESCRIPTION": "Description", "DESCRIPTION_DEFAULT": "No description", "STATUS": "Status", diff --git a/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.spec.ts b/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.spec.ts index 92a3f36bbb..6be0590d5a 100644 --- a/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.spec.ts +++ b/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.spec.ts @@ -101,7 +101,19 @@ describe('ProcessHeaderCloudComponent', () => { }); })); - it('should display placeholder if no description is avilable', async(() => { + it('should display placeholder if no name is available', async(() => { + processInstanceDetailsCloudMock.name = null; + component.ngOnChanges(); + fixture.detectChanges(); + + fixture.whenStable().then(() => { + const valueEl = fixture.debugElement.query(By.css('[data-automation-id="card-textitem-value-name"] span')); + expect(valueEl.nativeElement.innerText).toBe('ADF_CLOUD_PROCESS_HEADER.PROPERTIES.NAME_DEFAULT'); + }); + + })); + + it('should display placeholder if no description is available', async(() => { processInstanceDetailsCloudMock.description = null; component.ngOnChanges(); fixture.detectChanges(); diff --git a/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.ts b/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.ts index ed47b083a2..e0d61d4904 100644 --- a/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.ts +++ b/lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.ts @@ -83,7 +83,8 @@ export class ProcessHeaderCloudComponent implements OnChanges { { label: 'ADF_CLOUD_PROCESS_HEADER.PROPERTIES.NAME', value: this.processInstanceDetails.name, - key: 'name' + key: 'name', + default: this.translationService.instant('ADF_CLOUD_PROCESS_HEADER.PROPERTIES.NAME_DEFAULT') }), new CardViewTextItemModel( {