diff --git a/ng2-components/ng2-activiti-form/index.ts b/ng2-components/ng2-activiti-form/index.ts index c8951d48cb..9c8ecde6b8 100644 --- a/ng2-components/ng2-activiti-form/index.ts +++ b/ng2-components/ng2-activiti-form/index.ts @@ -32,7 +32,6 @@ import { WIDGET_DIRECTIVES } from './src/components/widgets/index'; export * from './src/components/activiti-form.component'; export * from './src/components/activiti-start-form.component'; -export * from './src/components/widgets/textfield-widget.component'; export * from './src/services/form.service'; export * from './src/components/widgets/index'; export * from './src/services/ecm-model.service'; diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.html index 773504db8f..a192ea2359 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.html @@ -1,5 +1,6 @@ -
+ - + [disabled]="field.readOnly" + placeholder="{{field.placeholder}}"> {{field.validationSummary}}
diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.spec.ts b/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.spec.ts index 75eda10f8e..4b14eea026 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.spec.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.spec.ts @@ -23,7 +23,7 @@ describe('AmountWidget', () => { let widget: AmountWidget; beforeEach(() => { - widget = new AmountWidget(null); + widget = new AmountWidget(); }); it('should setup currentcy from field', () => { diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.ts b/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.ts index 93086e9006..5efd7c2bb3 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/amount/amount.widget.ts @@ -15,8 +15,8 @@ * limitations under the License. */ -import { Component, ElementRef, OnInit } from '@angular/core'; -import { TextFieldWidgetComponent } from './../textfield-widget.component'; +import { Component, OnInit } from '@angular/core'; +import { WidgetComponent } from './../widget.component'; @Component({ moduleId: module.id, @@ -24,16 +24,12 @@ import { TextFieldWidgetComponent } from './../textfield-widget.component'; templateUrl: './amount.widget.html', styleUrls: ['./amount.widget.css'] }) -export class AmountWidget extends TextFieldWidgetComponent implements OnInit { +export class AmountWidget extends WidgetComponent implements OnInit { static DEFAULT_CURRENCY: string = '$'; currency: string = AmountWidget.DEFAULT_CURRENCY; - constructor(elementRef: ElementRef) { - super(elementRef); - } - ngOnInit() { if (this.field && this.field.currency) { this.currency = this.field.currency; diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/core/form-field.model.ts b/ng2-components/ng2-activiti-form/src/components/widgets/core/form-field.model.ts index 693f865867..e7cae1bd55 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/core/form-field.model.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/core/form-field.model.ts @@ -54,6 +54,7 @@ export class FormFieldModel extends FormWidgetModel { overrideId: boolean; tab: string; colspan: number = 1; + placeholder: string = null; minLength: number = 0; maxLength: number = 0; minValue: string; @@ -157,6 +158,10 @@ export class FormFieldModel extends FormWidgetModel { this.currency = json.currency; this._value = this.parseValue(json); + if (json.placeholder && json.placeholder !== '' && json.placeholder !== 'null') { + this.placeholder = json.placeholder; + } + // this.numberOfColumns = json.numberOfColumns; diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.html index cd2c2cb8b5..3a8652288a 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.html @@ -1,7 +1,8 @@
-
+ - + [disabled]="field.readOnly" + placeholder="{{field.placeholder}}"> {{field.validationSummary}}
diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.ts b/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.ts index 297f0b5fc3..f6dba5b941 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/date/date.widget.ts @@ -16,7 +16,7 @@ */ import { Component, ElementRef, OnInit, AfterViewChecked } from '@angular/core'; -import { TextFieldWidgetComponent } from './../textfield-widget.component'; +import { WidgetComponent } from './../widget.component'; @Component({ moduleId: module.id, @@ -24,14 +24,14 @@ import { TextFieldWidgetComponent } from './../textfield-widget.component'; templateUrl: './date.widget.html', styleUrls: ['./date.widget.css'] }) -export class DateWidget extends TextFieldWidgetComponent implements OnInit, AfterViewChecked { +export class DateWidget extends WidgetComponent implements OnInit, AfterViewChecked { DATE_FORMAT: string = 'D-M-YYYY'; datePicker: any; - constructor(elementRef: ElementRef) { - super(elementRef); + constructor(private elementRef: ElementRef) { + super(); } ngOnInit() { diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/functional-group/functional-group.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/functional-group/functional-group.widget.html index 90090bfe4f..b52c1eee0e 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/functional-group/functional-group.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/functional-group/functional-group.widget.html @@ -1,5 +1,6 @@ -
+ - + [disabled]="field.readOnly" + placeholder="{{field.placeholder}}"> {{field.validationSummary}}
diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.html index 30768fa88f..377581e484 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.html @@ -1,5 +1,6 @@ -
+ - {{field.validationSummary}}
diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.spec.ts b/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.spec.ts index 54f18a3db2..e0d0b983d4 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.spec.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.spec.ts @@ -22,7 +22,7 @@ describe('MultilineTextWidget', () => { let widget: MultilineTextWidget; beforeEach(() => { - widget = new MultilineTextWidget(null); + widget = new MultilineTextWidget(); }); it('should exist', () => { diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.ts b/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.ts index 3a36db6320..20ebeae749 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/multiline-text/multiline-text.widget.ts @@ -15,8 +15,8 @@ * limitations under the License. */ -import { Component, ElementRef } from '@angular/core'; -import { TextFieldWidgetComponent } from './../textfield-widget.component'; +import { Component } from '@angular/core'; +import { WidgetComponent } from './../widget.component'; @Component({ moduleId: module.id, @@ -24,10 +24,5 @@ import { TextFieldWidgetComponent } from './../textfield-widget.component'; templateUrl: './multiline-text.widget.html', styleUrls: ['./multiline-text.widget.css'] }) -export class MultilineTextWidget extends TextFieldWidgetComponent { - - constructor(elementRef: ElementRef) { - super(elementRef); - } - +export class MultilineTextWidget extends WidgetComponent { } diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.html index 3b0736f377..ffe0f265b4 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.html @@ -1,5 +1,6 @@ -
+ - + [disabled]="field.readOnly" + placeholder="{{field.placeholder}}"> {{field.validationSummary}}
diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.spec.ts b/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.spec.ts index c43e209c61..e2c229c4cc 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.spec.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.spec.ts @@ -22,7 +22,7 @@ describe('NumberWidget', () => { let widget: NumberWidget; beforeEach(() => { - widget = new NumberWidget(null); + widget = new NumberWidget(); }); it('should exist', () => { diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.ts b/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.ts index f3a04d58a4..adea9826f5 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/number/number.widget.ts @@ -15,8 +15,8 @@ * limitations under the License. */ -import { Component, ElementRef } from '@angular/core'; -import { TextFieldWidgetComponent } from './../textfield-widget.component'; +import { Component } from '@angular/core'; +import { WidgetComponent } from './../widget.component'; @Component({ moduleId: module.id, @@ -24,10 +24,5 @@ import { TextFieldWidgetComponent } from './../textfield-widget.component'; templateUrl: './number.widget.html', styleUrls: ['./number.widget.css'] }) -export class NumberWidget extends TextFieldWidgetComponent { - - constructor(elementRef: ElementRef) { - super(elementRef); - } - +export class NumberWidget extends WidgetComponent { } diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/people/people.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/people/people.widget.html index a3896ab26e..6e30337b1e 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/people/people.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/people/people.widget.html @@ -1,5 +1,6 @@ -
+ - + [disabled]="field.readOnly" + placeholder="{{field.placeholder}}"> {{field.validationSummary}}
diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.html index b89c0851ae..ac2507c5d2 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.html @@ -1,12 +1,13 @@ -
+ - + [disabled]="field.readOnly" + placeholder="{{field.placeholder}}"> {{field.validationSummary}}
diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.spec.ts b/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.spec.ts index 14548449fe..5edea9002c 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.spec.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.spec.ts @@ -15,20 +15,15 @@ * limitations under the License. */ -import { ElementRef } from '@angular/core'; import { TextWidget } from './text.widget'; -import { FormFieldModel } from './../core/form-field.model'; -import { FormFieldTypes } from '../core/form-field-types'; describe('TextWidget', () => { let widget: TextWidget; - let elementRef: ElementRef; let componentHandler; beforeEach(() => { - elementRef = new ElementRef(null); - widget = new TextWidget(elementRef); + widget = new TextWidget(); componentHandler = jasmine.createSpyObj('componentHandler', [ 'upgradeAllRegistered' @@ -37,32 +32,4 @@ describe('TextWidget', () => { window['componentHandler'] = componentHandler; }); - it('should upgrade material textfield', () => { - spyOn(widget, 'setupMaterialTextField').and.stub(); - - widget.field = new FormFieldModel(null, { - type: FormFieldTypes.TEXT, - value: '' - }); - widget.ngAfterViewInit(); - expect(widget.setupMaterialTextField).toHaveBeenCalled(); - }); - - it('should require mdl component handler to setup textfield', () => { - expect(widget.setupMaterialComponents(null)).toBeFalsy(); - }); - - it('should require element reference to setup textfield', () => { - widget = new TextWidget(null); - expect(widget.setupMaterialComponents(componentHandler)).toBeFalsy(); - }); - - it('should require field value to setup textfield', () => { - widget.field = new FormFieldModel(null, { - type: FormFieldTypes.TEXT, - value: null - }); - expect(widget.setupMaterialComponents(componentHandler)).toBeFalsy(); - }); - }); diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.ts b/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.ts index e8498ab545..43370f32ba 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.ts +++ b/ng2-components/ng2-activiti-form/src/components/widgets/text/text.widget.ts @@ -15,8 +15,8 @@ * limitations under the License. */ -import { Component, ElementRef } from '@angular/core'; -import { TextFieldWidgetComponent } from './../textfield-widget.component'; +import { Component } from '@angular/core'; +import { WidgetComponent } from './../widget.component'; @Component({ moduleId: module.id, @@ -24,10 +24,5 @@ import { TextFieldWidgetComponent } from './../textfield-widget.component'; templateUrl: './text.widget.html', styleUrls: ['./text.widget.css'] }) -export class TextWidget extends TextFieldWidgetComponent { - - constructor(elementRef: ElementRef) { - super(elementRef); - } - +export class TextWidget extends WidgetComponent { } diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/textfield-widget.component.ts b/ng2-components/ng2-activiti-form/src/components/widgets/textfield-widget.component.ts deleted file mode 100644 index 5037574e62..0000000000 --- a/ng2-components/ng2-activiti-form/src/components/widgets/textfield-widget.component.ts +++ /dev/null @@ -1,41 +0,0 @@ -/*! - * @license - * Copyright 2016 Alfresco Software, Ltd. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -import { ElementRef } from '@angular/core'; -import { WidgetComponent } from './widget.component'; - -export abstract class TextFieldWidgetComponent extends WidgetComponent { - - protected elementRef: ElementRef; - - constructor(elementRef: ElementRef) { - super(); - this.elementRef = elementRef; - } - - setupMaterialComponents(handler: any): boolean { - super.setupMaterialComponents(handler); - // workaround for MDL issues with dynamic components - if (handler) { - if (this.elementRef && this.hasValue()) { - return this.setupMaterialTextField(this.elementRef, handler, this.field.value.toString()); - } - } - return false; - } - -} diff --git a/ng2-components/ng2-activiti-form/src/components/widgets/typeahead/typeahead.widget.html b/ng2-components/ng2-activiti-form/src/components/widgets/typeahead/typeahead.widget.html index 061f310e68..e0b89d3472 100644 --- a/ng2-components/ng2-activiti-form/src/components/widgets/typeahead/typeahead.widget.html +++ b/ng2-components/ng2-activiti-form/src/components/widgets/typeahead/typeahead.widget.html @@ -1,14 +1,15 @@ -
+ - + [disabled]="field.readOnly" + placeholder="{{field.placeholder}}"> {{field.validationSummary}}