[no-issue] refactor failing e2e (#3865)

* fix ps test

* fix import

* fix import

* fix ps

* fix hyperlink

* fix radio hiperlynk

* autorename for clashes

* notification fix

* convert userdialog to ts

* fix travis configuration

* fix download in folder

* convert contentservice page to ts

* convert setting and login to ts

* remove unused import

* fix login import

* fix login page

* fix chips

* fix import
speed up viewer test

* fix contentlist

* change id

* fix cs e2e

* fix search lint

* fix name issue

e2e/content-services/comments/comment_component.e2e.ts

@@ -15,8 +15,8 @@
  * limitations under the License.
  */
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import { ViewerPage } from '../../pages/adf/viewerPage';
 import { CommentsPage } from '../../pages/adf/commentsPage';
 

e2e/content-services/directives/create_folder_directive.e2e.ts

@@ -15,10 +15,10 @@
  * limitations under the License.
  */
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import CreateFolderDialog = require('../../pages/adf/dialog/createFolderDialog');
-import NotificationPage = require('../../pages/adf/notificationPage');
+import { NotificationPage } from '../../pages/adf/notificationPage';
 import MetadataViewPage = require('../../pages/adf/metadataViewPage');
 import ContentListPage = require('../../pages/adf/dialog/contentList');
 

e2e/content-services/document-list/document_list_actions.e2e.ts

@@ -16,8 +16,8 @@
  */
 
 import { browser } from 'protractor';
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import ContentListPage = require('../../pages/adf/dialog/contentList');
 import AcsUserModel = require('../../models/ACS/acsUserModel');
 import TestConfig = require('../../test.config');

e2e/content-services/document-list/document_list_component.e2e.ts

@@ -16,8 +16,8 @@
  */
 
 import { browser } from 'protractor';
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import NavigationBarPage = require('../../pages/adf/navigationBarPage');
 import AcsUserModel = require('../../models/ACS/acsUserModel');
 import TestConfig = require('../../test.config');

e2e/content-services/document-list/document_list_pagination.e2e.ts

@@ -15,8 +15,8 @@
  * limitations under the License.
  */
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import PaginationPage = require('../../pages/adf/paginationPage');
 import NavigationBarPage = require('../../pages/adf/navigationBarPage');
 

e2e/content-services/notifications_component.e2e.ts

@@ -15,11 +15,11 @@
  * limitations under the License.
  */
 
-import LoginPage = require('../pages/adf/loginPage');
+import { LoginPage } from '../pages/adf/loginPage';
 import AcsUserModel = require('../models/ACS/acsUserModel');
 import TestConfig = require('../test.config');
 import AlfrescoApi = require('alfresco-js-api-node');
-import NotificationPage = require('../pages/adf/notificationPage');
+import { NotificationPage } from '../pages/adf/notificationPage';
 import { browser } from 'protractor';
 
 describe('Notifications Component', () => {
@@ -46,26 +46,35 @@ describe('Notifications Component', () => {
 
         notificationPage.goToNotificationsPage();
 
+        notificationPage.enterDurationField(6000);
+
+        done();
+    });
+
+    afterEach(async (done) => {
+        notificationPage.enterDurationField(1);
+        notificationPage.clickNotificationButton();
+        browser.sleep(100);
+        notificationPage.enterDurationField(6000);
         done();
     });
 
     it('[C279977] Should show notification when the message is not empty and button is clicked', () => {
         notificationPage.enterMessageField('Notification test');
-        notificationPage.clickDefaultNotificationButton();
+        notificationPage.clickNotificationButton();
         notificationPage.checkNotificationSnackBarIsDisplayedWithMessage('Notification test');
     });
 
     it('[C279979] Should not show notification when the message is empty and button is clicked', () => {
         notificationPage.clearMessage();
-        notificationPage.clickDefaultNotificationButton();
+        notificationPage.clickNotificationButton();
         notificationPage.checkNotificationSnackBarIsNotDisplayed();
     });
 
     it('[C279978] Should show notification with action when the message is not empty and button is clicked', () => {
         notificationPage.enterMessageField('Notification test');
         notificationPage.clickActionToggle();
-        notificationPage.enterDurationField(6000);
-        notificationPage.clickCustomNotificationButton();
+        notificationPage.clickNotificationButton();
         notificationPage.checkNotificationSnackBarIsDisplayedWithMessage('Notification test');
         notificationPage.clickActionButton();
         notificationPage.checkActionEvent();
@@ -74,14 +83,14 @@ describe('Notifications Component', () => {
 
     it('[C279981] Should show notification with action when the message is not empty and custom configuration button is clicked', () => {
         notificationPage.enterMessageField('Notification test');
-        notificationPage.clickCustomNotificationButton();
+        notificationPage.clickNotificationButton();
         notificationPage.checkNotificationSnackBarIsDisplayed();
     });
 
     it('[C279987] Should show custom notification during a limited time when a duration is added', () => {
         notificationPage.enterMessageField('Notification test');
         notificationPage.enterDurationField(1000);
-        notificationPage.clickCustomNotificationButton();
+        notificationPage.clickNotificationButton();
         notificationPage.checkNotificationSnackBarIsDisplayed();
         browser.sleep(1500);
         notificationPage.checkNotificationSnackBarIsNotDisplayed();
@@ -90,7 +99,7 @@ describe('Notifications Component', () => {
     it('[C280000] Should show notification with action when the message is not empty and custom button is clicked', () => {
         notificationPage.enterMessageField('Notification test');
         notificationPage.clickActionToggle();
-        notificationPage.clickCustomNotificationButton();
+        notificationPage.clickNotificationButton();
         notificationPage.checkNotificationSnackBarIsDisplayedWithMessage('Notification test');
         notificationPage.clickActionButton();
         notificationPage.checkActionEvent();
@@ -103,7 +112,7 @@ describe('Notifications Component', () => {
         notificationPage.selectHorizontalPosition('Right');
         notificationPage.selectVerticalPosition('Top');
         notificationPage.selectDirection('Left to right');
-        notificationPage.clickCustomNotificationButton();
+        notificationPage.clickNotificationButton();
         expect(notificationPage.getConfigObject()).toBe('{"direction": "ltr", "duration": "1000", "horizontalPosition": "right", "verticalPosition": "top"}');
     });
 });

e2e/content-services/permissions_component.e2e.ts

@@ -16,8 +16,8 @@
  */
 
 import { PermissionsPage } from '../pages/adf/permissionsPage';
-import LoginPage = require('../pages/adf/loginPage');
-import ContentServicesPage = require('../pages/adf/contentServicesPage');
+import { LoginPage } from '../pages/adf/loginPage';
+import { ContentServicesPage } from '../pages/adf/contentServicesPage';
 import AcsUserModel = require('../models/ACS/acsUserModel');
 import TestConfig = require('../test.config');
 import resources = require('../util/resources');
@@ -25,7 +25,7 @@ import ContentListPage = require('../pages/adf/dialog/contentList');
 import AlfrescoApi = require('alfresco-js-api-node');
 import FileModel = require('../models/ACS/fileModel');
 import { UploadActions } from '../actions/ACS/upload.actions';
-import Util = require('../util/util.js');
+import Util = require('../util/util');
 import { browser } from 'protractor';
 
 describe('Permissions Component', function () {

e2e/content-services/search/search_component.e2e.ts

@@ -17,9 +17,9 @@
 
 import { browser } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
+import { LoginPage } from '../../pages/adf/loginPage';
 import SearchDialog = require('../../pages/adf/dialog/searchDialog');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import filePreviewPage = require('../../pages/adf/filePreviewPage');
 import SearchResultPage = require('../../pages/adf/searchResultsPage');
 
@@ -55,6 +55,7 @@ describe('Search component - Search Bar', () => {
     let firstFolderName = Util.generateRandomString(16);
     let secondFolderName = Util.generateRandomString(16);
     let thirdFolderName = Util.generateRandomString(16);
+    let filesToDelete = [];
 
     let firstFileModel = new FileModel({
         'name': filename, 'shortName': filename.substring(0, 8)
@@ -87,11 +88,11 @@ describe('Search component - Search Bar', () => {
         let firstFileUploaded = await uploadActions.uploadFile(this.alfrescoJsApi, firstFileModel.location, firstFileModel.name, '-my-');
         Object.assign(firstFileModel, firstFileUploaded.entry);
 
-        await uploadActions.uploadFolder(this.alfrescoJsApi, firstFolderModel.name, '-my-');
-        await uploadActions.uploadFolder(this.alfrescoJsApi, secondFolder.name, '-my-');
-        await uploadActions.uploadFolder(this.alfrescoJsApi, thirdFolder.name, '-my-');
+        filesToDelete.push(await uploadActions.uploadFolder(this.alfrescoJsApi, firstFolderModel.name, '-my-'));
+        filesToDelete.push(await uploadActions.uploadFolder(this.alfrescoJsApi, secondFolder.name, '-my-'));
+        filesToDelete.push(await uploadActions.uploadFolder(this.alfrescoJsApi, thirdFolder.name, '-my-'));
 
-        await browser.driver.sleep(5000); // wait search index previous file/folder uploaded
+        await browser.driver.sleep(15000); // wait search index previous file/folder uploaded
 
         loginPage.loginToContentServicesUsingUserModel(acsUser);
 
@@ -100,13 +101,16 @@ describe('Search component - Search Bar', () => {
         done();
     });
 
-    // afterAll((done) => {
-    //     NodesAPI.deleteContent(acsUser, firstFileModel.id, () => {
-    //         NodesAPI.deleteContent(acsUser, firstFolderModel.id, () => {
-    //             done();
-    //         });
-    //     });
-    // });
+    afterAll(async (done) => {
+        let uploadActions = new UploadActions();
+
+        filesToDelete.forEach(async (currentNode) => {
+            await uploadActions.deleteFilesOrFolder(this.alfrescoJsApi, currentNode.entry.id);
+
+        });
+
+        done();
+    });
 
     it('[C272798] Search bar is visible', () => {
         searchDialog.checkSearchBarIsNotVisible().checkSearchIconIsVisible();

e2e/content-services/search/search_filters.e2e.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import LoginPage = require('../../pages/adf/loginPage');
+import { LoginPage } from '../../pages/adf/loginPage';
 import SearchDialog = require('../../pages/adf/dialog/searchDialog');
 import SearchFiltersPage = require('../../pages/adf/searchFiltersPage');
 

e2e/content-services/search/search_multiselect.e2e.ts

@@ -24,7 +24,7 @@ import CONSTANTS = require('../../util/constants');
 import { UploadActions } from '../../actions/ACS/upload.actions';
 import { browser } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
+import { LoginPage } from '../../pages/adf/loginPage';
 import SearchDialog = require('../../pages/adf/dialog/searchDialog');
 import SearchResultPage = require('../../pages/adf/searchResultsPage');
 import SearchFiltersPage = require('../../pages/adf/searchFiltersPage');
@@ -80,7 +80,7 @@ describe('Search Component - Multi-Select Facet', () => {
 
             txtFileSite = await uploadActions.uploadFile(this.alfrescoJsApi, txtFileInfo.location, txtFileInfo.name, site.entry.guid);
 
-            await browser.driver.sleep(20000);
+            await browser.driver.sleep(30000);
 
             loginPage.loginToContentServicesUsingUserModel(acsUser);
 
@@ -162,7 +162,7 @@ describe('Search Component - Multi-Select Facet', () => {
 
             jpgFile = await uploadActions.uploadFile(this.alfrescoJsApi, jpgFileInfo.location, jpgFileInfo.name, site.entry.guid);
 
-            await browser.driver.sleep(20000);
+            await browser.driver.sleep(30000);
 
             loginPage.loginToContentServicesUsingUserModel(userUploadingImg);
 
@@ -226,7 +226,7 @@ describe('Search Component - Multi-Select Facet', () => {
             });
 
             txtFile = await uploadActions.uploadFile(this.alfrescoJsApi, txtFileInfo.location, txtFileInfo.name, '-my-');
-            await browser.driver.sleep(20000);
+            await browser.driver.sleep(30000);
 
             loginPage.loginToContentServicesUsingUserModel(acsUser);
 

e2e/content-services/search/search_page_component.e2e.ts

@@ -17,9 +17,10 @@
 
 import { browser } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+
 import SearchDialog = require('../../pages/adf/dialog/searchDialog');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import SearchResultPage = require('../../pages/adf/searchResultsPage');
 import filePreviewPage = require('../../pages/adf/filePreviewPage');
 

e2e/content-services/tag_component.e2e.ts

@@ -18,9 +18,9 @@
 import AcsUserModel = require('../models/ACS/acsUserModel');
 import FileModel = require('../models/ACS/fileModel');
 
-import LoginPage = require('../pages/adf/loginPage');
-import TagPage = require('../pages/adf/tagPage');
-import AppNavigationBarPage = require('../pages/adf/process_services/appNavigationBarPage');
+import { LoginPage } from '../pages/adf/loginPage';
+import { TagPage } from '../pages/adf/tagPage';
+import { AppNavigationBarPage } from '../pages/adf/process_services/appNavigationBarPage';
 
 import TestConfig = require('../test.config');
 import resources = require('../util/resources');
@@ -199,7 +199,7 @@ describe('Tag component', () => {
         tagPage.checkDeleteTagFromTagListByNodeIdIsNotDisplayed(tagList[3]);
     });
 
-    it('[C286472] Should be able to click Show more/less button on "List Tags Content Services"', () => {
+    it('[C286472] Should be able to click Show more/less button on List Tags Content Services', () => {
         tagPage.insertNodeId(pdfFileModel.id);
 
         tagPage.checkShowMoreButtonIsDisplayed();

e2e/content-services/trashcan_pagination.e2e.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import LoginPage = require('../pages/adf/loginPage');
+import { LoginPage } from '../pages/adf/loginPage';
 import { TrashcanPage } from '../pages/adf/trashcanPage';
 
 import PaginationPage = require('../pages/adf/paginationPage');

e2e/content-services/unshare_file.e2e.ts

@@ -15,8 +15,8 @@
  * limitations under the License.
  */
 
-import LoginPage = require('../pages/adf/loginPage');
-import ContentServicesPage = require('../pages/adf/contentServicesPage');
+import { LoginPage } from '../pages/adf/loginPage';
+import { ContentServicesPage } from '../pages/adf/contentServicesPage';
 import ContentListPage = require('../pages/adf/dialog/contentList');
 import ErrorPage = require('../pages/adf/errorPage');
 import { ShareDialog } from '../pages/adf/dialog/shareDialog';

e2e/content-services/upload/excluded_file.e2e.ts

@@ -17,8 +17,8 @@
 
 import { element, by, browser } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import UploadDialog = require('../../pages/adf/dialog/uploadDialog');
 import { UploadToggles } from '../../pages/adf/dialog/uploadToggles';
 import NavigationBarPage = require('../../pages/adf/navigationBarPage');

e2e/content-services/upload/uploader_component.e2e.ts

@@ -18,8 +18,8 @@
 /* tslint:disable */
 import { element, by, browser } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import UploadDialog = require('../../pages/adf/dialog/uploadDialog');
 import { UploadToggles } from '../../pages/adf/dialog/uploadToggles';
 

e2e/content-services/upload/user_permission.e2e.ts

@@ -19,12 +19,12 @@ import { element, by } from 'protractor';
 
 import Util = require('../../util/util');
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import UploadDialog = require('../../pages/adf/dialog/uploadDialog');
 import { UploadToggles } from '../../pages/adf/dialog/uploadToggles';
 import NavigationBarPage = require('../../pages/adf/navigationBarPage');
-import NotificationPage = require('../../pages/adf/notificationPage');
+import { NotificationPage } from '../../pages/adf/notificationPage';
 
 import AcsUserModel = require('../../models/ACS/acsUserModel');
 import FileModel = require('../../models/ACS/fileModel');

e2e/content-services/version/version-actions.e2e.ts

@@ -17,8 +17,8 @@
 
 import { by, element } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import ContentListPage = require('../../pages/adf/dialog/contentList');
 import { VersionManagePage } from '../../pages/adf/versionManagerPage';
 

e2e/content-services/version/version-permissions.e2e.ts

@@ -17,12 +17,12 @@
 
 import { element, by } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
+import { LoginPage } from '../../pages/adf/loginPage';
 import ContentListPage = require('../../pages/adf/dialog/contentList');
 import NavigationBarPage = require('../../pages/adf/navigationBarPage');
 import { VersionManagePage } from '../../pages/adf/versionManagerPage';
 import UploadDialog = require('../../pages/adf/dialog/uploadDialog');
-import NotificationPage = require('../../pages/adf/notificationPage');
+import { NotificationPage } from '../../pages/adf/notificationPage';
 
 import AcsUserModel = require('../../models/ACS/acsUserModel');
 import FileModel = require('../../models/ACS/fileModel');

e2e/content-services/version/version-properties.e2e.ts

@@ -17,8 +17,8 @@
 
 import { by, element } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import ContentListPage = require('../../pages/adf/dialog/contentList');
 import { VersionManagePage } from '../../pages/adf/versionManagerPage';
 

e2e/content-services/version/version-smoke-tests.e2e.ts

@@ -17,8 +17,8 @@
 
 import { browser } from 'protractor';
 
-import LoginPage = require('../../pages/adf/loginPage');
-import ContentServicesPage = require('../../pages/adf/contentServicesPage');
+import { LoginPage } from '../../pages/adf/loginPage';
+import { ContentServicesPage } from '../../pages/adf/contentServicesPage';
 import ContentListPage = require('../../pages/adf/dialog/contentList');
 import { VersionManagePage } from '../../pages/adf/versionManagerPage';