Disable control flow e2e ADF (#4954)

* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test

e2e/core/error-component.e2e.ts

@@ -28,7 +28,7 @@ describe('Error Component', () => {
     const errorPage = new ErrorPage();
     const navigationBarPage = new NavigationBarPage();
 
-    beforeAll(async (done) => {
+    beforeAll(async () => {
         this.alfrescoJsApi = new AlfrescoApi({
             provider: 'ECM',
             hostEcm: browser.params.testConfig.adf_acs.host
@@ -38,49 +38,47 @@ describe('Error Component', () => {
         await this.alfrescoJsApi.core.peopleApi.addPerson(acsUser);
         await loginPage.loginToContentServicesUsingUserModel(acsUser);
 
-        done();
-
     });
 
     afterAll(async () => {
         await navigationBarPage.clickLogoutButton();
     });
 
-    it('[C277302] Should display the error 403 when access to unauthorized page - My Change', () => {
-        BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/403');
-        expect(errorPage.getErrorCode()).toBe('403');
-        expect(errorPage.getErrorTitle()).toBe('You don\'t have permission to access this server.');
-        expect(errorPage.getErrorDescription()).toBe('You\'re not allowed access to this resource on the server.');
+    it('[C277302] Should display the error 403 when access to unauthorized page - My Change', async () => {
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/403');
+        await expect(await errorPage.getErrorCode()).toBe('403');
+        await expect(await errorPage.getErrorTitle()).toBe('You don\'t have permission to access this server.');
+        await expect(await errorPage.getErrorDescription()).toBe('You\'re not allowed access to this resource on the server.');
     });
 
-    it('[C280563] Should back home button navigate to the home page', () => {
-        BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/404');
+    it('[C280563] Should back home button navigate to the home page', async () => {
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/404');
 
-        errorPage.clickBackButton();
+        await errorPage.clickBackButton();
 
-        expect(browser.getCurrentUrl()).toBe(browser.params.testConfig.adf.url + '/');
+        await expect(await browser.getCurrentUrl()).toBe(browser.params.testConfig.adf.url + '/');
     });
 
-    it('[C280564] Should secondary button by default redirect to report-issue URL', () => {
-        BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/403');
+    it('[C280564] Should secondary button by default redirect to report-issue URL', async () => {
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/403');
 
-        errorPage.clickSecondButton();
+        await errorPage.clickSecondButton();
 
-        expect(browser.getCurrentUrl()).toBe(browser.params.testConfig.adf.url + '/report-issue');
+        await expect(await browser.getCurrentUrl()).toBe(browser.params.testConfig.adf.url + '/report-issue');
     });
 
-    it('[C277304] Should display the error 404 when access to not found page', () => {
-        BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/404');
-        expect(errorPage.getErrorCode()).toBe('404');
-        expect(errorPage.getErrorTitle()).toBe('An error occurred.');
-        expect(errorPage.getErrorDescription()).toBe('We couldn’t find the page you were looking for.');
+    it('[C277304] Should display the error 404 when access to not found page', async () => {
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/404');
+        await expect(await errorPage.getErrorCode()).toBe('404');
+        await expect(await errorPage.getErrorTitle()).toBe('An error occurred.');
+        await expect(await errorPage.getErrorDescription()).toBe('We couldn’t find the page you were looking for.');
     });
 
-    it('[C307029] Should display Unknown message when error is undefined', () => {
-        BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/501');
-        expect(errorPage.getErrorCode()).toBe('UNKNOWN');
-        expect(errorPage.getErrorTitle()).toBe('We hit a problem.');
-        expect(errorPage.getErrorDescription()).toBe('Looks like something went wrong.');
+    it('[C307029] Should display Unknown message when error is undefined', async () => {
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url + '/error/501');
+        await expect(await errorPage.getErrorCode()).toBe('UNKNOWN');
+        await expect(await errorPage.getErrorTitle()).toBe('We hit a problem.');
+        await expect(await errorPage.getErrorDescription()).toBe('Looks like something went wrong.');
     });
 
 });