Disable control flow e2e ADF (#4954)

* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test

e2e/core/viewer/file-extensions/viewer-component.e2e.ts

@@ -53,7 +53,7 @@ describe('Viewer', () => {
         'location': resources.Files.ADF_DOCUMENTS.OTHER_FOLDER.folder_location
     });
 
-    beforeAll(async (done) => {
+    beforeAll(async () => {
         await this.alfrescoJsApi.login(browser.params.testConfig.adf.adminEmail, browser.params.testConfig.adf.adminPassword);
         await this.alfrescoJsApi.core.peopleApi.addPerson(acsUser);
 
@@ -70,7 +70,7 @@ describe('Viewer', () => {
         await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
 
         pngFileUploaded = await uploadActions.uploadFile(pngFileInfo.location, pngFileInfo.name, site.entry.guid);
-        done();
+
     });
 
     afterAll(async () => {
@@ -80,14 +80,14 @@ describe('Viewer', () => {
     it('[C272813] Should be redirected to site when opening and closing a file in a site', async () => {
         await loginPage.loginToContentServicesUsingUserModel(acsUser);
 
-        navigationBarPage.goToSite(site);
-        contentServicesPage.checkAcsContainer();
+        await navigationBarPage.goToSite(site);
+        await contentServicesPage.checkAcsContainer();
 
-        viewerPage.viewFile(pngFileUploaded.entry.name);
+        await viewerPage.viewFile(pngFileUploaded.entry.name);
 
-        viewerPage.checkImgViewerIsDisplayed();
+        await viewerPage.checkImgViewerIsDisplayed();
 
-        viewerPage.clickCloseButton();
+        await viewerPage.clickCloseButton();
     });
 
     describe('Other Folder Uploaded', () => {
@@ -95,32 +95,30 @@ describe('Viewer', () => {
         let uploadedOthers;
         let otherFolderUploaded;
 
-        beforeAll(async (done) => {
+        beforeAll(async () => {
             otherFolderUploaded = await uploadActions.createFolder(otherFolderInfo.name, '-my-');
 
             uploadedOthers = await uploadActions.uploadFolder(otherFolderInfo.location, otherFolderUploaded.entry.id);
 
             await loginPage.loginToContentServicesUsingUserModel(acsUser);
-            contentServicesPage.goToDocumentList();
+            await contentServicesPage.goToDocumentList();
 
-            done();
         });
 
-        afterAll(async (done) => {
+        afterAll(async () => {
             await uploadActions.deleteFileOrFolder(otherFolderUploaded.entry.id);
-            done();
+
         });
 
-        it('[C280012] Should be possible to open any other Document supported extension', () => {
-            contentServicesPage.doubleClickRow('other');
-
-            uploadedOthers.forEach((currentFile) => {
-                if (currentFile.entry.name !== '.DS_Store') {
-                    contentServicesPage.doubleClickRow(currentFile.entry.name);
-                    viewerPage.checkFileIsLoaded();
-                    viewerPage.clickCloseButton();
+        it('[C280012] Should be possible to open any other Document supported extension', async () => {
+            await contentServicesPage.doubleClickRow('other');
+            for (const file of uploadedOthers) {
+                if (file.entry.name !== '.DS_Store') {
+                    await contentServicesPage.doubleClickRow(file.entry.name);
+                    await viewerPage.checkFileIsLoaded();
+                    await viewerPage.clickCloseButton();
                 }
-            });
+            }
         });
 
     });