Disable control flow e2e ADF (#4954)

* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test

e2e/core/viewer/viewer-share-content.ts

@@ -34,9 +34,9 @@ describe('Viewer', () => {
     const loginPage = new LoginPage();
     const contentServicesPage = new ContentServicesPage();
     this.alfrescoJsApi = new AlfrescoApi({
-            provider: 'ECM',
-            hostEcm: browser.params.testConfig.adf_acs.host
-        });
+        provider: 'ECM',
+        hostEcm: browser.params.testConfig.adf_acs.host
+    });
     const uploadActions = new UploadActions(this.alfrescoJsApi);
     let site;
     const acsUser = new AcsUserModel();
@@ -56,7 +56,7 @@ describe('Viewer', () => {
 
     let pngFileShared, wordFileUploaded;
 
-    beforeAll(async (done) => {
+    beforeAll(async () => {
         await this.alfrescoJsApi.login(browser.params.testConfig.adf.adminEmail, browser.params.testConfig.adf.adminPassword);
         await this.alfrescoJsApi.core.peopleApi.addPerson(acsUser);
 
@@ -80,49 +80,44 @@ describe('Viewer', () => {
 
         pngFileShared = await this.alfrescoJsApi.core.sharedlinksApi.addSharedLink({ 'nodeId': pngFileUploaded.entry.id });
 
-        done();
     });
 
-    afterAll(async (done) => {
+    afterAll(async () => {
         await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
         await uploadActions.deleteFileOrFolder(wordFileUploaded.entry.id);
-        await navigationBarPage.clickLogoutButton();
-        done();
     });
 
     beforeEach(async () => {
         await loginPage.loginToContentServicesUsingUserModel(acsUser);
     });
 
-    it('[C260105] Should be able to open an image file shared via API', () => {
-        BrowserActions.getUrl(browser.params.testConfig.adf.url + '/preview/s/' + pngFileShared.entry.id);
-        viewerPage.checkImgContainerIsDisplayed();
-        BrowserActions.getUrl(browser.params.testConfig.adf.url);
-        navigationBarPage.clickLogoutButton();
-        BrowserActions.getUrl(browser.params.testConfig.adf.url + '/preview/s/' + pngFileShared.entry.id);
-        viewerPage.checkImgContainerIsDisplayed();
+    it('[C260105] Should be able to open an image file shared via API', async () => {
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url + '/preview/s/' + pngFileShared.entry.id);
+        await viewerPage.checkImgContainerIsDisplayed();
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url);
+        await navigationBarPage.clickLogoutButton();
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url + '/preview/s/' + pngFileShared.entry.id);
+        await viewerPage.checkImgContainerIsDisplayed();
     });
 
-    it('[C260106] Should be able to open a Word file shared via API', () => {
-        navigationBarPage.clickContentServicesButton();
-        contentServicesPage.waitForTableBody();
+    it('[C260106] Should be able to open a Word file shared via API', async () => {
+        await navigationBarPage.clickContentServicesButton();
+        await contentServicesPage.waitForTableBody();
 
-        contentList.selectRow(wordFileInfo.name);
-        contentServicesPage.clickShareButton();
-        shareDialog.checkDialogIsDisplayed();
-        shareDialog.clickShareLinkButton();
-        browser.controlFlow().execute(async () => {
-            const sharedLink = await shareDialog.getShareLink();
+        await contentList.selectRow(wordFileInfo.name);
+        await contentServicesPage.clickShareButton();
+        await shareDialog.checkDialogIsDisplayed();
+        await shareDialog.clickShareLinkButton();
+        const sharedLink = await shareDialog.getShareLink();
 
-            await BrowserActions.getUrl(sharedLink);
-            viewerPage.checkFileIsLoaded();
-            viewerPage.checkFileNameIsDisplayed(wordFileInfo.name);
+        await BrowserActions.getUrl(sharedLink);
+        await viewerPage.checkFileIsLoaded();
+        await viewerPage.checkFileNameIsDisplayed(wordFileInfo.name);
 
-            await BrowserActions.getUrl(browser.params.testConfig.adf.url);
-            navigationBarPage.clickLogoutButton();
-            await BrowserActions.getUrl(sharedLink);
-            viewerPage.checkFileIsLoaded();
-            viewerPage.checkFileNameIsDisplayed(wordFileInfo.name);
-        });
+        await BrowserActions.getUrl(browser.params.testConfig.adf.url);
+        await navigationBarPage.clickLogoutButton();
+        await BrowserActions.getUrl(sharedLink);
+        await viewerPage.checkFileIsLoaded();
+        await viewerPage.checkFileNameIsDisplayed(wordFileInfo.name);
     });
 });