Disable control flow e2e ADF (#4954)

* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test

e2e/process-services/attach-form-component.e2e.ts

@@ -50,7 +50,7 @@ describe('Attach Form Component', () => {
         formFieldValue: 'Test value'
     };
 
-    beforeAll(async (done) => {
+    beforeAll(async () => {
 
         this.alfrescoJsApi = new AlfrescoApi({
             provider: 'BPM',
@@ -76,64 +76,63 @@ describe('Attach Form Component', () => {
 
         await loginPage.loginToProcessServicesUsingUserModel(user);
 
-        done();
     });
 
-    afterAll(async (done) => {
+    afterAll(async () => {
         await this.alfrescoJsApi.activiti.modelsApi.deleteModel(appId);
         await this.alfrescoJsApi.login(browser.params.testConfig.adf.adminEmail, browser.params.testConfig.adf.adminPassword);
         await this.alfrescoJsApi.activiti.adminTenantsApi.deleteTenant(tenantId);
-        done();
+
     });
 
-    it('[C280047] Should be able to view the attach-form component after creating a standalone task', () => {
-        navigationBarPage.navigateToProcessServicesPage().goToTaskApp().clickTasksButton();
+    it('[C280047] Should be able to view the attach-form component after creating a standalone task', async () => {
+        await (await (await navigationBarPage.navigateToProcessServicesPage()).goToTaskApp()).clickTasksButton();
 
-        taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.MY_TASKS);
-        taskPage.tasksListPage().selectRow(testNames.taskName);
+        await taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.MY_TASKS);
+        await taskPage.tasksListPage().selectRow(testNames.taskName);
 
-        attachFormPage.checkNoFormMessageIsDisplayed();
-        attachFormPage.checkAttachFormButtonIsDisplayed();
-        attachFormPage.checkCompleteButtonIsDisplayed();
+        await attachFormPage.checkNoFormMessageIsDisplayed();
+        await attachFormPage.checkAttachFormButtonIsDisplayed();
+        await attachFormPage.checkCompleteButtonIsDisplayed();
     });
 
-    it('[C280048] Should be able to view the attach-form component after clicking cancel button', () => {
-        navigationBarPage.navigateToProcessServicesPage().goToTaskApp().clickTasksButton();
+    it('[C280048] Should be able to view the attach-form component after clicking cancel button', async () => {
+        await (await (await navigationBarPage.navigateToProcessServicesPage()).goToTaskApp()).clickTasksButton();
 
-        taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.MY_TASKS);
-        taskPage.tasksListPage().selectRow(testNames.taskName);
+        await taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.MY_TASKS);
+        await taskPage.tasksListPage().selectRow(testNames.taskName);
 
-        attachFormPage.clickAttachFormButton();
-        attachFormPage.checkDefaultFormTitleIsDisplayed(testNames.formTitle);
-        attachFormPage.checkFormDropdownIsDisplayed();
-        attachFormPage.checkCancelButtonIsDisplayed();
-        attachFormPage.checkAttachFormButtonIsDisabled();
-        attachFormPage.clickAttachFormDropdown();
-        attachFormPage.selectAttachFormOption(testNames.formName);
+        await attachFormPage.clickAttachFormButton();
+        await attachFormPage.checkDefaultFormTitleIsDisplayed(testNames.formTitle);
+        await attachFormPage.checkFormDropdownIsDisplayed();
+        await attachFormPage.checkCancelButtonIsDisplayed();
+        await attachFormPage.checkAttachFormButtonIsDisabled();
+        await attachFormPage.clickAttachFormDropdown();
+        await attachFormPage.selectAttachFormOption(testNames.formName);
 
-        formFields.checkWidgetIsReadOnlyMode(testNames.widgetTitle);
+        await formFields.checkWidgetIsReadOnlyMode(testNames.widgetTitle);
 
-        attachFormPage.clickCancelButton();
-        attachFormPage.checkAttachFormButtonIsDisplayed();
+        await attachFormPage.clickCancelButton();
+        await attachFormPage.checkAttachFormButtonIsDisplayed();
     });
 
-    it('[C280017] Should be able to attach a form on a standalone task and complete', () => {
-        navigationBarPage.navigateToProcessServicesPage().goToTaskApp().clickTasksButton();
+    it('[C280017] Should be able to attach a form on a standalone task and complete', async () => {
+        await (await (await navigationBarPage.navigateToProcessServicesPage()).goToTaskApp()).clickTasksButton();
 
-        taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.MY_TASKS);
-        taskPage.tasksListPage().selectRow(testNames.taskName);
+        await taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.MY_TASKS);
+        await taskPage.tasksListPage().selectRow(testNames.taskName);
 
-        attachFormPage.clickAttachFormButton();
-        attachFormPage.clickAttachFormDropdown();
-        attachFormPage.selectAttachFormOption(testNames.formName);
-        attachFormPage.clickAttachFormButton();
+        await attachFormPage.clickAttachFormButton();
+        await attachFormPage.clickAttachFormDropdown();
+        await attachFormPage.selectAttachFormOption(testNames.formName);
+        await attachFormPage.clickAttachFormButton();
 
-        formFields.setFieldValue(by.id, formTextField, testNames.formFieldValue);
-        formFields.completeForm();
+        await formFields.setFieldValue(by.id, formTextField, testNames.formFieldValue);
+        await formFields.completeForm();
 
-        taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.COMPLETED_TASKS);
-        taskPage.tasksListPage().selectRow(testNames.taskName);
+        await taskPage.filtersPage().goToFilter(CONSTANTS.TASK_FILTERS.COMPLETED_TASKS);
+        await taskPage.tasksListPage().selectRow(testNames.taskName);
 
-        expect(formFields.getFieldValue(formTextField)).toEqual(testNames.formFieldValue);
+        await expect(await formFields.getFieldValue(formTextField)).toEqual(testNames.formFieldValue);
     });
 });