Disable control flow e2e ADF (#4954)

* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test

e2e/process-services-cloud/apps-section-cloud.e2e.ts

@@ -16,7 +16,14 @@
  */
 
 import { browser } from 'protractor';
-import { ApiService, IdentityService, LoginSSOPage, SettingsPage, LocalStorageUtil, ApplicationsService } from '@alfresco/adf-testing';
+import {
+    ApiService,
+    IdentityService,
+    LoginSSOPage,
+    SettingsPage,
+    LocalStorageUtil,
+    ApplicationsService
+} from '@alfresco/adf-testing';
 import { AppListCloudPage } from '@alfresco/adf-testing';
 import { NavigationBarPage } from '../pages/adf/navigationBarPage';
 import resources = require('../util/resources');
@@ -35,7 +42,7 @@ describe('Applications list', () => {
     let applications;
     const apiService = new ApiService(browser.params.config.oauth2.clientId, browser.params.config.bpmHost, browser.params.config.oauth2.host, 'BPM');
 
-    beforeAll(async (done) => {
+    beforeAll(async () => {
         await apiService.login(browser.params.identityAdmin.email, browser.params.identityAdmin.password);
         identityService = new IdentityService(apiService);
         testUser = await identityService.createIdentityUserWithRole(apiService, [identityService.ROLES.APS_USER, identityService.ROLES.APS_DEVOPS_USER]);
@@ -48,39 +55,37 @@ describe('Applications list', () => {
         applicationsService = new ApplicationsService(apiService);
         applications = await applicationsService.getApplicationsByStatus('RUNNING');
 
-        applications.list.entries.forEach(async (app) => {
+        applications.list.entries.forEach(app => {
             appNames.push(app.entry.name.toLowerCase());
         });
 
         await LocalStorageUtil.setConfigField('alfresco-deployed-apps', '[]');
 
-        done();
     });
 
-    afterAll(async(done) => {
+    afterAll(async () => {
         await apiService.login(browser.params.identityAdmin.email, browser.params.identityAdmin.password);
         await identityService.deleteIdentityUser(testUser.idIdentityService);
-        done();
+
     });
 
     it('[C310373] Should all the app with running state be displayed on dashboard when alfresco-deployed-apps is not used in config file', async () => {
-        navigationBarPage.navigateToProcessServicesCloudPage();
-        appListCloudPage.checkApsContainer();
+        await navigationBarPage.navigateToProcessServicesCloudPage();
+        await appListCloudPage.checkApsContainer();
 
-        appListCloudPage.getNameOfTheApplications().then((list) => {
-            expect(JSON.stringify(list) === JSON.stringify(appNames)).toEqual(true);
-        });
+        const list = await appListCloudPage.getNameOfTheApplications();
+        await expect(JSON.stringify(list)).toEqual(JSON.stringify(appNames));
     });
 
-    it('[C289910] Should the app be displayed on dashboard when is deployed on APS', () => {
-        browser.refresh();
-        navigationBarPage.navigateToProcessServicesCloudPage();
-        appListCloudPage.checkApsContainer();
+    it('[C289910] Should the app be displayed on dashboard when is deployed on APS', async () => {
+        await browser.refresh();
+        await navigationBarPage.navigateToProcessServicesCloudPage();
+        await appListCloudPage.checkApsContainer();
 
-        appListCloudPage.checkAppIsDisplayed(simpleApp);
-        appListCloudPage.checkAppIsDisplayed(resources.ACTIVITI7_APPS.CANDIDATE_BASE_APP.name);
-        appListCloudPage.checkAppIsDisplayed(resources.ACTIVITI7_APPS.SUB_PROCESS_APP.name);
+        await appListCloudPage.checkAppIsDisplayed(simpleApp);
+        await appListCloudPage.checkAppIsDisplayed(resources.ACTIVITI7_APPS.CANDIDATE_BASE_APP.name);
+        await appListCloudPage.checkAppIsDisplayed(resources.ACTIVITI7_APPS.SUB_PROCESS_APP.name);
 
-        expect(appListCloudPage.countAllApps()).toEqual(3);
+        await expect(await appListCloudPage.countAllApps()).toEqual(3);
     });
 });