Disable control flow e2e ADF (#4954)

* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test

e2e/process-services-cloud/start-task/start-task-group-cloud.e2e.ts

@@ -56,7 +56,7 @@ describe('Start Task - Group Cloud Component', () => {
     let identityService: IdentityService;
     let groupIdentityService: GroupIdentityService;
 
-    beforeAll(async (done) => {
+    beforeAll(async () => {
         await apiService.login(browser.params.identityAdmin.email, browser.params.identityAdmin.password);
 
         identityService = new IdentityService(apiService);
@@ -79,10 +79,9 @@ describe('Start Task - Group Cloud Component', () => {
             browser.params.config.oauth2.host,
             browser.params.config.identityHost);
 
-        done();
     });
 
-    afterAll(async (done) => {
+    afterAll(async () => {
         await apiService.login(browser.params.identityAdmin.email, browser.params.identityAdmin.password);
         const tasksService = new TasksService(apiService);
 
@@ -95,117 +94,113 @@ describe('Start Task - Group Cloud Component', () => {
         await identityService.deleteIdentityUser(apsUser.idIdentityService);
         await identityService.deleteIdentityUser(testUser.idIdentityService);
 
-        done();
     });
 
     beforeEach(async () => {
         await loginSSOPage.loginSSOIdentityService(testUser.email, testUser.password);
-        navigationBarPage.navigateToProcessServicesCloudPage();
-        appListCloudComponent.checkApsContainer();
-        appListCloudComponent.checkAppIsDisplayed(simpleApp);
-        appListCloudComponent.goToApp(simpleApp);
-        tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
-        tasksCloudDemoPage.openNewTaskForm();
-        startTask.checkFormIsDisplayed();
+        await navigationBarPage.navigateToProcessServicesCloudPage();
+        await appListCloudComponent.checkApsContainer();
+        await appListCloudComponent.checkAppIsDisplayed(simpleApp);
+        await appListCloudComponent.goToApp(simpleApp);
+        await tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
+        await tasksCloudDemoPage.openNewTaskForm();
+        await startTask.checkFormIsDisplayed();
     });
 
-    afterEach(() => {
-        navigationBarPage.clickLogoutButton();
+    afterEach(async () => {
+        await navigationBarPage.clickLogoutButton();
     });
 
     it('[C291954] Should be able to select/delete an group for a standalone task', async () => {
-        peopleCloudComponent.clearAssignee();
+        await peopleCloudComponent.clearAssignee();
 
-        groupCloud.searchGroups(testGroup.name);
+        await groupCloud.searchGroups(testGroup.name);
+        await groupCloud.checkGroupIsDisplayed(testGroup.name);
+        await groupCloud.selectGroupFromList(testGroup.name);
+        await groupCloud.checkSelectedGroup(testGroup.name);
 
-        groupCloud.checkGroupIsDisplayed(testGroup.name);
-        groupCloud.selectGroupFromList(testGroup.name);
-        groupCloud.checkSelectedGroup(testGroup.name);
+        await groupCloud.searchGroups(hrGroup.name);
+        await groupCloud.checkGroupIsDisplayed(hrGroup.name);
+        await groupCloud.selectGroupFromList(hrGroup.name);
+        await groupCloud.checkSelectedGroup(hrGroup.name);
 
-        groupCloud.searchGroups(hrGroup.name);
-        groupCloud.checkGroupIsDisplayed(hrGroup.name);
-        groupCloud.selectGroupFromList(hrGroup.name);
-        groupCloud.checkSelectedGroup(hrGroup.name);
+        await groupCloud.removeSelectedGroup(testGroup.name);
+        await groupCloud.checkGroupNotSelected(testGroup.name);
 
-        groupCloud.removeSelectedGroup(testGroup.name);
-        groupCloud.checkGroupNotSelected(testGroup.name);
+        await startTask.addName(oneGroupTaskName);
+        await startTask.clickStartButton();
 
-        startTask.addName(oneGroupTaskName);
-        startTask.clickStartButton();
-
-        navigationBarPage.clickLogoutButton();
+        await navigationBarPage.clickLogoutButton();
         await loginSSOPage.loginSSOIdentityService(apsUser.email, apsUser.password);
-        navigationBarPage.navigateToProcessServicesCloudPage();
-        appListCloudComponent.checkApsContainer();
-        appListCloudComponent.checkAppIsDisplayed(simpleApp);
-        appListCloudComponent.goToApp(simpleApp);
-        tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
+        await navigationBarPage.navigateToProcessServicesCloudPage();
+        await appListCloudComponent.checkApsContainer();
+        await appListCloudComponent.checkAppIsDisplayed(simpleApp);
+        await appListCloudComponent.goToApp(simpleApp);
+        await tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
 
-        tasksCloudDemoPage.editTaskFilterCloudComponent()
-            .clickCustomiseFilterHeader()
-            .clearAssignee()
-            .setStatusFilterDropDown('CREATED');
+        await tasksCloudDemoPage.editTaskFilterCloudComponent().clickCustomiseFilterHeader();
+        await tasksCloudDemoPage.editTaskFilterCloudComponent().clearAssignee();
+        await tasksCloudDemoPage.editTaskFilterCloudComponent().setStatusFilterDropDown('CREATED');
 
-        tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
-        tasksCloudDemoPage.taskListCloudComponent().checkContentIsDisplayedByName(oneGroupTaskName);
+        await tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
+        await tasksCloudDemoPage.taskListCloudComponent().checkContentIsDisplayedByName(oneGroupTaskName);
     });
 
     it('[C291955] Should be able to select multiple groups when the selection mode=multiple', async () => {
-        peopleCloudComponent.clearAssignee();
+        await peopleCloudComponent.clearAssignee();
 
-        groupCloud.searchGroups(testGroup.name);
-        groupCloud.checkGroupIsDisplayed(testGroup.name);
-        groupCloud.selectGroupFromList(testGroup.name);
-        groupCloud.checkSelectedGroup(testGroup.name);
+        await groupCloud.searchGroups(testGroup.name);
+        await groupCloud.checkGroupIsDisplayed(testGroup.name);
+        await groupCloud.selectGroupFromList(testGroup.name);
+        await groupCloud.checkSelectedGroup(testGroup.name);
 
-        groupCloud.searchGroups(hrGroup.name);
-        groupCloud.checkGroupIsDisplayed(hrGroup.name);
-        groupCloud.selectGroupFromList(hrGroup.name);
-        groupCloud.checkSelectedGroup(hrGroup.name);
+        await groupCloud.searchGroups(hrGroup.name);
+        await groupCloud.checkGroupIsDisplayed(hrGroup.name);
+        await groupCloud.selectGroupFromList(hrGroup.name);
+        await groupCloud.checkSelectedGroup(hrGroup.name);
 
-        startTask.addName(bothGroupsTaskName);
-        startTask.clickStartButton();
+        await startTask.addName(bothGroupsTaskName);
+        await startTask.clickStartButton();
 
-        navigationBarPage.clickLogoutButton();
+        await navigationBarPage.clickLogoutButton();
         await loginSSOPage.loginSSOIdentityService(apsUser.email, apsUser.password);
-        navigationBarPage.navigateToProcessServicesCloudPage();
-        appListCloudComponent.checkApsContainer();
-        appListCloudComponent.checkAppIsDisplayed(simpleApp);
-        appListCloudComponent.goToApp(simpleApp);
-        tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
+        await navigationBarPage.navigateToProcessServicesCloudPage();
+        await appListCloudComponent.checkApsContainer();
+        await appListCloudComponent.checkAppIsDisplayed(simpleApp);
+        await appListCloudComponent.goToApp(simpleApp);
+        await tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
 
-        tasksCloudDemoPage.editTaskFilterCloudComponent()
-            .clickCustomiseFilterHeader()
-            .clearAssignee()
-            .setStatusFilterDropDown('CREATED');
+        await tasksCloudDemoPage.editTaskFilterCloudComponent().clickCustomiseFilterHeader();
+        await tasksCloudDemoPage.editTaskFilterCloudComponent().clearAssignee();
+        await tasksCloudDemoPage.editTaskFilterCloudComponent().setStatusFilterDropDown('CREATED');
 
-        tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
-        tasksCloudDemoPage.taskListCloudComponent().checkContentIsDisplayedByName(bothGroupsTaskName);
+        await tasksCloudDemoPage.taskListCloudComponent().getDataTable().waitForTableBody();
+        await tasksCloudDemoPage.taskListCloudComponent().checkContentIsDisplayedByName(bothGroupsTaskName);
     });
 
-    it('[C291993] Should NOT be able to find a group already selected', () => {
-        groupCloud.searchGroups(testGroup.name);
-        groupCloud.checkGroupIsDisplayed(testGroup.name);
-        groupCloud.selectGroupFromList(testGroup.name);
-        groupCloud.checkSelectedGroup(testGroup.name);
+    it('[C291993] Should NOT be able to find a group already selected', async () => {
+        await groupCloud.searchGroups(testGroup.name);
+        await groupCloud.checkGroupIsDisplayed(testGroup.name);
+        await groupCloud.selectGroupFromList(testGroup.name);
+        await groupCloud.checkSelectedGroup(testGroup.name);
 
-        groupCloud.searchGroups(testGroup.name);
-        groupCloud.checkGroupIsNotDisplayed(testGroup.name);
+        await groupCloud.searchGroups(testGroup.name);
+        await groupCloud.checkGroupIsNotDisplayed(testGroup.name);
     });
 
     it('[C291995] Should be able to add a group previously removed', async () => {
-        groupCloud.searchGroups(testGroup.name);
-        groupCloud.checkGroupIsDisplayed(testGroup.name);
-        groupCloud.selectGroupFromList(testGroup.name);
-        groupCloud.checkSelectedGroup(testGroup.name);
+        await groupCloud.searchGroups(testGroup.name);
+        await groupCloud.checkGroupIsDisplayed(testGroup.name);
+        await groupCloud.selectGroupFromList(testGroup.name);
+        await groupCloud.checkSelectedGroup(testGroup.name);
 
-        groupCloud.removeSelectedGroup(testGroup.name);
-        groupCloud.checkGroupNotSelected(testGroup.name);
+        await groupCloud.removeSelectedGroup(testGroup.name);
+        await groupCloud.checkGroupNotSelected(testGroup.name);
 
-        groupCloud.searchGroups(testGroup.name);
-        groupCloud.checkGroupIsDisplayed(testGroup.name);
-        groupCloud.selectGroupFromList(testGroup.name);
-        groupCloud.checkSelectedGroup(testGroup.name);
+        await groupCloud.searchGroups(testGroup.name);
+        await groupCloud.checkGroupIsDisplayed(testGroup.name);
+        await groupCloud.selectGroupFromList(testGroup.name);
+        await groupCloud.checkSelectedGroup(testGroup.name);
     });
 
 });