Disable control flow e2e ADF (#4954)

* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test

scripts/check-env/check-activiti-env.js

@@ -6,7 +6,7 @@ let ACTIVITI7_APPS = require('../../e2e/util/resources').ACTIVITI7_APPS;
 
 let config = {};
 let absentApps = [];
-let pushFaileApps = [];
+let pushFailedApps = [];
 let notRunningApps = [];
 let host;
 
@@ -97,15 +97,13 @@ async function main() {
 }
 
 async function deleteStaleApps(alfrescoJsApi, notRunningAppAfterWait) {
-
-    notRunningAppAfterWait.forEach(async (currentApp) => {
+    for (const currentApp of notRunningAppAfterWait) {
         await deleteApp(alfrescoJsApi, currentApp.entry.name);
-    });
-
+    }
 }
 
 async function waitPossibleStaleApps(alfrescoJsApi, notRunning) {
-    pushFaileApps = [];
+    pushFailedApps = [];
     do {
         console.log(`Wait stale app  ${TIMEOUT}`);
 
@@ -113,7 +111,6 @@ async function waitPossibleStaleApps(alfrescoJsApi, notRunning) {
             console.log(`${currentApp.entry.name } ${currentApp.entry.status}`);
         });
 
-
         sleep(TIMEOUT);
         counter++;
 
@@ -174,19 +171,19 @@ async function getPushFailedApps(alfrescoJsApi) {
         });
 
         if (isNotRunning && isNotRunning.entry.status === 'ImagePushFailed') {
-            pushFaileApps.push(isNotRunning);
+            pushFailedApps.push(isNotRunning);
         }
     });
 
-    if (pushFaileApps.length > 0) {
-        console.log(`The following apps are pushFaileApps:`);
-        pushFaileApps.forEach((currentApp) => {
+    if (pushFailedApps.length > 0) {
+        console.log(`The following apps are pushFailedApps:`);
+        pushFailedApps.forEach((currentApp) => {
             console.log(`App ${currentApp.entry.name } current status ${JSON.stringify(currentApp.entry.status)}`);
         });
 
     }
 
-    return pushFaileApps;
+    return pushFailedApps;
 }
 
 async function deployAbsentApps(alfrescoJsApi) {

scripts/check-env/delete-all-apps.js

@@ -42,9 +42,9 @@ async function main() {
         console.log('Login error' + e);
     }
 
-    Object.keys(ACTIVITI7_APPS).forEach(async (key) => {
+    for (const key of Object.keys(ACTIVITI7_APPS)) {
         await deleteApp(alfrescoJsApi, ACTIVITI7_APPS[key].name);
-    });
+    }
 
     let notRunning = await getNotRunningApps(this.alfrescoJsApi);