inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-05-19 17:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use event to close dialog

Browse Source 
- Work around close handler method being private

Refs #849
This commit is contained in:
Will Abson 2016-11-14 09:58:25 +00:00 committed by Mario Romano
parent 5f60760cd5
commit 840912967e
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.html
View File

@ -74,7 +74,7 @@
<activiti-task-details [taskId]="selectedTaskId" (formCompleted)="taskFormCompleted()" #taskdetails></activiti-task-details> <activiti-task-details [taskId]="selectedTaskId" (formCompleted)="taskFormCompleted()" #taskdetails></activiti-task-details>
</div> </div>
<div class="mdl-dialog__actions"> <div class="mdl-dialog__actions">
<button type="button" (click)="closeDialog()" class="mdl-button close">{{ 'DETAILS.TASKS.TASK_CLOSE' | translate }}</button> <button type="button" (click)="closeDialog()" class="mdl-button close" data-automation-id="button-task-close">{{ 'DETAILS.TASKS.TASK_CLOSE' | translate }}</button>
</div> </div>
</dialog> </dialog>

7
ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.spec.ts
View File

@ -15,7 +15,7 @@
* limitations under the License. * limitations under the License.
*/ */
import { NO_ERRORS_SCHEMA } from '@angular/core'; import { DebugElement, NO_ERRORS_SCHEMA } from '@angular/core';
import { ComponentFixture, TestBed, async } from '@angular/core/testing'; import { ComponentFixture, TestBed, async } from '@angular/core/testing';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { Observable } from 'rxjs/Rx'; import { Observable } from 'rxjs/Rx';
@ -34,6 +34,7 @@ describe('ActivitiProcessInstanceTasks', () => {
let componentHandler: any; let componentHandler: any;
let component: ActivitiProcessInstanceTasks; let component: ActivitiProcessInstanceTasks;
let fixture: ComponentFixture<ActivitiProcessInstanceTasks>; let fixture: ComponentFixture<ActivitiProcessInstanceTasks>;
let debugElement: DebugElement;
let service: ActivitiProcessService; let service: ActivitiProcessService;
let getProcessTasksSpy: jasmine.Spy; let getProcessTasksSpy: jasmine.Spy;
@ -59,6 +60,7 @@ describe('ActivitiProcessInstanceTasks', () => {
fixture = TestBed.createComponent(ActivitiProcessInstanceTasks); fixture = TestBed.createComponent(ActivitiProcessInstanceTasks);
component = fixture.componentInstance; component = fixture.componentInstance;
debugElement = fixture.debugElement;
service = fixture.debugElement.injector.get(ActivitiProcessService); service = fixture.debugElement.injector.get(ActivitiProcessService);
getProcessTasksSpy = spyOn(service, 'getProcessTasks').and.returnValue(Observable.of([new TaskDetailsModel(taskDetailsMock)])); getProcessTasksSpy = spyOn(service, 'getProcessTasks').and.returnValue(Observable.of([new TaskDetailsModel(taskDetailsMock)]));
@ -181,7 +183,8 @@ describe('ActivitiProcessInstanceTasks', () => {
it('should close the task details dialog when close button clicked', () => { it('should close the task details dialog when close button clicked', () => {
component.clickTask({}, new TaskDetailsModel(taskDetailsMock)); component.clickTask({}, new TaskDetailsModel(taskDetailsMock));
fixture.detectChanges(); fixture.detectChanges();
component.cancelDialog(); let closeButton: DebugElement = debugElement.query(By.css('[data-automation-id="button-task-close"]'));
closeButton.triggerEventHandler('click', null);
expect(closeSpy).toHaveBeenCalled(); expect(closeSpy).toHaveBeenCalled();
}); });