[ADF-5031][PeopleCloudComponent] [PeopleCloudComponent] Provide a way to make selected items read-only (not remove) (#5289)

* [DW-1618] Admin App -Application Instances - Able to delete all the admin users in Manage app permissions.

* [ADF-5031] [PeopleCloudComponent] Do not delete selected users completely.

* Added flag for not to remove last chip
* Added unit tests to the changes.

* * Added doc

* * Changed removeLastChip to remove

* * Added readonly strategy
* Removed remove input
* Updated unit tests

* * Added  tooltip
* Hiding remove icon.

* * Fixed unit tests

lib/process-services-cloud/src/lib/group/components/group-cloud.component.html

@@ -6,9 +6,11 @@
         *ngFor="let group of selectedGroups$ | async"
         [removable]="!(group.readonly)"
         (removed)="onRemove(group)"
+        matTooltip="{{ (group.readonly ? 'ADF_CLOUD_GROUPS.MANDATORY' : '') | translate }}"
         [attr.data-automation-id]="'adf-cloud-group-chip-' + group.name">
         {{group.name}}
         <mat-icon
+            *ngIf=!(group.readonly)
             matChipRemove [attr.data-automation-id]="'adf-cloud-group-chip-remove-icon-' + group.name">
             cancel
         </mat-icon>

lib/process-services-cloud/src/lib/group/components/group-cloud.component.spec.ts

@@ -442,7 +442,7 @@ describe('GroupCloudComponent', () => {
 
     describe('Multiple Mode with read-only', () => {
 
-        it('Should not be able to remove pre-selected groups if readonly property set to true', (done) => {
+        it('Should not show remove icon for pre-selected groups if readonly property set to true', (done) => {
             fixture.detectChanges();
             const preselectedGroups = [
                 { id: mockIdentityGroups[0].id, name: mockIdentityGroups[0].name, readonly: true },
@@ -451,7 +451,6 @@ describe('GroupCloudComponent', () => {
             component.preSelectGroups = preselectedGroups;
             const change = new SimpleChange(null, preselectedGroups, false);
             component.mode = 'multiple';
-            const removeGroupSpy = spyOn(component.removeGroup, 'emit');
             component.ngOnChanges({ 'preSelectGroups': change });
             fixture.detectChanges();
             const chipList = fixture.nativeElement.querySelectorAll('mat-chip-list mat-chip');
@@ -462,9 +461,7 @@ describe('GroupCloudComponent', () => {
             fixture.detectChanges();
             fixture.whenStable().then(() => {
                 fixture.detectChanges();
-                removeIcon.click();
-                fixture.detectChanges();
-                expect(removeGroupSpy).not.toHaveBeenCalled();
+                expect(removeIcon).toBeNull();
                 expect(component.preSelectGroups.length).toBe(2);
                 expect(component.preSelectGroups[0].readonly).toBe(true, 'Not removable');
                 expect(component.preSelectGroups[1].readonly).toBe(true, 'Not removable');

lib/process-services-cloud/src/lib/i18n/en.json

@@ -176,6 +176,7 @@
   },
   "ADF_CLOUD_GROUPS": {
     "SEARCH-GROUP": "Groups",
+    "MANDATORY": "Mandatory",
     "ERROR": {
       "NOT_FOUND": "No group found with the name {{groupName}}"
     }

lib/process-services-cloud/src/lib/task/start-task/components/people-cloud/people-cloud.component.html

@@ -4,9 +4,17 @@
         <mat-chip-list #userChipList *ngIf="isMultipleMode(); else singleSelection">
         <mat-chip
             *ngFor="let user of selectedUsers$ | async"
+            [removable]="!(user.readonly)"
+            [attr.data-automation-id]="'adf-people-cloud-chip-' + user.username"
+            matTooltip="{{ (user.readonly ? 'ADF_CLOUD_GROUPS.MANDATORY' : '') | translate }}"
             (removed)="onRemove(user)">
             {{user | fullName}}
-            <mat-icon matChipRemove>cancel</mat-icon>
+            <mat-icon
+                matChipRemove
+                *ngIf=!(user.readonly)
+                [attr.data-automation-id]="'adf-people-cloud-chip-remove-icon-' + user.username">
+                cancel
+            </mat-icon>
         </mat-chip>
         <input
             #userInput

lib/process-services-cloud/src/lib/task/start-task/components/people-cloud/people-cloud.component.spec.ts

@@ -461,6 +461,59 @@ describe('PeopleCloudComponent', () => {
         });
     });
 
+    describe('Multiple Mode with read-only mode', () => {
+
+        it('Should not show remove icon for pre-selected users if readonly property set to true', (done) => {
+            component.mode = 'multiple';
+            const removeUserSpy = spyOn(component.removeUser, 'emit');
+            component.preSelectUsers = [
+                { id: mockUsers[0].id, username: mockUsers[0].username, readonly: true },
+                { id: mockUsers[1].id, username: mockUsers[1].username, readonly: true }
+            ];
+            fixture.detectChanges();
+            const chipList = fixture.nativeElement.querySelectorAll('mat-chip-list mat-chip');
+            const removeIcon = <HTMLElement> fixture.nativeElement.querySelector('[data-automation-id="adf-people-cloud-chip-remove-icon-first-name-1 last-name-1"]');
+            expect(chipList.length).toBe(2);
+            expect(component.preSelectUsers[0].readonly).toBeTruthy();
+            expect(component.preSelectUsers[1].readonly).toBeTruthy();
+            fixture.detectChanges();
+            fixture.whenStable().then(() => {
+                fixture.detectChanges();
+                expect(removeIcon).toBeNull();
+                fixture.detectChanges();
+                expect(removeUserSpy).not.toHaveBeenCalled();
+                expect(component.preSelectUsers.length).toBe(2);
+                expect(component.preSelectUsers[0].readonly).toBe(true, 'Not removable');
+                expect(component.preSelectUsers[1].readonly).toBe(true, 'not removable');
+                done();
+            });
+        });
+
+        it('Should be able to remove preselected users if readonly property set to false', (done) => {
+            component.mode = 'multiple';
+            const removeUserSpy = spyOn(component.removeUser, 'emit');
+            component.preSelectUsers = [
+                { id: mockUsers[0].id, username: mockUsers[0].username, readonly: false },
+                { id: mockUsers[1].id, username: mockUsers[1].username, readonly: false }
+            ];
+            fixture.detectChanges();
+            const chipList = fixture.nativeElement.querySelectorAll('mat-chip-list mat-chip');
+            const removeIcon = <HTMLElement> fixture.nativeElement.querySelector('[data-automation-id="adf-people-cloud-chip-remove-icon-first-name-1 last-name-1"]');
+            expect(chipList.length).toBe(2);
+            expect(component.preSelectUsers[0].readonly).toBe(false, 'Removable');
+            expect(component.preSelectUsers[1].readonly).toBe(false, 'Removable');
+            removeIcon.click();
+            fixture.detectChanges();
+            fixture.whenStable().then(() => {
+                fixture.detectChanges();
+                expect(removeUserSpy).toHaveBeenCalled();
+                expect(component.preSelectUsers.length).toBe(1);
+                expect(component.preSelectUsers[0].readonly).toBeFalsy();
+                done();
+            });
+        });
+    });
+
     describe('Multiple Mode and Pre-selected users with validate flag', () => {
 
         const change = new SimpleChange(null, mockPreselectedUsers, false);