inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

make comments always editable for process (#2447)

Browse Source 
make comments editable only when there are users involved
This commit is contained in:
Eugenio Romano
2017-10-06 17:27:10 +01:00
committed by GitHub
parent 7894d687ab
commit 85a275d66a
8 changed files with 106 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
ng2-components/ng2-activiti-tasklist/src/components/task-details.component.spec.ts
View File

@@ -73,10 +73,10 @@ describe('TaskDetailsComponent', () => {
providers: [
TaskListService,
PeopleProcessService,
{ provide: TranslationService, useClass: TranslationMock },
{ provide: AppConfigService, useClass: AppConfigServiceMock }
{provide: TranslationService, useClass: TranslationMock},
{provide: AppConfigService, useClass: AppConfigServiceMock}
],
schemas: [ NO_ERRORS_SCHEMA ]
schemas: [NO_ERRORS_SCHEMA]
}).compileComponents();
logService = TestBed.get(LogService);
@@ -157,7 +157,7 @@ describe('TaskDetailsComponent', () => {
}));
it('should fetch new task details when taskId changed', () => {
component.ngOnChanges({ 'taskId': change });
component.ngOnChanges({'taskId': change});
expect(getTaskDetailsSpy).toHaveBeenCalledWith('456');
});
@@ -167,12 +167,12 @@ describe('TaskDetailsComponent', () => {
});
it('should NOT fetch new task details when taskId changed to null', () => {
component.ngOnChanges({ 'taskId': nullChange });
component.ngOnChanges({'taskId': nullChange});
expect(getTaskDetailsSpy).not.toHaveBeenCalled();
});
it('should set a placeholder message when taskId changed to null', () => {
component.ngOnChanges({ 'taskId': nullChange });
component.ngOnChanges({'taskId': nullChange});
fixture.detectChanges();
expect(fixture.nativeElement.innerText).toBe('TASK_DETAILS.MESSAGES.NONE');
});
@@ -285,6 +285,48 @@ describe('TaskDetailsComponent', () => {
});
describe('Comments', () => {
it('should comments NOT be readonly if is there are user involved', () => {
component.showComments = true;
component.showHeaderContent = true;
component.ngOnChanges({'taskId': new SimpleChange('123', '456', true)});
component.taskPeople = [fakeUser];
fixture.detectChanges();
expect((component.activiticomments as any).nativeElement.readOnly).toBe(false);
});
it('should comments be readonly if is there are no user involved', () => {
component.showComments = true;
component.showHeaderContent = true;
component.ngOnChanges({'taskId': new SimpleChange('123', '456', true)});
component.taskPeople = [];
fixture.detectChanges();
expect((component.activiticomments as any).nativeElement.readOnly).toBe(true);
});
it('should comments be present if showComments is true', () => {
component.showComments = true;
component.showHeaderContent = true;
component.taskPeople = [];
component.ngOnChanges({'taskId': new SimpleChange('123', '456', true)});
fixture.detectChanges();
expect(component.activiticomments).toBeDefined();
});
it('should comments NOT be present if showComments is false', () => {
component.showComments = false;
component.taskPeople = [];
component.ngOnChanges({'taskId': new SimpleChange('123', '456', true)});
fixture.detectChanges();
expect(component.activiticomments).not.toBeDefined();
});
});
describe('assign task to user', () => {
beforeEach(() => {