AAE-29442 moving to node 20.18.1 (#10500)

* AAE-0000 - moving to node 20.18.1

* AAE-29442 Adjusted to the new eslint rule
This commit is contained in:
Vito Albano
2024-12-18 11:14:52 +00:00
committed by GitHub
parent dd44e492b7
commit 872fb16b62
144 changed files with 5267 additions and 6842 deletions

View File

@@ -10,7 +10,7 @@
"createDefaultProgram": true
},
"rules": {
"jsdoc/newline-after-description": "warn",
"jsdoc/tag-lines": ["error", "any", {"startLines": 1}],
"@typescript-eslint/naming-convention": "warn",
"@typescript-eslint/consistent-type-assertions": "warn",
"@typescript-eslint/prefer-for-of": "warn",

View File

@@ -140,7 +140,6 @@ export class StartFormComponent extends FormComponent implements OnChanges, OnIn
this.onFormLoaded(this.form);
}
/** @override */
isOutcomeButtonVisible(outcome: FormOutcomeModel, isFormReadOnly: boolean): boolean {
if (outcome?.isSystem && (outcome.name === FormOutcomeModel.SAVE_ACTION || outcome.name === FormOutcomeModel.COMPLETE_ACTION)) {
return false;
@@ -150,12 +149,10 @@ export class StartFormComponent extends FormComponent implements OnChanges, OnIn
return super.isOutcomeButtonVisible(outcome, isFormReadOnly);
}
/** @override */
saveTaskForm() {
// do nothing
}
/** @override */
onRefreshClicked() {
if (this.processDefinitionId) {
this.visibilityService.cleanProcessVariable();

View File

@@ -128,9 +128,7 @@ export class PeopleWidgetComponent extends WidgetComponent implements OnInit {
isValidUser(users: LightUserRepresentation[], name: string): boolean {
if (users) {
return !!users.find((user) => {
return this.getDisplayName(user).toLocaleLowerCase() === name.toLocaleLowerCase();
});
return !!users.find((user) => this.getDisplayName(user).toLocaleLowerCase() === name.toLocaleLowerCase());
}
return false;
}

View File

@@ -39,7 +39,7 @@ describe('PeopleSearchFieldComponent', () => {
});
it('should have the proper placeholder by default', () => {
const input = <HTMLInputElement> element.querySelector<HTMLElement>('[data-automation-id="adf-people-search-input"]');
const input = element.querySelector<HTMLElement>('[data-automation-id="adf-people-search-input"]') as HTMLInputElement;
expect(input.placeholder).toBe('ADF_TASK_LIST.PEOPLE.SEARCH_USER');
});
@@ -49,7 +49,7 @@ describe('PeopleSearchFieldComponent', () => {
fixture.detectChanges();
await fixture.whenStable();
const input = <HTMLInputElement> element.querySelector<HTMLElement>('[data-automation-id="adf-people-search-input"]');
const input = element.querySelector<HTMLElement>('[data-automation-id="adf-people-search-input"]') as HTMLInputElement;
expect(input.placeholder).toBe('Arcadia Bay');
});