inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AAE-3200] Attach button of content node selector becomes enabled when selecting a folder (#5946)

Browse Source 
* [AAE-3200] Attach button of content node selector becomes enabled when selecting a folder

* * Removed  excluded test from the protractor.exludes.json file
This commit is contained in:
siva kumar
2020-08-04 13:51:37 +05:30
committed by GitHub
parent 1ade912e64
commit 88433fe4b9
4 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/protractor.excludes.json
View File

@@ -5,10 +5,6 @@
"C362241": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182", "C362241": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182",
"C362242": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182", "C362242": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182",
"C362265": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182", "C362265": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182",
"C311287": "https://issues.alfresco.com/jira/browse/AAE-3200",
"C260140": "https://issues.alfresco.com/jira/browse/AAE-3200",
"C261160": "https://issues.alfresco.com/jira/browse/AAE-3200",
"C246534": "https://issues.alfresco.com/jira/browse/AAE-3200",
"C310358": "Include once process storage services removed, https://issues.alfresco.com/jira/browse/AAE-3177", "C310358": "Include once process storage services removed, https://issues.alfresco.com/jira/browse/AAE-3177",
"C311290": "Include once process storage services removed, https://issues.alfresco.com/jira/browse/AAE-3177" "C311290": "Include once process storage services removed, https://issues.alfresco.com/jira/browse/AAE-3177"
} }

2
lib/content-services/src/lib/content-node-selector/content-node-selector.component.html
View File

@@ -44,7 +44,7 @@
</button> </button>
<button mat-button <button mat-button
[disabled]="!chosenNode" [disabled]="!hasNodeSelected()"
class="adf-choose-action" class="adf-choose-action"
(click)="onClick()" (click)="onClick()"
data-automation-id="content-node-selector-actions-choose">{{ buttonActionName | translate }} data-automation-id="content-node-selector-actions-choose">{{ buttonActionName | translate }}

16
lib/content-services/src/lib/content-node-selector/content-node-selector.component.spec.ts
View File

@@ -161,6 +161,22 @@ describe('ContentNodeSelectorDialogComponent', () => {
const actionButton = fixture.debugElement.query(By.css('[data-automation-id="content-node-selector-actions-choose"]')); const actionButton = fixture.debugElement.query(By.css('[data-automation-id="content-node-selector-actions-choose"]'));
expect(actionButton.nativeElement.disabled).toBeFalsy(); expect(actionButton.nativeElement.disabled).toBeFalsy();
}); });
it('should be disabled when no node chosen', () => {
component.onSelect([new Node({ id: 'fake' })]);
fixture.detectChanges();
const actionButtonWithNodeSelected = fixture.debugElement.query(By.css('[data-automation-id="content-node-selector-actions-choose"]'));
expect(actionButtonWithNodeSelected.nativeElement.disabled).toBe(false);
component.onSelect([]);
fixture.detectChanges();
const actionButtonWithoutNodeSelected = fixture.debugElement.query(By.css('[data-automation-id="content-node-selector-actions-choose"]'));
expect(actionButtonWithoutNodeSelected.nativeElement.disabled).toBe(true);
});
}); });
describe('Title', () => { describe('Title', () => {

4
lib/content-services/src/lib/content-node-selector/content-node-selector.component.ts
View File

@@ -82,4 +82,8 @@ export class ContentNodeSelectorComponent {
onError(error) { onError(error) {
this.notificationService.showError(error); this.notificationService.showError(error);
} }
hasNodeSelected(): boolean {
return this.chosenNode?.length > 0;
}
} }