diff --git a/demo-shell-ng2/app/components/activiti/activiti-demo.component.html b/demo-shell-ng2/app/components/activiti/activiti-demo.component.html index 5206baf609..3faac514e3 100644 --- a/demo-shell-ng2/app/components/activiti/activiti-demo.component.html +++ b/demo-shell-ng2/app/components/activiti/activiti-demo.component.html @@ -5,9 +5,9 @@
- TASKS - PROCESSES - REPORTS + TASKS + PROCESSES + REPORTS
@@ -15,7 +15,7 @@ -
+
@@ -52,8 +52,8 @@ -
-
+
+
@@ -81,9 +81,11 @@
Process Details

- + +
Start Process @@ -98,8 +100,8 @@ -
-
+
+
Report List
diff --git a/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts b/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts index b2fec92f42..2ac2458a4b 100644 --- a/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts +++ b/demo-shell-ng2/app/components/activiti/activiti-demo.component.ts @@ -19,9 +19,9 @@ import { AfterViewInit, Component, ElementRef, Input, ViewChild } from '@angular import { ActivitiApps, ActivitiFilters, - ActivitiTaskDetails, ActivitiTaskList, - FilterRepresentationModel + FilterRepresentationModel, + TaskDetailsEvent } from 'ng2-activiti-tasklist'; import { ActivitiProcessFilters, @@ -52,18 +52,12 @@ const currentProcessIdNew = '__NEW__'; }) export class ActivitiDemoComponent implements AfterViewInit { - @ViewChild(ActivitiApps) - activitiapps: ActivitiApps; - @ViewChild(ActivitiFilters) activitifilter: ActivitiFilters; @ViewChild(ActivitiTaskList) activititasklist: ActivitiTaskList; - @ViewChild(ActivitiTaskDetails) - activitidetails: ActivitiTaskDetails; - @ViewChild(ActivitiProcessFilters) activitiprocessfilter: ActivitiProcessFilters; @@ -89,9 +83,7 @@ export class ActivitiDemoComponent implements AfterViewInit { taskSchemaColumns: any [] = []; processSchemaColumns: any [] = []; - processTabActivie: boolean = false; - - reportsTabActivie: boolean = false; + activeTab: string = 'tasks'; // tasks|processes|reports taskFilter: FilterRepresentationModel; report: any; @@ -219,10 +211,6 @@ export class ActivitiDemoComponent implements AfterViewInit { this.activitiprocesslist.reload(); } - taskFormCompleted(data: any) { - this.activitiprocesslist.reload(); - } - onFormCompleted(form) { this.activititasklist.reload(); this.currentTaskId = null; @@ -237,14 +225,6 @@ export class ActivitiDemoComponent implements AfterViewInit { this.loadStencilScriptsInPageFromActiviti(); } - activeProcess() { - this.processTabActivie = true; - } - - activeReports() { - this.reportsTabActivie = true; - } - loadStencilScriptsInPageFromActiviti() { this.apiService.getInstance().activiti.scriptFileApi.getControllers().then(response => { if (response) { @@ -256,4 +236,10 @@ export class ActivitiDemoComponent implements AfterViewInit { }); } + onProcessDetailsTaskClick(event: TaskDetailsEvent) { + event.preventDefault(); + this.currentTaskId = event.value.id; + this.activeTab = 'tasks'; + } + } diff --git a/ng2-components/ng2-activiti-form/src/services/ecm-model.service.ts b/ng2-components/ng2-activiti-form/src/services/ecm-model.service.ts index 0b15c99a61..7845f8dfcc 100644 --- a/ng2-components/ng2-activiti-form/src/services/ecm-model.service.ts +++ b/ng2-components/ng2-activiti-form/src/services/ecm-model.service.ts @@ -47,7 +47,7 @@ export class EcmModelService { }); } }, - this.handleError + err => this.handleError(err) ); }); @@ -72,10 +72,10 @@ export class EcmModelService { observer.complete(); }); }, - this.handleError + err => this.handleError(err) ); }, - this.handleError + err => this.handleError(err) ); }); } @@ -95,7 +95,7 @@ export class EcmModelService { observer.complete(); } }, - this.handleError + err => this.handleError(err) ); }); } @@ -111,9 +111,9 @@ export class EcmModelService { observer.next(typeCreated); observer.complete(); }, - this.handleError); + err => this.handleError(err)); }, - this.handleError); + err => this.handleError(err)); }); } @@ -126,25 +126,25 @@ export class EcmModelService { public activeEcmModel(modelName: string): Observable { return Observable.fromPromise(this.apiService.getInstance().core.customModelApi.activateCustomModel(modelName)) .map(this.toJson) - .catch(this.handleError); + .catch(err => this.handleError(err)); } public createEcmModel(modelName: string, nameSpace: string): Observable { return Observable.fromPromise(this.apiService.getInstance().core.customModelApi.createCustomModel('DRAFT', '', modelName, modelName, nameSpace)) .map(this.toJson) - .catch(this.handleError); + .catch(err => this.handleError(err)); } public getEcmModels(): Observable { return Observable.fromPromise(this.apiService.getInstance().core.customModelApi.getAllCustomModel()) .map(this.toJson) - .catch(this.handleError); + .catch(err => this.handleError(err)); } public getEcmType(modelName: string): Observable { return Observable.fromPromise(this.apiService.getInstance().core.customModelApi.getAllCustomType(modelName)) .map(this.toJson) - .catch(this.handleError); + .catch(err => this.handleError(err)); } public createEcmType(typeName: string, modelName: string, parentType: string): Observable { @@ -152,7 +152,7 @@ export class EcmModelService { return Observable.fromPromise(this.apiService.getInstance().core.customModelApi.createCustomType(modelName, name, parentType, typeName, '')) .map(this.toJson) - .catch(this.handleError); + .catch(err => this.handleError(err)); } public addPropertyToAType(modelName: string, typeName: string, formFields: any) { @@ -177,11 +177,11 @@ export class EcmModelService { return Observable.fromPromise(this.apiService.getInstance().core.customModelApi.addPropertyToType(modelName, name, properties)) .map(this.toJson) - .catch(this.handleError); + .catch(err => this.handleError(err)); } - public cleanNameType(name: string): string { + cleanNameType(name: string): string { let cleanName = name; if (name.indexOf(':') !== -1) { cleanName = name.split(':')[1]; diff --git a/ng2-components/ng2-activiti-form/stencils/runtime.ng1.js b/ng2-components/ng2-activiti-form/stencils/runtime.ng1.js index 411ee66cf2..c5b4de0e42 100644 --- a/ng2-components/ng2-activiti-form/stencils/runtime.ng1.js +++ b/ng2-components/ng2-activiti-form/stencils/runtime.ng1.js @@ -5,8 +5,11 @@ window.angular = { return { controller: function (controllerName) { console.info('ng1: controller %s requested', controllerName); - return { - } + return {} + }, + directive: function (directiveName) { + console.info('ng1: directive %s requested', directiveName); + return {} } } } diff --git a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.html b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.html index 30b138e0d5..67fb465d4a 100644 --- a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.html +++ b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.html @@ -4,8 +4,10 @@
- + +
diff --git a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.spec.ts b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.spec.ts index 2cb2a9399f..db8369d0e9 100644 --- a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.spec.ts +++ b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.spec.ts @@ -21,7 +21,7 @@ import { By } from '@angular/platform-browser'; import { Observable } from 'rxjs/Rx'; import { AlfrescoTranslateService, CoreModule } from 'ng2-alfresco-core'; -import { ActivitiFormModule, FormModel, FormService } from 'ng2-activiti-form'; +import { ActivitiFormModule, FormService } from 'ng2-activiti-form'; import { ActivitiTaskListModule } from 'ng2-activiti-tasklist'; import { ActivitiProcessInstanceDetails } from './activiti-process-instance-details.component'; @@ -139,20 +139,4 @@ describe('ActivitiProcessInstanceDetails', () => { }); }); - describe('events', () => { - - beforeEach(async(() => { - component.processInstanceId = '123'; - fixture.detectChanges(); - fixture.whenStable(); - })); - - it('should emit a task form completed event when task form completed', () => { - let emitSpy: jasmine.Spy = spyOn(component.taskFormCompleted, 'emit'); - component.bubbleTaskFormCompleted(new FormModel()); - expect(emitSpy).toHaveBeenCalled(); - }); - - }); - }); diff --git a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.ts b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.ts index 6409ee478e..5c309cdc03 100644 --- a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.ts +++ b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-details.component.ts @@ -17,13 +17,13 @@ import { Component, Input, ViewChild, Output, EventEmitter, OnChanges, SimpleChanges } from '@angular/core'; import { AlfrescoTranslateService, LogService } from 'ng2-alfresco-core'; +import { TaskDetailsEvent } from 'ng2-activiti-tasklist'; + import { ActivitiProcessService } from './../services/activiti-process.service'; import { ActivitiProcessInstanceHeader } from './activiti-process-instance-header.component'; import { ActivitiProcessInstanceTasks } from './activiti-process-instance-tasks.component'; import { ProcessInstance } from '../models/process-instance.model'; -declare let componentHandler: any; - @Component({ selector: 'activiti-process-instance-details', moduleId: module.id, @@ -51,7 +51,7 @@ export class ActivitiProcessInstanceDetails implements OnChanges { processCancelled: EventEmitter = new EventEmitter(); @Output() - taskFormCompleted: EventEmitter = new EventEmitter(); + taskClick: EventEmitter = new EventEmitter(); processInstanceDetails: ProcessInstance; @@ -98,10 +98,6 @@ export class ActivitiProcessInstanceDetails implements OnChanges { } } - bubbleTaskFormCompleted(data: any) { - this.taskFormCompleted.emit(data); - } - isRunning(): boolean { return this.processInstanceDetails && !this.processInstanceDetails.ended; } @@ -114,4 +110,9 @@ export class ActivitiProcessInstanceDetails implements OnChanges { this.logService.error(err); }); } + + // bubbles (taskClick) event + onTaskClicked(event: TaskDetailsEvent) { + this.taskClick.emit(event); + } } diff --git a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.css b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.css index 5611dd9942..2335ce2dec 100644 --- a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.css +++ b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.css @@ -47,3 +47,7 @@ display: block; padding: 12px; } + +.process-tasks__task-item { + cursor: pointer; +} diff --git a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.html b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.html index aec79cdaf3..0946965608 100644 --- a/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.html +++ b/ng2-components/ng2-activiti-processlist/src/components/activiti-process-instance-tasks.component.html @@ -1,6 +1,5 @@
-
@@ -12,11 +11,13 @@