From 89380f2905c3c5c90ed66bc5c571fd6e53f02a68 Mon Sep 17 00:00:00 2001 From: AleksanderSklorz <115619721+AleksanderSklorz@users.noreply.github.com> Date: Wed, 16 Jul 2025 09:13:10 +0200 Subject: [PATCH] [ACS-7266] checkboxes in sorting boxes are put on the right side of the text instead of the left side (#11009) * [ACS-7266] Fix for checkboxes position * [ACS-7266] Unit test * [ACS-7266] Addressed comment --- .../search-check-list.component.html | 1 - .../search-check-list.component.spec.ts | 16 ++++++++++++++++ lib/core/src/lib/testing/unit-testing-utils.ts | 4 ++++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/content-services/src/lib/search/components/search-check-list/search-check-list.component.html b/lib/content-services/src/lib/search/components/search-check-list/search-check-list.component.html index d25872d267..0147b1c74b 100644 --- a/lib/content-services/src/lib/search/components/search-check-list/search-check-list.component.html +++ b/lib/content-services/src/lib/search/components/search-check-list/search-check-list.component.html @@ -2,7 +2,6 @@ { let loader: HarnessLoader; let fixture: ComponentFixture; let component: SearchCheckListComponent; + let unitTestingUtils: UnitTestingUtils; beforeEach(() => { TestBed.configureTestingModule({ @@ -38,6 +41,7 @@ describe('SearchCheckListComponent', () => { fixture = TestBed.createComponent(SearchCheckListComponent); component = fixture.componentInstance; loader = TestbedHarnessEnvironment.loader(fixture); + unitTestingUtils = new UnitTestingUtils(fixture.debugElement); component.context = { queryFragments: {}, @@ -138,6 +142,18 @@ describe('SearchCheckListComponent', () => { expect(component.context.filterRawParams[component.id]).toBeUndefined(); }); + it('should have set labelPosition to after for checkboxes', () => { + component.options = new SearchFilterList([ + { name: 'Folder', value: `TYPE:'cm:folder'`, checked: true }, + { name: 'Document', value: `TYPE:'cm:content'`, checked: true } + ]); + + fixture.detectChanges(); + const checkboxes = unitTestingUtils.getAllByDirective(MatCheckbox); + expect(checkboxes.length).toBe(2); + expect(checkboxes.every((checkbox) => checkbox.componentInstance.labelPosition === 'after')).toBeTrue(); + }); + describe('Pagination', () => { it('should show 5 items when pageSize not defined', async () => { component.id = 'checklist'; diff --git a/lib/core/src/lib/testing/unit-testing-utils.ts b/lib/core/src/lib/testing/unit-testing-utils.ts index fa504bf8ee..f12cb502d8 100644 --- a/lib/core/src/lib/testing/unit-testing-utils.ts +++ b/lib/core/src/lib/testing/unit-testing-utils.ts @@ -75,6 +75,10 @@ export class UnitTestingUtils { return this.debugElement.query(By.directive(directive)); } + getAllByDirective(directive: Type): DebugElement[] { + return this.debugElement.queryAll(By.directive(directive)); + } + /** Perform actions */ clickByCSS(selector: string): void {