From 8b4324cfeccea809f1c813ebc3b4ea515df7480d Mon Sep 17 00:00:00 2001 From: Denys Vuika Date: Fri, 27 Feb 2026 12:30:43 +0000 Subject: [PATCH] refactor: simplify panel state management and enhance template syntax in content metadata component - Replaced inline conditional checks with dedicated methods for panel expansion and editing states. - Updated template syntax to improve readability and maintainability using @if syntax. - Removed unused CommonModule import and added AsyncPipe for better performance. --- .../content-metadata.component.html | 362 ++++++++++-------- .../content-metadata.component.ts | 8 +- 2 files changed, 198 insertions(+), 172 deletions(-) diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html index eb174d59d1..a9f5e6714e 100644 --- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html +++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html @@ -1,66 +1,72 @@ -@let isExpandedProperties = (currentPanel.panelTitle === DefaultPanels.PROPERTIES && currentPanel.expanded) ?? false; -@let isExpandedTags = (currentPanel.panelTitle === DefaultPanels.TAGS && currentPanel.expanded) ?? false; -@let isExpandedCategories = (currentPanel.panelTitle === DefaultPanels.CATEGORIES && currentPanel.expanded) ?? false; +@let isExpandedProperties = isPanelExpanded(DefaultPanels.PROPERTIES); +@let isExpandedTags = isPanelExpanded(DefaultPanels.TAGS); +@let isExpandedCategories = isPanelExpanded(DefaultPanels.CATEGORIES); +@let isEditingTags = isPanelEditing(DefaultPanels.TAGS); +@let isEditingCategories = isPanelEditing(DefaultPanels.CATEGORIES); +@let isEditingProperties = isPanelEditing(DefaultPanels.PROPERTIES); - - - + @if (displayDefaultProperties) { + + } + @if (displayTags) { - - + } + @if (isEditingTags) { + + } - - - - + } - + @if (displayCategories) { - - + } + @if (isEditingCategories) { + + } - @if (currentPanel.panelTitle === DefaultPanels.CATEGORIES && editedPanelTitle !== DefaultPanels.CATEGORIES) { + @if (!isEditingCategories) {
@for (category of categories; track category.id) { @@ -180,17 +196,18 @@ {{ 'CATEGORIES_MANAGEMENT.NO_CATEGORIES_ADDED' | translate }}
} -
-
+ } @for (customPanel of customPanels; track customPanel.panelTitle) { @let isExpandedCustomPanel = (currentPanel.panelTitle === customPanel.panelTitle && currentPanel.expanded) ?? false; @@ -232,40 +249,45 @@ [attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.SECTION' | translate: { sectionName: (group.title | translate) }" [class.adf-metadata-properties-header-expanded]="isExpandedGroup"> - - + } + @if (group.editable && isPanelEditing(group.title)) { + + } - + @if (!showGroup(group) && !displayEmpty && group.editable && editedPanelTitle !== group.title) { + + }