inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-6190] prefer-promise-reject-errors rule and fixes (#9021)

Browse Source 
* fix promise rejections

* fix promise errors

* promise error fixes

* fix promise rejections

* [ci:force] fix formatting

* test fixes

* [ci:force] fix tests

* [ci:force] fix tests

* fix incorrect return types

* meaningful errors

* remove useless pipe

* fix accessing private members in the test
This commit is contained in:
Denys Vuika
2023-10-25 12:01:45 +01:00
committed by GitHub
parent 352e0e4933
commit 8bd24dbb7c
18 changed files with 155 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/process-services-cloud/src/lib/form/services/content-cloud-node-selector.service.spec.ts
View File

@@ -99,7 +99,7 @@ describe('ContentCloudNodeSelectorService', () => {
});
it('should return defined alias nodeId if the relative path does not exist', async () => {
getNodeSpy.and.returnValues(Promise.reject('Relative does not exists'), Promise.resolve(aliasNodeResponseBody));
getNodeSpy.and.returnValues(Promise.reject(new Error('Relative does not exists')), Promise.resolve(aliasNodeResponseBody));
const aliasNodeId = await service.getNodeIdFromPath({ alias: 'mock-alias', path: 'mock-relativePath' });
expect(getNodeSpy).toHaveBeenCalledTimes(2);
@@ -114,7 +114,7 @@ describe('ContentCloudNodeSelectorService', () => {
});
it('should return default nodeId if the given folder does not exist', async () => {
getNodeSpy.and.returnValues(Promise.reject('Folder does not exists'), Promise.resolve(aliasNodeResponseBody));
getNodeSpy.and.returnValues(Promise.reject(new Error('Folder does not exists')), Promise.resolve(aliasNodeResponseBody));
const aliasNodeId = await service.getNodeIdFromFolderVariableValue('mock-folder-id', '-my-');
expect(getNodeSpy).toHaveBeenCalledTimes(2);
@@ -136,7 +136,7 @@ describe('ContentCloudNodeSelectorService', () => {
});
it('should show a warning notification if the relative path is invalid/deleted', async () => {
getNodeSpy.and.returnValue(Promise.reject('Relative path does not exists'));
getNodeSpy.and.returnValue(Promise.reject(new Error('Relative path does not exists')));
try {
expect(service.sourceNodeNotFound).toBe(false);
@@ -144,7 +144,7 @@ describe('ContentCloudNodeSelectorService', () => {
await service.getNodeIdFromPath({ alias: 'mock-alias', path: 'mock-relativePath' });
fail('An error should have been thrown');
} catch (error) {
expect(error).toEqual('Relative path does not exists');
expect(error.message).toEqual('Relative path does not exists');
expect(service.sourceNodeNotFound).toBe(true);
}
@@ -155,7 +155,7 @@ describe('ContentCloudNodeSelectorService', () => {
});
it('should show a warning notification if the defined folderVariable value is invalid/deleted', async () => {
getNodeSpy.and.returnValue(Promise.reject('Folder does not exists'));
getNodeSpy.and.returnValue(Promise.reject(new Error('Folder does not exists')));
try {
expect(service.sourceNodeNotFound).toBe(false);
@@ -163,7 +163,7 @@ describe('ContentCloudNodeSelectorService', () => {
await service.getNodeIdFromFolderVariableValue('mock-folder-id', '-my-');
fail('An error should have been thrown');
} catch (error) {
expect(error).toEqual('Folder does not exists');
expect(error.message).toEqual('Folder does not exists');
expect(service.sourceNodeNotFound).toBe(true);
}