inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[ADF-4861] Fix memory leak in Date widgets and Form Cloud Model (#5041)" (#5279)

Browse Source 
This reverts commit 2def8d0557.
This commit is contained in:
Denys Vuika
2019-11-22 14:03:49 +00:00
committed by GitHub
parent 1de2ff0cc9
commit 8e6e755ed1
7 changed files with 56 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/core/form/components/widgets/core/form-field.model.ts
View File

@@ -83,8 +83,8 @@ export class FormFieldModel extends FormWidgetModel {
return this._value;
}
set value(value: any) {
this._value = value;
set value(v: any) {
this._value = v;
this.updateForm();
}

17
lib/core/form/components/widgets/date-time/date-time.widget.spec.ts
View File

@@ -87,6 +87,23 @@ describe('DateTimeWidgetComponent', () => {
expect(widget.maxDate.isSame(expected)).toBeTruthy();
});
it('should eval visibility on date changed', () => {
spyOn(widget, 'onFieldChanged').and.callThrough();
const field = new FormFieldModel(new FormModel(), {
id: 'date-field-id',
name: 'date-name',
value: '09-12-9999 10:00 AM',
type: 'datetime',
readOnly: 'false'
});
widget.field = field;
widget.onDateChanged({ value: moment('1982-03-13T10:00:000Z') });
expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
});
describe('template check', () => {
it('should show visible date widget', async(() => {

1
lib/core/form/components/widgets/date-time/date-time.widget.ts
View File

@@ -94,6 +94,7 @@ export class DateTimeWidgetComponent extends WidgetComponent implements OnInit,
} else {
this.field.value = null;
}
this.onFieldChanged(this.field);
}
}

17
lib/core/form/components/widgets/date/date.widget.spec.ts
View File

@@ -81,6 +81,23 @@ describe('DateWidgetComponent', () => {
expect(widget.maxDate.isSame(expected)).toBeTruthy();
});
it('should eval visibility on date changed', () => {
spyOn(widget, 'onFieldChanged').and.callThrough();
const field = new FormFieldModel(new FormModel(), {
id: 'date-field-id',
name: 'date-name',
value: '9-9-9999',
type: 'date',
readOnly: 'false'
});
widget.field = field;
widget.onDateChanged({ value: moment('12/12/2012') });
expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
});
describe('template check', () => {
afterEach(() => {

1
lib/core/form/components/widgets/date/date.widget.ts
View File

@@ -89,5 +89,6 @@ export class DateWidgetComponent extends WidgetComponent implements OnInit, OnDe
} else {
this.field.value = null;
}
this.onFieldChanged(this.field);
}
}