Revert "[ADF-4861] Fix memory leak in Date widgets and Form Cloud Model (#5041)" (#5279)

This reverts commit 2def8d0557.

lib/core/form/components/widgets/core/form-field.model.ts

@@ -83,8 +83,8 @@ export class FormFieldModel extends FormWidgetModel {
         return this._value;
     }
 
-    set value(value: any) {
+    set value(v: any) {
-        this._value = value;
+        this._value = v;
         this.updateForm();
     }
 

lib/core/form/components/widgets/date-time/date-time.widget.spec.ts

@@ -87,6 +87,23 @@ describe('DateTimeWidgetComponent', () => {
         expect(widget.maxDate.isSame(expected)).toBeTruthy();
     });
 
+    it('should eval visibility on date changed', () => {
+        spyOn(widget, 'onFieldChanged').and.callThrough();
+
+        const field = new FormFieldModel(new FormModel(), {
+            id: 'date-field-id',
+            name: 'date-name',
+            value: '09-12-9999 10:00 AM',
+            type: 'datetime',
+            readOnly: 'false'
+        });
+
+        widget.field = field;
+
+        widget.onDateChanged({ value: moment('1982-03-13T10:00:000Z') });
+        expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
+    });
+
     describe('template check', () => {
 
         it('should show visible date widget', async(() => {

lib/core/form/components/widgets/date-time/date-time.widget.ts

@@ -94,6 +94,7 @@ export class DateTimeWidgetComponent extends WidgetComponent implements OnInit,
         } else {
             this.field.value = null;
         }
+        this.onFieldChanged(this.field);
     }
 
 }

lib/core/form/components/widgets/date/date.widget.spec.ts

@@ -81,6 +81,23 @@ describe('DateWidgetComponent', () => {
         expect(widget.maxDate.isSame(expected)).toBeTruthy();
     });
 
+    it('should eval visibility on date changed', () => {
+        spyOn(widget, 'onFieldChanged').and.callThrough();
+
+        const field = new FormFieldModel(new FormModel(), {
+            id: 'date-field-id',
+            name: 'date-name',
+            value: '9-9-9999',
+            type: 'date',
+            readOnly: 'false'
+        });
+
+        widget.field = field;
+
+        widget.onDateChanged({ value: moment('12/12/2012') });
+        expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
+    });
+
     describe('template check', () => {
 
         afterEach(() => {

lib/core/form/components/widgets/date/date.widget.ts

@@ -89,5 +89,6 @@ export class DateWidgetComponent extends WidgetComponent implements OnInit, OnDe
         } else {
             this.field.value = null;
         }
+        this.onFieldChanged(this.field);
     }
 }

lib/process-services-cloud/src/lib/form/components/date-cloud/date-cloud.widget.spec.ts

@@ -80,6 +80,23 @@ describe('DateWidgetComponent', () => {
         expect(widget.maxDate.isSame(expected)).toBeTruthy();
     });
 
+    it('should eval visibility on date changed', () => {
+        spyOn(widget, 'onFieldChanged').and.callThrough();
+
+        const field = new FormFieldModel(new FormModel(), {
+            id: 'date-field-id',
+            name: 'date-name',
+            value: '9999-9-9',
+            type: 'date',
+            readOnly: 'false'
+        });
+
+        widget.field = field;
+
+        widget.onDateChanged({ value: moment('12/12/2012') });
+        expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
+    });
+
     describe('template check', () => {
 
         afterEach(() => {

lib/process-services-cloud/src/lib/form/components/date-cloud/date-cloud.widget.ts

@@ -86,5 +86,6 @@ export class DateCloudWidgetComponent extends WidgetComponent implements OnInit,
         } else {
             this.field.value = null;
         }
+        this.onFieldChanged(this.field);
     }
 }