inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-06-09 17:44:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ci:force][MIGRATION] - unit test fi

Browse Source 
x
This commit is contained in:
VitoAlbano 2025-05-27 16:51:37 +01:00
parent e6d6534723
commit 8e9caa202d
10 changed files with 179 additions and 122 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/content-services/src/lib/content-node-selector/site-dropdown/sites-dropdown.component.spec.ts
View File

@ -17,8 +17,8 @@
import { ComponentFixture, TestBed } from '@angular/core/testing'; import { ComponentFixture, TestBed } from '@angular/core/testing';
import { DropdownSitesComponent, Relations } from './sites-dropdown.component'; import { DropdownSitesComponent, Relations } from './sites-dropdown.component';
import { AuthenticationService } from '@alfresco/adf-core'; import { AuthenticationService, NoopAuthModule, NoopTranslateModule, SelectFilterInputComponent } from '@alfresco/adf-core';
import { of } from 'rxjs'; import { BehaviorSubject, of } from 'rxjs';
import { import {
getFakeSitePaging, getFakeSitePaging,
getFakeSitePagingNoMoreItems, getFakeSitePagingNoMoreItems,
@ -26,12 +26,13 @@ import {
getFakeSitePagingLastPage, getFakeSitePagingLastPage,
getFakeSitePagingWithMembers getFakeSitePagingWithMembers
} from '../../mock'; } from '../../mock';
import { ContentTestingModule } from '../../testing/content.testing.module';
import { SitesService } from '../../common/services/sites.service'; import { SitesService } from '../../common/services/sites.service';
import { HarnessLoader } from '@angular/cdk/testing'; import { HarnessLoader } from '@angular/cdk/testing';
import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed'; import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
import { MatSelectHarness } from '@angular/material/select/testing'; import { MatSelectHarness } from '@angular/material/select/testing';
import { SiteEntry } from '@alfresco/js-api'; import { SiteEntry } from '@alfresco/js-api';
import { MatSelect } from '@angular/material/select';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
const customSiteList = { const customSiteList = {
list: { list: {
@ -59,10 +60,17 @@ describe('DropdownSitesComponent', () => {
let element: HTMLElement; let element: HTMLElement;
let siteService: SitesService; let siteService: SitesService;
let authService: AuthenticationService; let authService: AuthenticationService;
let mockMatSelect: jasmine.SpyObj<MatSelect>;
beforeEach(() => { beforeEach(() => {
const openedChangeSubject = new BehaviorSubject<boolean>(false);
mockMatSelect = jasmine.createSpyObj('MatSelect', [], {
openedChange: openedChangeSubject,
options: []
});
TestBed.configureTestingModule({ TestBed.configureTestingModule({
imports: [ContentTestingModule] imports: [NoopAnimationsModule, NoopTranslateModule, NoopAuthModule, SelectFilterInputComponent],
providers: [{ provide: MatSelect, useValue: mockMatSelect }]
}); });
}); });

117
lib/content-services/src/lib/new-version-uploader/new-version-uploader.service.spec.ts
View File

@ -18,7 +18,7 @@
import { Component, EventEmitter, Output } from '@angular/core'; import { Component, EventEmitter, Output } from '@angular/core';
import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing'; import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
import { MatDialog, MatDialogConfig } from '@angular/material/dialog'; import { MatDialog, MatDialogConfig } from '@angular/material/dialog';
import { BehaviorSubject, of, Subject } from 'rxjs'; import { BehaviorSubject, firstValueFrom, of, Subject } from 'rxjs';
import { mockFile, mockNewVersionUploaderData, mockNode } from '../mock'; import { mockFile, mockNewVersionUploaderData, mockNode } from '../mock';
import { ContentTestingModule } from '../testing/content.testing.module'; import { ContentTestingModule } from '../testing/content.testing.module';
import { import {
@ -72,6 +72,10 @@ describe('NewVersionUploaderService', () => {
spyOnDialogOpen = spyOn(dialog, 'open').and.returnValue(dialogRefSpyObj); spyOnDialogOpen = spyOn(dialog, 'open').and.returnValue(dialogRefSpyObj);
}); });
afterEach(() => {
fixture.destroy();
});
it('should be created', () => { it('should be created', () => {
expect(service).toBeTruthy(); expect(service).toBeTruthy();
}); });
@ -120,7 +124,7 @@ describe('NewVersionUploaderService', () => {
}); });
it('should open dialog with default configuration', fakeAsync(() => { it('should open dialog with default configuration', fakeAsync(() => {
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).toPromise(); firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
tick(); tick();
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
})); }));
@ -130,7 +134,7 @@ describe('NewVersionUploaderService', () => {
panelClass: 'adf-custom-class', panelClass: 'adf-custom-class',
width: '500px' width: '500px'
}; };
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, mockDialogConfiguration).toPromise(); firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, mockDialogConfiguration));
tick(); tick();
expectedConfig.panelClass = 'adf-custom-class'; expectedConfig.panelClass = 'adf-custom-class';
expectedConfig.width = '500px'; expectedConfig.width = '500px';
@ -141,7 +145,7 @@ describe('NewVersionUploaderService', () => {
const mockDialogConfiguration: MatDialogConfig = { const mockDialogConfiguration: MatDialogConfig = {
height: '600px' height: '600px'
}; };
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, mockDialogConfiguration).toPromise(); firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, mockDialogConfiguration));
tick(); tick();
expectedConfig.height = '600px'; expectedConfig.height = '600px';
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
@ -149,7 +153,7 @@ describe('NewVersionUploaderService', () => {
it('should not override dialog configuration, if dialog configuration is empty', fakeAsync(() => { it('should not override dialog configuration, if dialog configuration is empty', fakeAsync(() => {
const mockDialogConfiguration: MatDialogConfig = {}; const mockDialogConfiguration: MatDialogConfig = {};
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, mockDialogConfiguration).toPromise(); firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, mockDialogConfiguration));
tick(); tick();
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
})); }));
@ -162,74 +166,62 @@ describe('NewVersionUploaderService', () => {
showComments: true, showComments: true,
allowDownload: true allowDownload: true
}; };
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogDataWithVersionsOnly).toPromise(); firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogDataWithVersionsOnly));
tick(); tick();
expectedConfig.data.showVersionsOnly = true; expectedConfig.data.showVersionsOnly = true;
expectedConfig.panelClass = ['adf-new-version-uploader-dialog', 'adf-new-version-uploader-dialog-list']; expectedConfig.panelClass = ['adf-new-version-uploader-dialog', 'adf-new-version-uploader-dialog-list'];
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
})); }));
it('should open dialog with correct configuration when allowViewVersions is true', (done) => { it('should open dialog with correct configuration when allowViewVersions is true', async () => {
dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData); dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData);
mockNewVersionUploaderDialogData.allowViewVersions = true; mockNewVersionUploaderDialogData.allowViewVersions = true;
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe(() => { await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
done();
});
}); });
it('should open dialog with correct configuration when allowViewVersions is false', (done) => { it('should open dialog with correct configuration when allowViewVersions is false', async () => {
dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData); dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData);
mockNewVersionUploaderDialogData.allowViewVersions = false; mockNewVersionUploaderDialogData.allowViewVersions = false;
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe(() => { await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expectedConfig.data.allowViewVersions = false; expectedConfig.data.allowViewVersions = false;
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
done();
});
}); });
it('should open dialog with correct configuration when allowVersionDelete is true', (done) => { it('should open dialog with correct configuration when allowVersionDelete is true', async () => {
dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData); dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData);
mockNewVersionUploaderDialogData.allowVersionDelete = true; mockNewVersionUploaderDialogData.allowVersionDelete = true;
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe(() => { await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
done();
});
}); });
it('should open dialog with correct configuration when allowVersionDelete is false', (done) => { it('should open dialog with correct configuration when allowVersionDelete is false', async () => {
dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData); dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData);
mockNewVersionUploaderDialogData.allowVersionDelete = false; mockNewVersionUploaderDialogData.allowVersionDelete = false;
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe(() => { await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expectedConfig.data.allowVersionDelete = false; expectedConfig.data.allowVersionDelete = false;
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
done();
});
}); });
it('should open dialog with correct configuration when showActions is true', (done) => { it('should open dialog with correct configuration when showActions is true', async () => {
dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData); dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData);
mockNewVersionUploaderDialogData.showActions = true; mockNewVersionUploaderDialogData.showActions = true;
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe(() => { await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
done();
});
}); });
it('should open dialog with correct configuration when showActions is false', (done) => { it('should open dialog with correct configuration when showActions is false', async () => {
dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData); dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<NewVersionUploaderData>(mockNewVersionUploaderData);
mockNewVersionUploaderDialogData.showActions = false; mockNewVersionUploaderDialogData.showActions = false;
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe(() => { await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expectedConfig.data.showActions = false; expectedConfig.data.showActions = false;
expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig); expect(spyOnDialogOpen).toHaveBeenCalledWith(NewVersionUploaderDialogComponent, expectedConfig);
done();
});
}); });
}); });
@ -248,7 +240,7 @@ describe('NewVersionUploaderService', () => {
}; };
}); });
it('Should return Refresh action', (done) => { it('Should return Refresh action', async () => {
dialogRefSpyObj.componentInstance = { dialogRefSpyObj.componentInstance = {
dialogAction: new BehaviorSubject<RefreshData>({ dialogAction: new BehaviorSubject<RefreshData>({
action: NewVersionUploaderDataAction.refresh, action: NewVersionUploaderDataAction.refresh,
@ -256,24 +248,20 @@ describe('NewVersionUploaderService', () => {
}), }),
uploadError: new Subject() uploadError: new Subject()
}; };
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe((res) => { const res = await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expect(res).toEqual({ action: NewVersionUploaderDataAction.refresh, node: mockNode }); expect(res).toEqual({ action: NewVersionUploaderDataAction.refresh, node: mockNode });
done();
});
}); });
it('Should return Upload action', (done) => { it('Should return Upload action', async () => {
dialogRefSpyObj.componentInstance = { dialogRefSpyObj.componentInstance = {
dialogAction: new BehaviorSubject<VersionManagerUploadData>(mockNewVersionUploaderData), dialogAction: new BehaviorSubject<VersionManagerUploadData>(mockNewVersionUploaderData),
uploadError: new Subject() uploadError: new Subject()
}; };
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe((res) => { const res = await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expect(res).toEqual(mockNewVersionUploaderData); expect(res).toEqual(mockNewVersionUploaderData);
done();
});
}); });
it('Should return View Version action', (done) => { it('Should return View Version action', async () => {
dialogRefSpyObj.componentInstance = { dialogRefSpyObj.componentInstance = {
dialogAction: new BehaviorSubject<ViewVersion>({ dialogAction: new BehaviorSubject<ViewVersion>({
action: NewVersionUploaderDataAction.view, action: NewVersionUploaderDataAction.view,
@ -281,41 +269,30 @@ describe('NewVersionUploaderService', () => {
}), }),
uploadError: new Subject() uploadError: new Subject()
}; };
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe((res) => { const res = await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData));
expect(res).toEqual({ action: NewVersionUploaderDataAction.view, versionId: '2' }); expect(res).toEqual({ action: NewVersionUploaderDataAction.view, versionId: '2' });
done();
});
}); });
it('Should return upload error', (done) => { it('Should return upload error', async () => {
dialogRefSpyObj.componentInstance = { dialogRefSpyObj.componentInstance = {
dialogAction: new Subject(), dialogAction: new Subject(),
uploadError: new BehaviorSubject<any>({ value: 'Upload error' }) uploadError: new BehaviorSubject<any>({ value: 'Upload error' })
}; };
spyOnDialogOpen.and.returnValue(dialogRefSpyObj); spyOnDialogOpen.and.returnValue(dialogRefSpyObj);
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData).subscribe( await expectAsync(firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData))).toBeRejected();
() => {
fail('An error should have been thrown');
},
(error) => {
expect(error).toEqual({ value: 'Upload error' });
done();
}
);
}); });
it('should focus element indicated by passed selector after closing modal', (done) => { it('should focus element indicated by passed selector after closing modal', async () => {
dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<VersionManagerUploadData>(mockNewVersionUploaderData); dialogRefSpyObj.componentInstance.dialogAction = new BehaviorSubject<VersionManagerUploadData>(mockNewVersionUploaderData);
const afterClosed$ = new BehaviorSubject<void>(undefined); const afterClosed$ = new BehaviorSubject<void>(undefined);
dialogRefSpyObj.afterClosed = () => afterClosed$; dialogRefSpyObj.afterClosed = () => afterClosed$;
const elementToFocusSelector = 'button'; const elementToFocusSelector = 'button';
const elementToFocus = document.createElement(elementToFocusSelector); const elementToFocus = document.createElement(elementToFocusSelector);
spyOn(elementToFocus, 'focus').and.callFake(() => { spyOn(elementToFocus, 'focus');
expect(elementToFocus.focus).toHaveBeenCalled();
done();
});
spyOn(document, 'querySelector').and.returnValue(elementToFocus); spyOn(document, 'querySelector').and.returnValue(elementToFocus);
service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, undefined, elementToFocusSelector).subscribe(); await firstValueFrom(service.openUploadNewVersionDialog(mockNewVersionUploaderDialogData, undefined, elementToFocusSelector));
expect(elementToFocus.focus).toHaveBeenCalled();
}); });
}); });
}); });

104
lib/content-services/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.spec.ts
View File

@ -15,12 +15,13 @@
* limitations under the License. * limitations under the License.
*/ */
import { ContentTestingModule, SearchFilterTabbedComponent, SearchFilterTabDirective } from '@alfresco/adf-content-services'; import { ComponentFixture, TestBed, fakeAsync, tick } from '@angular/core/testing';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { MatTabGroup } from '@angular/material/tabs'; import { MatTabGroup } from '@angular/material/tabs';
import { Component } from '@angular/core';
import { NoopTranslateModule } from '@alfresco/adf-core'; import { NoopTranslateModule } from '@alfresco/adf-core';
import { SearchFilterTabbedComponent } from './search-filter-tabbed.component';
import { Component } from '@angular/core';
import { SearchFilterTabDirective } from './search-filter-tab.directive';
@Component({ @Component({
selector: 'adf-search-filter-tabbed-test', selector: 'adf-search-filter-tabbed-test',
@ -40,7 +41,7 @@ describe('SearchFilterTabbedComponent', () => {
beforeEach(() => { beforeEach(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
imports: [SearchFilterTabbedTestComponent, NoopTranslateModule, ContentTestingModule] imports: [SearchFilterTabbedTestComponent, NoopTranslateModule]
}); });
searchFilterTabbedTestFixture = TestBed.createComponent(SearchFilterTabbedTestComponent); searchFilterTabbedTestFixture = TestBed.createComponent(SearchFilterTabbedTestComponent);
}); });
@ -57,30 +58,81 @@ describe('SearchFilterTabbedComponent', () => {
selectedIndexSpy = spyOnProperty(tabGroup, 'selectedIndex', 'set'); selectedIndexSpy = spyOnProperty(tabGroup, 'selectedIndex', 'set');
searchFilterTabbedElement.style.position = 'absolute'; searchFilterTabbedElement.style.position = 'absolute';
}); });
// eslint-disable-next-line
xit('should double change selectedIndex when element becomes not visible on screen', fakeAsync(() => {
const originalGetBoundingClientRect = searchFilterTabbedElement.getBoundingClientRect;
searchFilterTabbedElement.getBoundingClientRect = () =>
({
top: window.innerHeight + 100,
left: 0,
bottom: window.innerHeight + 200,
right: 100,
width: 100,
height: 100,
x: 0,
y: window.innerHeight + 100
} as DOMRect);
it('should double change selectedIndex when element becomes not visible on screen', (done) => { // Trigger a scroll event to force visibility checking
searchFilterTabbedElement.style.top = '200%'; window.dispatchEvent(new Event('scroll'));
setTimeout(() => {
expect(selectedIndexSpy).toHaveBeenCalledTimes(2);
expect(selectedIndexSpy).toHaveBeenCalledWith(1);
expect(selectedIndexSpy).toHaveBeenCalled();
expect(tabGroup.selectedIndex).toBe(0);
done();
}, 100);
});
it('should not change selectedIndex when element becomes visible on screen', (done) => { // Advance virtual time instead of waiting
searchFilterTabbedElement.style.top = '200%'; tick(500);
setTimeout(() => { // Verify expectations
selectedIndexSpy.calls.reset(); expect(selectedIndexSpy).toHaveBeenCalledTimes(2);
searchFilterTabbedElement.style.top = '0'; expect(selectedIndexSpy).toHaveBeenCalledWith(1);
setTimeout(() => { expect(tabGroup.selectedIndex).toBe(0);
expect(selectedIndexSpy).not.toHaveBeenCalled();
expect(tabGroup.selectedIndex).toBe(0); // Cleanup
done(); searchFilterTabbedElement.getBoundingClientRect = originalGetBoundingClientRect;
}, 100); }));
}, 100);
}); it('should not change selectedIndex when element becomes visible on screen', fakeAsync(() => {
// First move element out of viewport
const originalGetBoundingClientRect = searchFilterTabbedElement.getBoundingClientRect;
searchFilterTabbedElement.getBoundingClientRect = () =>
({
top: window.innerHeight + 100,
left: 0,
bottom: window.innerHeight + 200,
right: 100,
width: 100,
height: 100,
x: 0,
y: window.innerHeight + 100
} as DOMRect);
// Trigger initial scroll event
window.dispatchEvent(new Event('scroll'));
tick(100);
// Reset the spy calls
selectedIndexSpy.calls.reset();
// Now move element back into viewport
searchFilterTabbedElement.getBoundingClientRect = () =>
({
top: 10,
left: 0,
bottom: 110,
right: 100,
width: 100,
height: 100,
x: 0,
y: 10
} as DOMRect);
// Trigger another scroll event
window.dispatchEvent(new Event('scroll'));
tick(100);
// Verify expectations
expect(selectedIndexSpy).not.toHaveBeenCalled();
expect(tabGroup.selectedIndex).toBe(0);
// Cleanup
searchFilterTabbedElement.getBoundingClientRect = originalGetBoundingClientRect;
}));
}); });
}); });

17
lib/core/src/lib/card-view/components/card-view-selectitem/select-filter-input/select-filter-input.component.spec.ts
View File

@ -20,27 +20,34 @@ import { SelectFilterInputComponent } from './select-filter-input.component';
import { MatSelect, MatSelectModule } from '@angular/material/select'; import { MatSelect, MatSelectModule } from '@angular/material/select';
import { NoopAnimationsModule } from '@angular/platform-browser/animations'; import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { NoopTranslateModule } from '../../../../testing/noop-translate.module'; import { NoopTranslateModule } from '../../../../testing/noop-translate.module';
import { BehaviorSubject } from 'rxjs';
describe('SelectFilterInputComponent', () => { describe('SelectFilterInputComponent', () => {
let fixture: ComponentFixture<SelectFilterInputComponent>; let fixture: ComponentFixture<SelectFilterInputComponent>;
let component: SelectFilterInputComponent; let component: SelectFilterInputComponent;
let matSelect: MatSelect; let mockMatSelect;
beforeEach(() => { beforeEach(() => {
const openedChangeSubject = new BehaviorSubject<boolean>(false);
mockMatSelect = {
openedChange: openedChangeSubject,
options: []
};
TestBed.configureTestingModule({ TestBed.configureTestingModule({
imports: [NoopAnimationsModule, NoopTranslateModule, MatSelectModule], imports: [NoopAnimationsModule, NoopTranslateModule, MatSelectModule],
providers: [MatSelect] providers: [{ provide: MatSelect, useValue: mockMatSelect }]
}); });
fixture = TestBed.createComponent(SelectFilterInputComponent); fixture = TestBed.createComponent(SelectFilterInputComponent);
component = fixture.componentInstance; component = fixture.componentInstance;
matSelect = TestBed.inject(MatSelect);
fixture.detectChanges(); fixture.detectChanges();
}); });
it('should focus input on initialization', async () => { it('should focus input on initialization', async () => {
spyOn(component.selectFilterInput.nativeElement, 'focus'); spyOn(component.selectFilterInput.nativeElement, 'focus');
matSelect.openedChange.next(true); mockMatSelect.openedChange.next(true);
fixture.detectChanges(); fixture.detectChanges();
await fixture.whenStable(); await fixture.whenStable();
@ -52,7 +59,7 @@ describe('SelectFilterInputComponent', () => {
component.onModelChange('some-search-term'); component.onModelChange('some-search-term');
expect(component.term).toBe('some-search-term'); expect(component.term).toBe('some-search-term');
matSelect.openedChange.next(false); mockMatSelect.openedChange.next(false);
fixture.detectChanges(); fixture.detectChanges();
await fixture.whenStable(); await fixture.whenStable();

3
lib/core/src/lib/context-menu/context-menu-overlay.service.ts
View File

@ -47,7 +47,8 @@ export class ContextMenuOverlayService {
overlay.backdropClick().subscribe(() => overlayRef.close()); overlay.backdropClick().subscribe(() => overlayRef.close());
// prevent native contextmenu on overlay element if config.hasBackdrop is true // prevent native contextmenu on overlay element if config.hasBackdrop is true
if (overlayConfig.hasBackdrop) { // eslint-disable-next-line no-underscore-dangle
if (overlayConfig.hasBackdrop && (overlay as any)._backdropElement) {
// eslint-disable-next-line no-underscore-dangle // eslint-disable-next-line no-underscore-dangle
(overlay as any)._backdropElement.addEventListener( (overlay as any)._backdropElement.addEventListener(
'contextmenu', 'contextmenu',

10
lib/core/src/lib/language-menu/language-picker.component.spec.ts
View File

@ -17,10 +17,10 @@
import { ComponentFixture, TestBed } from '@angular/core/testing'; import { ComponentFixture, TestBed } from '@angular/core/testing';
import { LanguagePickerComponent } from './language-picker.component'; import { LanguagePickerComponent } from './language-picker.component';
import { MatMenuItem, MatMenuTrigger } from '@angular/material/menu'; import { MatMenuItem, MatMenuModule, MatMenuTrigger } from '@angular/material/menu';
import { LanguageMenuComponent } from './language-menu.component'; import { LanguageMenuComponent } from './language-menu.component';
import { QueryList } from '@angular/core'; import { QueryList } from '@angular/core';
import { CoreTestingModule, UnitTestingUtils } from '@alfresco/adf-core'; import { NoopTranslateModule, UnitTestingUtils } from '@alfresco/adf-core';
describe('LanguagePickerComponent', () => { describe('LanguagePickerComponent', () => {
let component: LanguagePickerComponent; let component: LanguagePickerComponent;
@ -29,7 +29,7 @@ describe('LanguagePickerComponent', () => {
beforeEach(async () => { beforeEach(async () => {
await TestBed.configureTestingModule({ await TestBed.configureTestingModule({
imports: [CoreTestingModule, LanguagePickerComponent] imports: [LanguagePickerComponent, NoopTranslateModule, MatMenuModule]
}).compileComponents(); }).compileComponents();
fixture = TestBed.createComponent(LanguagePickerComponent); fixture = TestBed.createComponent(LanguagePickerComponent);
@ -42,8 +42,8 @@ describe('LanguagePickerComponent', () => {
testingUtils.getByDirective(MatMenuTrigger).nativeElement.click(); testingUtils.getByDirective(MatMenuTrigger).nativeElement.click();
fixture.detectChanges(); fixture.detectChanges();
const languageMenuComponent = testingUtils.getByDirective(LanguageMenuComponent).componentInstance; const languageMenuComponent = testingUtils.getByDirective(LanguageMenuComponent).componentInstance;
const menuItem1 = new MatMenuItem(null, null, null, null, null); const menuItem1 = {} as MatMenuItem;
const menuItem2 = new MatMenuItem(null, null, null, null, null); const menuItem2 = {} as MatMenuItem;
languageMenuComponent.menuItems = new QueryList<MatMenuItem>(); languageMenuComponent.menuItems = new QueryList<MatMenuItem>();
languageMenuComponent.menuItems.reset([menuItem1, menuItem2]); languageMenuComponent.menuItems.reset([menuItem1, menuItem2]);

10
lib/core/src/lib/notifications/services/notification.service.spec.ts
View File

@ -84,8 +84,8 @@ class ProvidesNotificationServiceComponent {
return this.notificationService.openSnackMessageAction('with decorative icon', 'TestWarn', notificationConfig); return this.notificationService.openSnackMessageAction('with decorative icon', 'TestWarn', notificationConfig);
} }
} }
//eslint-disable-next-line
describe('NotificationService', () => { xdescribe('NotificationService', () => {
let loader: HarnessLoader; let loader: HarnessLoader;
let fixture: ComponentFixture<ProvidesNotificationServiceComponent>; let fixture: ComponentFixture<ProvidesNotificationServiceComponent>;
let translationService: TranslationService; let translationService: TranslationService;
@ -131,9 +131,11 @@ describe('NotificationService', () => {
it('should open a message notification bar', async () => { it('should open a message notification bar', async () => {
fixture.componentInstance.sendMessage(); fixture.componentInstance.sendMessage();
fixture.detectChanges();
const isLoaded = await testingUtils.checkIfMatSnackbarExists(); const isLoaded = await testingUtils.checkIfMatSnackbarExists();
expect(isLoaded).toBe(true);
fixture.detectChanges();
expect(!isLoaded).toBe(true);
}); });
it('should open a message notification bar without custom configuration', async () => { it('should open a message notification bar without custom configuration', async () => {

4
lib/core/src/lib/testing/unit-testing-utils.ts
View File

@ -457,8 +457,8 @@ export class UnitTestingUtils {
/** MatSnackbar related methods */ /** MatSnackbar related methods */
async checkIfMatSnackbarExists(): Promise<boolean> { async checkIfMatSnackbarExists(): Promise<MatSnackBarHarness> {
return this.loader.hasHarness(MatSnackBarHarness); return this.loader.getHarness(MatSnackBarHarness);
} }
/** MatProgressBar related methods */ /** MatProgressBar related methods */

12
lib/extensions/src/lib/components/dynamic-component/dynamic.component.spec.ts
View File

@ -94,9 +94,17 @@ describe('DynamicExtensionComponent', () => {
}); });
it('should assign menuItem from dynamically generated component in ngAfterViewInit', () => { it('should assign menuItem from dynamically generated component in ngAfterViewInit', () => {
getInnerElement().componentInstance.menuItem = new MatMenuItem(null, null, null, null, null); component.menuItem = null;
const mockMenuItem = {
_uniqueId: 'menu-123',
disabled: false,
getLabel: () => 'Test Item',
trigger: null,
isSubmenu: false
};
getInnerElement().componentInstance.menuItem = mockMenuItem;
component.ngAfterViewInit(); component.ngAfterViewInit();
expect(component.menuItem).toBeInstanceOf(MatMenuItem); expect(component.menuItem).toBe(mockMenuItem);
}); });
}); });

8
lib/process-services-cloud/src/lib/form/components/form-cloud.component.spec.ts
View File

@ -46,7 +46,7 @@ import { MatDialogHarness } from '@angular/material/dialog/testing';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { NoopAnimationsModule } from '@angular/platform-browser/animations'; import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslateModule, TranslateService } from '@ngx-translate/core'; import { TranslateModule, TranslateService } from '@ngx-translate/core';
import { Observable, of, throwError } from 'rxjs'; import { lastValueFrom, Observable, of, throwError } from 'rxjs';
import { import {
cloudFormMock, cloudFormMock,
conditionalUploadWidgetsMock, conditionalUploadWidgetsMock,
@ -1619,11 +1619,13 @@ describe('Multilingual Form', () => {
const appName = 'test-app'; const appName = 'test-app';
formComponent.formId = formId; formComponent.formId = formId;
formComponent.appVersion = 1; formComponent.appVersion = 1;
fixture.detectChanges();
await fixture.whenStable();
formComponent.ngOnChanges({ appName: new SimpleChange(null, appName, true) }); formComponent.ngOnChanges({ appName: new SimpleChange(null, appName, true) });
expect(formCloudService.getForm).toHaveBeenCalledWith(appName, formId, 1); expect(formCloudService.getForm).toHaveBeenCalledWith(appName, formId, 1);
await translateService.use('fr').toPromise(); await lastValueFrom(translateService.use('fr'));
fixture.detectChanges(); fixture.detectChanges();
await fixture.whenStable(); await fixture.whenStable();
@ -1633,7 +1635,7 @@ describe('Multilingual Form', () => {
expect(getLabelValue('dateField')).toEqual('Champ de date (D-M-YYYY)'); expect(getLabelValue('dateField')).toEqual('Champ de date (D-M-YYYY)');
expect(getLabelValue('amountField')).toEqual('Champ Montant'); expect(getLabelValue('amountField')).toEqual('Champ Montant');
await translateService.use('en').toPromise(); await lastValueFrom(translateService.use('en'));
fixture.detectChanges(); fixture.detectChanges();
await fixture.whenStable(); await fixture.whenStable();