Fix tslint errors (#2097)

This commit is contained in:
Maurizio Vitale 2017-07-18 15:12:16 +01:00 committed by Eugenio Romano
parent 34c89bd2ba
commit 9113170f2c
14 changed files with 33 additions and 32 deletions

View File

@ -39,7 +39,8 @@ module.exports = {
loader: 'tslint-loader', loader: 'tslint-loader',
options: { options: {
emitErrors: true, emitErrors: true,
failOnHint: true failOnHint: true,
fix: true
}, },
exclude: [/node_modules/, /bundles/, /dist/, /demo/] exclude: [/node_modules/, /bundles/, /dist/, /demo/]
}, },

View File

@ -46,7 +46,7 @@ describe('CardViewDateItemComponent', () => {
beforeEach(() => { beforeEach(() => {
fixture = TestBed.createComponent(CardViewDateItemComponent); fixture = TestBed.createComponent(CardViewDateItemComponent);
component = fixture.componentInstance; component = fixture.componentInstance;
component.property = <CardViewDateItemModel>{ component.property = <CardViewDateItemModel> {
type: 'date', type: 'date',
label: 'Date label', label: 'Date label',
value: new Date('07/10/2017'), value: new Date('07/10/2017'),

View File

@ -62,7 +62,7 @@ describe('CardViewItemDispatcherComponent', () => {
beforeEach(() => { beforeEach(() => {
fixture = TestBed.createComponent(CardViewItemDispatcherComponent); fixture = TestBed.createComponent(CardViewItemDispatcherComponent);
component = fixture.componentInstance; component = fixture.componentInstance;
component.property = <CardViewItem>{ component.property = <CardViewItem> {
type: 'shiny-custom-element', type: 'shiny-custom-element',
label: 'Shiny custom element', label: 'Shiny custom element',
value: null, value: null,

View File

@ -51,7 +51,7 @@ describe('CardViewTextItemComponent', () => {
beforeEach(() => { beforeEach(() => {
fixture = TestBed.createComponent(CardViewTextItemComponent); fixture = TestBed.createComponent(CardViewTextItemComponent);
component = fixture.componentInstance; component = fixture.componentInstance;
component.property = <CardViewTextItemModel>{ component.property = <CardViewTextItemModel> {
type: 'text', type: 'text',
label: 'Text label', label: 'Text label',
value: 'Lorem ipsum', value: 'Lorem ipsum',

View File

@ -89,21 +89,21 @@ describe('UploadDirective', () => {
it('should prevent default event on drop', () => { it('should prevent default event on drop', () => {
directive.enabled = true; directive.enabled = true;
let event = jasmine.createSpyObj('event', ['preventDefault', 'stopPropagation']); let event = jasmine.createSpyObj('event', ['preventDefault', 'stopPropagation']);
directive.onDrop(<DragEvent>event); directive.onDrop(<DragEvent> event);
expect(event.preventDefault).toHaveBeenCalled(); expect(event.preventDefault).toHaveBeenCalled();
}); });
it('should stop default event propagation on drop', () => { it('should stop default event propagation on drop', () => {
directive.enabled = true; directive.enabled = true;
let event = jasmine.createSpyObj('event', ['preventDefault', 'stopPropagation']); let event = jasmine.createSpyObj('event', ['preventDefault', 'stopPropagation']);
directive.onDrop(<DragEvent>event); directive.onDrop(<DragEvent> event);
expect(event.stopPropagation).toHaveBeenCalled(); expect(event.stopPropagation).toHaveBeenCalled();
}); });
it('should not prevent default event on drop when disabled', () => { it('should not prevent default event on drop when disabled', () => {
directive.enabled = false; directive.enabled = false;
let event = jasmine.createSpyObj('event', ['preventDefault', 'stopPropagation']); let event = jasmine.createSpyObj('event', ['preventDefault', 'stopPropagation']);
directive.onDrop(<DragEvent>event); directive.onDrop(<DragEvent> event);
expect(event.preventDefault).not.toHaveBeenCalled(); expect(event.preventDefault).not.toHaveBeenCalled();
}); });

View File

@ -18,10 +18,10 @@
import { async, TestBed } from '@angular/core/testing'; import { async, TestBed } from '@angular/core/testing';
import { CookieServiceMock } from './../assets/cookie.service.mock'; import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service'; import { AlfrescoApiService } from './alfresco-api.service';
import { AuthenticationService } from './authentication.service';
import { AlfrescoContentService } from './alfresco-content.service'; import { AlfrescoContentService } from './alfresco-content.service';
import { AlfrescoSettingsService } from './alfresco-settings.service'; import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service'; import { AppConfigModule } from './app-config.service';
import { AuthenticationService } from './authentication.service';
import { CookieService } from './cookie.service'; import { CookieService } from './cookie.service';
import { LogService } from './log.service'; import { LogService } from './log.service';
import { StorageService } from './storage.service'; import { StorageService } from './storage.service';

View File

@ -16,15 +16,15 @@
*/ */
import { async, inject, TestBed } from '@angular/core/testing'; import { async, inject, TestBed } from '@angular/core/testing';
import { Router} from '@angular/router'; import { Router } from '@angular/router';
import { RouterTestingModule } from '@angular/router/testing'; import { RouterTestingModule } from '@angular/router/testing';
import { CookieServiceMock } from './../assets/cookie.service.mock'; import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service'; import { AlfrescoApiService } from './alfresco-api.service';
import { AuthenticationService } from './authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service'; import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service'; import { AppConfigModule } from './app-config.service';
import { AuthGuardBpm } from './auth-guard-bpm.service'; import { AuthGuardBpm } from './auth-guard-bpm.service';
import { AuthenticationService } from './authentication.service';
import { CookieService } from './cookie.service'; import { CookieService } from './cookie.service';
import { LogService } from './log.service'; import { LogService } from './log.service';
import { StorageService } from './storage.service'; import { StorageService } from './storage.service';

View File

@ -16,15 +16,15 @@
*/ */
import { async, inject, TestBed } from '@angular/core/testing'; import { async, inject, TestBed } from '@angular/core/testing';
import { Router} from '@angular/router'; import { Router } from '@angular/router';
import { RouterTestingModule } from '@angular/router/testing'; import { RouterTestingModule } from '@angular/router/testing';
import { CookieServiceMock } from './../assets/cookie.service.mock'; import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service'; import { AlfrescoApiService } from './alfresco-api.service';
import { AuthenticationService } from './authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service'; import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service'; import { AppConfigModule } from './app-config.service';
import { AuthGuardEcm } from './auth-guard-ecm.service'; import { AuthGuardEcm } from './auth-guard-ecm.service';
import { AuthenticationService } from './authentication.service';
import { CookieService } from './cookie.service'; import { CookieService } from './cookie.service';
import { LogService } from './log.service'; import { LogService } from './log.service';
import { StorageService } from './storage.service'; import { StorageService } from './storage.service';

View File

@ -16,15 +16,15 @@
*/ */
import { async, inject, TestBed } from '@angular/core/testing'; import { async, inject, TestBed } from '@angular/core/testing';
import { Router} from '@angular/router'; import { Router } from '@angular/router';
import { RouterTestingModule } from '@angular/router/testing'; import { RouterTestingModule } from '@angular/router/testing';
import { CookieServiceMock } from './../assets/cookie.service.mock'; import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service'; import { AlfrescoApiService } from './alfresco-api.service';
import { AuthenticationService } from './authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service'; import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service'; import { AppConfigModule } from './app-config.service';
import { AuthGuard } from './auth-guard.service'; import { AuthGuard } from './auth-guard.service';
import { AuthenticationService } from './authentication.service';
import { CookieService } from './cookie.service'; import { CookieService } from './cookie.service';
import { LogService } from './log.service'; import { LogService } from './log.service';
import { StorageService } from './storage.service'; import { StorageService } from './storage.service';

View File

@ -18,9 +18,9 @@
import { async, TestBed } from '@angular/core/testing'; import { async, TestBed } from '@angular/core/testing';
import { CookieServiceMock } from './../assets/cookie.service.mock'; import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service'; import { AlfrescoApiService } from './alfresco-api.service';
import { AuthenticationService } from './authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service'; import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service'; import { AppConfigModule } from './app-config.service';
import { AuthenticationService } from './authentication.service';
import { CookieService } from './cookie.service'; import { CookieService } from './cookie.service';
import { LogService } from './log.service'; import { LogService } from './log.service';
import { StorageService } from './storage.service'; import { StorageService } from './storage.service';

View File

@ -19,10 +19,10 @@ import { async, TestBed } from '@angular/core/testing';
import { HttpModule } from '@angular/http'; import { HttpModule } from '@angular/http';
import { CookieServiceMock } from './../assets/cookie.service.mock'; import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service'; import { AlfrescoApiService } from './alfresco-api.service';
import { AuthenticationService } from './authentication.service';
import { AlfrescoContentService } from './alfresco-content.service'; import { AlfrescoContentService } from './alfresco-content.service';
import { AlfrescoSettingsService } from './alfresco-settings.service'; import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigService } from './app-config.service'; import { AppConfigService } from './app-config.service';
import { AuthenticationService } from './authentication.service';
import { CookieService } from './cookie.service'; import { CookieService } from './cookie.service';
import { LogService } from './log.service'; import { LogService } from './log.service';
import { StorageService } from './storage.service'; import { StorageService } from './storage.service';

View File

@ -16,14 +16,14 @@
*/ */
import { Injector } from '@angular/core'; import { Injector } from '@angular/core';
import {getTestBed, TestBed} from '@angular/core/testing'; import { getTestBed, TestBed } from '@angular/core/testing';
import { HttpModule, Response, ResponseOptions, XHRBackend } from '@angular/http'; import { HttpModule, Response, ResponseOptions, XHRBackend } from '@angular/http';
import { MockBackend, MockConnection } from '@angular/http/testing'; import { MockBackend, MockConnection } from '@angular/http/testing';
import { TranslateLoader, TranslateModule } from '@ngx-translate/core'; import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { LogService } from './log.service';
import { AlfrescoTranslateLoader } from './translate-loader.service'; import { AlfrescoTranslateLoader } from './translate-loader.service';
import { TranslationService } from './translation.service'; import { TranslationService } from './translation.service';
import { LogService } from './log.service';
let componentJson1 = ' {"TEST": "This is a test", "TEST2": "This is another test"} ' ; let componentJson1 = ' {"TEST": "This is a test", "TEST2": "This is another test"} ' ;

View File

@ -21,9 +21,9 @@ import { HttpModule, Response, ResponseOptions, XHRBackend } from '@angular/http
import { MockBackend, MockConnection } from '@angular/http/testing'; import { MockBackend, MockConnection } from '@angular/http/testing';
import { TranslateLoader, TranslateModule } from '@ngx-translate/core'; import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { LogService } from './log.service';
import { AlfrescoTranslateLoader } from './translate-loader.service'; import { AlfrescoTranslateLoader } from './translate-loader.service';
import { TranslationService } from './translation.service'; import { TranslationService } from './translation.service';
import { LogService } from './log.service';
const mockBackendResponse = (connection: MockConnection, response: string) => { const mockBackendResponse = (connection: MockConnection, response: string) => {
connection.mockRespond(new Response(new ResponseOptions({body: response}))); connection.mockRespond(new Response(new ResponseOptions({body: response})));

View File

@ -19,9 +19,9 @@ import { EventEmitter } from '@angular/core';
import { TestBed } from '@angular/core/testing'; import { TestBed } from '@angular/core/testing';
import { FileModel, FileUploadOptions } from '../models/file.model'; import { FileModel, FileUploadOptions } from '../models/file.model';
import { AlfrescoApiService } from './alfresco-api.service'; import { AlfrescoApiService } from './alfresco-api.service';
import { AuthenticationService } from './authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service'; import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service'; import { AppConfigModule } from './app-config.service';
import { AuthenticationService } from './authentication.service';
import { StorageService } from './storage.service'; import { StorageService } from './storage.service';
import { UploadService } from './upload.service'; import { UploadService } from './upload.service';
@ -61,15 +61,15 @@ describe('UploadService', () => {
}); });
it('should add an element in the queue and returns it', () => { it('should add an element in the queue and returns it', () => {
let filesFake = new FileModel(<File>{ name: 'fake-name', size: 10 }); let filesFake = new FileModel(<File> { name: 'fake-name', size: 10 });
service.addToQueue(filesFake); service.addToQueue(filesFake);
expect(service.getQueue().length).toEqual(1); expect(service.getQueue().length).toEqual(1);
}); });
it('should add two elements in the queue and returns them', () => { it('should add two elements in the queue and returns them', () => {
let filesFake = [ let filesFake = [
new FileModel(<File>{ name: 'fake-name', size: 10 }), new FileModel(<File> { name: 'fake-name', size: 10 }),
new FileModel(<File>{ name: 'fake-name2', size: 20 }) new FileModel(<File> { name: 'fake-name2', size: 20 })
]; ];
service.addToQueue(...filesFake); service.addToQueue(...filesFake);
expect(service.getQueue().length).toEqual(2); expect(service.getQueue().length).toEqual(2);
@ -91,8 +91,8 @@ describe('UploadService', () => {
done(); done();
}); });
let fileFake = new FileModel( let fileFake = new FileModel(
<File>{ name: 'fake-name', size: 10 }, <File> { name: 'fake-name', size: 10 },
<FileUploadOptions>{ parentId: '-root-', path: 'fake-dir' } <FileUploadOptions> { parentId: '-root-', path: 'fake-dir' }
); );
service.addToQueue(fileFake); service.addToQueue(fileFake);
service.uploadFilesInTheQueue(emitter); service.uploadFilesInTheQueue(emitter);
@ -116,8 +116,8 @@ describe('UploadService', () => {
done(); done();
}); });
let fileFake = new FileModel( let fileFake = new FileModel(
<File>{ name: 'fake-name', size: 10 }, <File> { name: 'fake-name', size: 10 },
<FileUploadOptions>{ parentId: '-root-' } <FileUploadOptions> { parentId: '-root-' }
); );
service.addToQueue(fileFake); service.addToQueue(fileFake);
service.uploadFilesInTheQueue(emitter); service.uploadFilesInTheQueue(emitter);
@ -138,7 +138,7 @@ describe('UploadService', () => {
expect(e.value).toEqual('File aborted'); expect(e.value).toEqual('File aborted');
done(); done();
}); });
let fileFake = new FileModel(<File>{ name: 'fake-name', size: 10 }); let fileFake = new FileModel(<File> { name: 'fake-name', size: 10 });
service.addToQueue(fileFake); service.addToQueue(fileFake);
service.uploadFilesInTheQueue(emitter); service.uploadFilesInTheQueue(emitter);
@ -149,7 +149,7 @@ describe('UploadService', () => {
it('If versioning is true autoRename should not be present and majorVersion should be a param', () => { it('If versioning is true autoRename should not be present and majorVersion should be a param', () => {
let emitter = new EventEmitter(); let emitter = new EventEmitter();
const filesFake = new FileModel(<File>{ name: 'fake-name', size: 10 }, { newVersion: true }); const filesFake = new FileModel(<File> { name: 'fake-name', size: 10 }, { newVersion: true });
service.addToQueue(filesFake); service.addToQueue(filesFake);
service.uploadFilesInTheQueue(emitter); service.uploadFilesInTheQueue(emitter);
@ -165,7 +165,7 @@ describe('UploadService', () => {
done(); done();
}); });
let filesFake = new FileModel( let filesFake = new FileModel(
<File>{ name: 'fake-name', size: 10 }, <File> { name: 'fake-name', size: 10 },
<FileUploadOptions> { parentId: '123', path: 'fake-dir' } <FileUploadOptions> { parentId: '123', path: 'fake-dir' }
); );
service.addToQueue(filesFake); service.addToQueue(filesFake);
@ -194,8 +194,8 @@ describe('UploadService', () => {
done(); done();
}); });
let fileFake1 = new FileModel(<File>{ name: 'fake-name1', size: 10 }); let fileFake1 = new FileModel(<File> { name: 'fake-name1', size: 10 });
let fileFake2 = new FileModel(<File>{ name: 'fake-name2', size: 10 }); let fileFake2 = new FileModel(<File> { name: 'fake-name2', size: 10 });
let filelist = [fileFake1, fileFake2]; let filelist = [fileFake1, fileFake2];
service.addToQueue(...filelist); service.addToQueue(...filelist);
service.uploadFilesInTheQueue(emitter); service.uploadFilesInTheQueue(emitter);