From 922e6ae3abf5a5018c8fbbe3bab80a33ab03d04c Mon Sep 17 00:00:00 2001
From: Cilibiu Bogdan <pionnegru@users.noreply.github.com>
Date: Tue, 8 Oct 2019 12:30:06 +0300
Subject: [PATCH] add aria-label attribute (#5138)

---
 lib/core/i18n/en.json                               | 3 ++-
 lib/core/viewer/components/pdfViewer.component.html | 2 ++
 lib/core/viewer/components/viewer.component.html    | 9 +++++++++
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/lib/core/i18n/en.json b/lib/core/i18n/en.json
index f92a469376..11d2cbe7cf 100644
--- a/lib/core/i18n/en.json
+++ b/lib/core/i18n/en.json
@@ -326,7 +326,8 @@
       "FIT_PAGE": "Fit page",
       "ROTATE_LEFT": "Rotate left",
       "ROTATE_RIGHT": "Rotate right",
-      "RESET": "Reset"
+      "RESET": "Reset",
+      "THUMBNAILS": "Document thumbnails"
     },
     "PAGE_LABEL": {
       "SHOWING": "Showing",
diff --git a/lib/core/viewer/components/pdfViewer.component.html b/lib/core/viewer/components/pdfViewer.component.html
index 166581448a..ebadf89fb3 100644
--- a/lib/core/viewer/components/pdfViewer.component.html
+++ b/lib/core/viewer/components/pdfViewer.component.html
@@ -37,6 +37,8 @@
 
         <ng-container *ngIf="allowThumbnails">
             <button mat-icon-button
+                    [attr.aria-label]="'ADF_VIEWER.ARIA.THUMBNAILS' | translate"
+                    [attr.aria-expanded]="showThumbnails"
                     data-automation-id="adf-thumbnails-button"
                     [disabled]="isPanelDisabled"
                     (click)="toggleThumbnails()">
diff --git a/lib/core/viewer/components/viewer.component.html b/lib/core/viewer/components/viewer.component.html
index 64890a46fb..c11d5a2776 100644
--- a/lib/core/viewer/components/viewer.component.html
+++ b/lib/core/viewer/components/viewer.component.html
@@ -14,6 +14,7 @@
                         <button
                             mat-icon-button
                             [attr.aria-expanded]="showLeftSidebar"
+                            [attr.aria-label]="'ADF_VIEWER.ACTIONS.INFO' | translate"
                             title="{{ 'ADF_VIEWER.ACTIONS.INFO' | translate }}"
                             data-automation-id="adf-toolbar-left-sidebar"
                             [color]="showLeftSidebar ? 'accent' : 'default'"
@@ -25,6 +26,7 @@
                     <button *ngIf="allowGoBack"
                             class="adf-viewer-close-button"
                             data-automation-id="adf-toolbar-back"
+                            [attr.aria-label]="'ADF_VIEWER.ACTIONS.CLOSE' | translate"
                             mat-icon-button
                             title="{{ 'ADF_VIEWER.ACTIONS.CLOSE' | translate }}"
                             (click)="onBackButtonClick()">
@@ -37,6 +39,7 @@
                         *ngIf="allowNavigate && canNavigateBefore"
                         data-automation-id="adf-toolbar-pref-file"
                         mat-icon-button
+                        [attr.aria-label]="'ADF_VIEWER.ACTIONS.PREV_FILE' | translate"
                         title="{{ 'ADF_VIEWER.ACTIONS.PREV_FILE' | translate }}"
                         (click)="onNavigateBeforeClick()">
                         <mat-icon>navigate_before</mat-icon>
@@ -47,6 +50,7 @@
                         *ngIf="allowNavigate && canNavigateNext"
                         data-automation-id="adf-toolbar-next-file"
                         mat-icon-button
+                        [attr.aria-label]="'ADF_VIEWER.ACTIONS.NEXT_FILE' | translate"
                         title="{{ 'ADF_VIEWER.ACTIONS.NEXT_FILE' | translate }}"
                         (click)="onNavigateNextClick()">
                         <mat-icon>navigate_next</mat-icon>
@@ -75,6 +79,7 @@
                     id="adf-viewer-download"
                     *ngIf="allowDownload"
                     mat-icon-button
+                    [attr.aria-label]="'ADF_VIEWER.ACTIONS.DOWNLOAD' | translate"
                     title="{{ 'ADF_VIEWER.ACTIONS.DOWNLOAD' | translate }}"
                     data-automation-id="adf-toolbar-download"
                     [adfNodeDownload]="nodeEntry">
@@ -85,6 +90,7 @@
                     id="adf-viewer-print"
                     *ngIf="allowPrint"
                     mat-icon-button
+                    [attr.aria-label]="'ADF_VIEWER.ACTIONS.PRINT' | translate"
                     title="{{ 'ADF_VIEWER.ACTIONS.PRINT' | translate }}"
                     data-automation-id="adf-toolbar-print"
                     (click)="printContent()">
@@ -95,6 +101,7 @@
                     id="adf-viewer-fullscreen"
                     *ngIf="viewerType !== 'media' && allowFullScreen"
                     mat-icon-button
+                    [attr.aria-label]="'ADF_VIEWER.ACTIONS.FULLSCREEN' | translate"
                     title="{{ 'ADF_VIEWER.ACTIONS.FULLSCREEN' | translate }}"
                     data-automation-id="adf-toolbar-fullscreen"
                     (click)="enterFullScreen()">
@@ -107,6 +114,7 @@
                     <button
                         mat-icon-button
                         [attr.aria-expanded]="showRightSidebar"
+                        [attr.aria-label]="'ADF_VIEWER.ACTIONS.INFO' | translate"
                         title="{{ 'ADF_VIEWER.ACTIONS.INFO' | translate }}"
                         data-automation-id="adf-toolbar-sidebar"
                         [color]="showRightSidebar ? 'accent' : 'default'"
@@ -121,6 +129,7 @@
                         id="adf-viewer-moreactions"
                         mat-icon-button
                         [matMenuTriggerFor]="mnuMoreActions"
+                        [attr.aria-label]="'ADF_VIEWER.ACTIONS.MORE_ACTIONS' | translate"
                         title="{{ 'ADF_VIEWER.ACTIONS.MORE_ACTIONS' | translate }}"
                         data-automation-id="adf-toolbar-more-actions">
                         <mat-icon>more_vert</mat-icon>