From 92fb997bb0f9e1adeb6663045ed120e6642da05c Mon Sep 17 00:00:00 2001
From: Yasa-Nataliya <yasa.nataliya@globallogic.com>
Date: Thu, 10 Aug 2023 17:54:49 +0530
Subject: [PATCH] [ACS-5645]Added edit functionality for each panel and updated
 test cases

---
 .../categories-management.component.html               |  8 ++++----
 .../categories-management.component.scss               |  1 -
 .../categories-management.component.spec.ts            |  2 +-
 .../categories-management.component.ts                 |  2 ++
 .../content-metadata/content-metadata.component.scss   |  1 +
 .../content-metadata.component.spec.ts                 |  9 +++++++--
 .../lib/tag/tags-creator/tags-creator.component.scss   | 10 ++++++++++
 .../tag/tags-creator/tags-creator.component.spec.ts    |  4 ++--
 8 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/lib/content-services/src/lib/category/categories-management/categories-management.component.html b/lib/content-services/src/lib/category/categories-management/categories-management.component.html
index 9c51a9b8fa..01252dde87 100644
--- a/lib/content-services/src/lib/category/categories-management/categories-management.component.html
+++ b/lib/content-services/src/lib/category/categories-management/categories-management.component.html
@@ -17,7 +17,7 @@
         <span
             *ngFor="let category of categories"
             [class.adf-categories-padded]="!isCRUDMode"
-            class="adf-assigned-categories">
+                class="adf-assigned-categories">
             {{ category.name }}
             <button
                 data-automation-id="categories-remove-category-button"
@@ -37,7 +37,7 @@
 <div class="adf-existing-categories-panel" *ngIf="existingCategoriesPanelVisible">
     <ng-container *ngIf="isCRUDMode && (!existingCategoriesLoading || existingCategories)">
         <span class="adf-create-category-label"
-            (click)="addCategory()"
+        (click)="addCategory()"
             [hidden]="categoryNameControl.invalid || typing">
             {{ 'CATEGORIES_MANAGEMENT.GENERIC_CREATE' | translate : { name: categoryNameControl.value } }}
         </span>
@@ -62,8 +62,8 @@
             </mat-selection-list>
         </ng-container>
         <mat-spinner
-            *ngIf="existingCategoriesLoading"
-            [diameter]="50"
+               *ngIf="existingCategoriesLoading"
+               [diameter]="50"
             [attr.aria-label]="'CATEGORIES_MANAGEMENT.LOADING' | translate">
         </mat-spinner>
     </div>
diff --git a/lib/content-services/src/lib/category/categories-management/categories-management.component.scss b/lib/content-services/src/lib/category/categories-management/categories-management.component.scss
index 9cc1235d16..d37a5aff5c 100644
--- a/lib/content-services/src/lib/category/categories-management/categories-management.component.scss
+++ b/lib/content-services/src/lib/category/categories-management/categories-management.component.scss
@@ -1,6 +1,5 @@
 .adf-categories-management {
     padding-top: 12px;
-
     .adf-category-name-field {
         display: flex;
         justify-content: space-between;
diff --git a/lib/content-services/src/lib/category/categories-management/categories-management.component.spec.ts b/lib/content-services/src/lib/category/categories-management/categories-management.component.spec.ts
index d7c1cf0aac..f7333c673c 100644
--- a/lib/content-services/src/lib/category/categories-management/categories-management.component.spec.ts
+++ b/lib/content-services/src/lib/category/categories-management/categories-management.component.spec.ts
@@ -324,7 +324,7 @@ describe('CategoriesManagementComponent', () => {
         it('should have no required validator set for category control', () => {
             expect(component.categoryNameControl.hasValidator(Validators.required)).toBeFalse();
         });
-
+        
         it('should display validation error when searching for empty category', fakeAsync(() => {
             typeCategory('   ');
 
diff --git a/lib/content-services/src/lib/category/categories-management/categories-management.component.ts b/lib/content-services/src/lib/category/categories-management/categories-management.component.ts
index ac84cd907c..a3f1e2c65e 100644
--- a/lib/content-services/src/lib/category/categories-management/categories-management.component.ts
+++ b/lib/content-services/src/lib/category/categories-management/categories-management.component.ts
@@ -228,6 +228,8 @@ export class CategoriesManagementComponent implements OnInit, OnDestroy {
             const newCat = new Category({ id: newCatName, name: newCatName });
             this.categories.push(newCat);
             this.clearCategoryNameInput();
+            this.categoryNameControl.setValue('');
+            this.categoryNameControl.markAsUntouched();
             this._existingCategories = null;
             this.categoriesChange.emit(this.categories);
         }
diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.scss b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.scss
index 83b90a09a1..d5cff72825 100644
--- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.scss
+++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.scss
@@ -22,6 +22,7 @@
                 width: 80px;
             }
         }
+    }
 
         .mat-expansion-panel:not([class*='mat-elevation-z']) {
             box-shadow: none;
diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts
index f09b205b07..1a9d38c091 100644
--- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts
+++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts
@@ -100,7 +100,12 @@ describe('ContentMetadataComponent', () => {
     const clickOnTagsSave = () => {
         findSaveTagsButton().click();
         fixture.detectChanges();
-    };
+    }
+
+    const clickOnTagsSave = () => {
+        findSaveTagsButton().click();
+        fixture.detectChanges();
+    }
 
     const findTagsCreator = (): TagsCreatorComponent => fixture.debugElement.query(By.directive(TagsCreatorComponent))?.componentInstance;
 
@@ -808,7 +813,6 @@ describe('ContentMetadataComponent', () => {
 
     describe('Display properties with aspect oriented config', () => {
         let appConfig: AppConfigService;
-        let classesApi: ClassesApi;
         let expectedNode: Node;
 
         const verResponse: PropertyGroup = {
@@ -1149,6 +1153,7 @@ describe('ContentMetadataComponent', () => {
         it('should render tags after loading tags in ngOnInit', () => {
             spyOn(tagService, 'getTagsByNodeId').and.returnValue(of(tagPaging));
             component.ngOnInit();
+            fixture.whenStable();
             fixture.detectChanges();
             const tagElements = findTagElements();
             expect(tagElements).toHaveSize(2);
diff --git a/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.scss b/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.scss
index 90037340bd..c4d28ec0d4 100644
--- a/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.scss
+++ b/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.scss
@@ -63,6 +63,16 @@ adf-tags-creator {
         }
     }
 
+    .adf-tag-search-field {
+        width: 752px;
+        background: var(--adf-metadata-tags-background-color);
+        height: 32px;
+        border-radius: 12px;
+        align-items: center;
+        display: flex;
+        padding: 0 12px;
+    }
+
     .adf-create-tag-label {
         color: var(--theme-primary-color);
         cursor: pointer;
diff --git a/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.spec.ts b/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.spec.ts
index 5b4d6574c9..dac9e426e4 100644
--- a/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.spec.ts
+++ b/lib/content-services/src/lib/tag/tags-creator/tags-creator.component.spec.ts
@@ -21,7 +21,7 @@ import { NotificationService } from '@alfresco/adf-core';
 import { By } from '@angular/platform-browser';
 import { TranslateModule } from '@ngx-translate/core';
 import { MatIconModule } from '@angular/material/icon';
-import { MatError, MatFormField, MatFormFieldModule } from '@angular/material/form-field';
+import { MatError, MatFormFieldModule } from '@angular/material/form-field';
 import { MatInputModule } from '@angular/material/input';
 import { ReactiveFormsModule } from '@angular/forms';
 import { MatButtonModule } from '@angular/material/button';
@@ -300,7 +300,7 @@ describe('TagsCreatorComponent', () => {
             const tagNameField = fixture.debugElement.query(By.css(tagNameFieldSelector));
             expect(tagNameField).toBeTruthy();
             expect(tagNameField.nativeElement.hasAttribute('hidden')).toBeFalsy();
-            expect(tagNameField.query(By.directive(MatFormField))).toBeTruthy();
+            expect(tagNameField).toBeTruthy();
         });
 
         it('should input be autofocused', fakeAsync(() => {