[ADF-1548] deprecate the usage of the "forRoot" methods in modules (#2344)

* remove CoreModule.forRoot

* remove forRoot methods

* fix form issues (lint)

ng2-components/ng2-alfresco-upload/index.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { ModuleWithProviders, NgModule } from '@angular/core';
+import { NgModule } from '@angular/core';
 
 import { CoreModule, TRANSLATION_PROVIDER } from 'ng2-alfresco-core';
 import { MaterialModule } from './src/material.module';
@@ -66,10 +66,4 @@ export const UPLOAD_DIRECTIVES: any[] = [
         ...UPLOAD_DIRECTIVES
     ]
 })
-export class UploadModule {
-    static forRoot(): ModuleWithProviders {
-        return {
-            ngModule: UploadModule
-        };
-    }
-}
+export class UploadModule {}

ng2-components/ng2-alfresco-upload/src/components/upload-button.component.spec.ts

@@ -61,7 +61,7 @@ describe('UploadButtonComponent', () => {
     beforeEach(async(() => {
         TestBed.configureTestingModule({
             imports: [
-                CoreModule.forRoot()
+                CoreModule
             ],
             declarations: [
                 UploadButtonComponent

ng2-components/ng2-alfresco-upload/src/components/upload-drag-area.component.spec.ts

@@ -68,7 +68,7 @@ describe('UploadDragAreaComponent', () => {
     beforeEach(async(() => {
         TestBed.configureTestingModule({
             imports: [
-                CoreModule.forRoot()
+                CoreModule
             ],
             declarations: [
                 FileDraggableDirective,