diff --git a/ng2-components/ng2-alfresco-viewer/README.md b/ng2-components/ng2-alfresco-viewer/README.md index d699cc78ab..41b12c4610 100644 --- a/ng2-components/ng2-alfresco-viewer/README.md +++ b/ng2-components/ng2-alfresco-viewer/README.md @@ -104,11 +104,10 @@ bootstrap(MyDemoApp, [ #### Options -Attribute | Options | Default | Description +Attribute | Options | Default | Description | Mandatory --- | --- | --- | --- -`urlFile` | *string* | | Url where load the file ---- | --- | --- | --- -`overlayMode` | *boolean* | `false` | if true Show the Viewer full page over the present content +`urlFile` | *string* | | Url where to load the file | mandatory +`overlayMode` | *boolean* | `false` | if true Show the Viewer full page over the present content | ## Build from sources diff --git a/ng2-components/ng2-alfresco-viewer/src/viewer.component.spec.ts b/ng2-components/ng2-alfresco-viewer/src/viewer.component.spec.ts index 6509675107..8a3e4ffdc3 100644 --- a/ng2-components/ng2-alfresco-viewer/src/viewer.component.spec.ts +++ b/ng2-components/ng2-alfresco-viewer/src/viewer.component.spec.ts @@ -36,13 +36,13 @@ describe('Ng2-alfresco-viewer', () => { }); })); - it('shadow overlay shoudl be present if overlay is true', injectAsync([TestComponentBuilder], (tcb: TestComponentBuilder) => { + it('shadow overlay should be present if overlay is true', injectAsync([TestComponentBuilder], (tcb: TestComponentBuilder) => { return tcb .createAsync(ViewerComponent) .then((fixture) => { let element = fixture.nativeElement; let component = fixture.componentInstance; - + component.urlFile = 'fake-url-file'; component.overlayMode = true; fixture.detectChanges(); @@ -90,7 +90,7 @@ describe('Ng2-alfresco-viewer', () => { }); })); - it('Name File should be showed', injectAsync([TestComponentBuilder], (tcb: TestComponentBuilder) => { + it('Name File should be present', injectAsync([TestComponentBuilder], (tcb: TestComponentBuilder) => { return tcb .createAsync(ViewerComponent) .then((fixture) => { @@ -108,4 +108,18 @@ describe('Ng2-alfresco-viewer', () => { }); })); }); + + describe('Attribute', () => { + it('Url File should be mandatory', injectAsync([TestComponentBuilder], (tcb: TestComponentBuilder) => { + return tcb + .createAsync(ViewerComponent) + .then((fixture) => { + let component = fixture.componentInstance; + + expect(() => { + component.urlFile = 'fake-url-file'; + }).toThrow(); + }); + })); + }); }); diff --git a/ng2-components/ng2-alfresco-viewer/src/viewer.component.ts b/ng2-components/ng2-alfresco-viewer/src/viewer.component.ts index 6aba8d83c6..e5e884b9f3 100644 --- a/ng2-components/ng2-alfresco-viewer/src/viewer.component.ts +++ b/ng2-components/ng2-alfresco-viewer/src/viewer.component.ts @@ -40,6 +40,12 @@ export class ViewerComponent { displayPage: number; totalPages: number; + ngOnInit() { + if (!this.urlFile) { + throw new Error('Attribute urlFile is required'); + } + } + ngOnChanges(changes: {[urlFile: string]: SimpleChange}) { if (this.urlFile) { this.nameFile = this.getPDFJS().getFilenameFromUrl(this.urlFile); @@ -53,8 +59,6 @@ export class ViewerComponent { this.displayPage = 1; this.loadPage(this.currentPdfDocument); }); - } else { - console.log('Url File is a required value'); } }