[ADF-1287] compatibility with the new noUnusedLocals rule (#2170)

* support for noUnusedLocals rule

* clean diagram components

* code cleanup

* Viewer fixes

* code fixes

* code fixes
This commit is contained in:
Denys Vuika
2017-08-04 15:35:15 +01:00
committed by Mario Romano
parent 0f239a1fa3
commit 9d3962b3b5
113 changed files with 190 additions and 346 deletions

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-business-rule-task',
templateUrl: './diagram-business-rule-task.component.html'
})
export class DiagramBusinessRuleTaskComponent implements OnInit {
export class DiagramBusinessRuleTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,25 +17,19 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-manual-task',
templateUrl: './diagram-manual-task.component.html'
})
export class DiagramManualTaskComponent implements OnInit {
export class DiagramManualTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {
}
ngOnInit() {
constructor(public elementRef: ElementRef) {
}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-receive-task',
templateUrl: './diagram-receive-task.component.html'
})
export class DiagramReceiveTaskComponent implements OnInit {
export class DiagramReceiveTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-script-task',
templateUrl: './diagram-script-task.component.html'
})
export class DiagramScriptTaskComponent implements OnInit {
export class DiagramScriptTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-service-task',
templateUrl: './diagram-service-task.component.html'
})
export class DiagramServiceTaskComponent implements OnInit {
export class DiagramServiceTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -17,24 +17,18 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-user-task',
templateUrl: './diagram-user-task.component.html'
})
export class DiagramUserTaskComponent implements OnInit {
export class DiagramUserTaskComponent {
@Input()
data: any;
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { Component, ElementRef, EventEmitter, Input, OnChanges, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { Component, EventEmitter, Input, OnChanges, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { DiagramElementModel, DiagramModel } from '../models/diagram.model';
import { DiagramColorService } from '../services/diagram-color.service';
import { DiagramsService } from '../services/diagrams.service';
@@ -60,12 +60,10 @@ export class DiagramComponent implements OnChanges {
diagram: DiagramModel;
constructor(private elementRef: ElementRef,
private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private diagramColorService: DiagramColorService,
private raphaelService: RaphaelService,
private diagramsService: DiagramsService,
private logService: LogService) {
private diagramsService: DiagramsService) {
if (translateService) {
translateService.addTranslationFolder('ng2-activiti-diagrams', 'assets/ng2-activiti-diagrams');
}

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-event',
@@ -39,8 +38,7 @@ export class DiagramEventComponent implements OnInit {
center: any = {};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {

View File

@@ -17,14 +17,13 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
import { Component, ElementRef, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'diagram-container-icon-event',
templateUrl: './diagram-container-icon-event.component.html'
})
export class DiagramContainerIconEventTaskComponent implements OnInit {
export class DiagramContainerIconEventTaskComponent {
@Input()
data: any;
@@ -37,9 +36,5 @@ export class DiagramContainerIconEventTaskComponent implements OnInit {
@Output()
onError = new EventEmitter();
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
ngOnInit() {
}
constructor(public elementRef: ElementRef) {}
}

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-alfresco-publish-task',
@@ -35,8 +34,7 @@ export class DiagramIconAlfrescoPublishTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-box-publish-task',
@@ -35,8 +34,7 @@ export class DiagramIconBoxPublishTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 6, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-business-rule-task',
@@ -35,8 +34,7 @@ export class DiagramIconBusinessRuleTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-camel-task',
@@ -35,8 +34,7 @@ export class DiagramIconCamelTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 8, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-error',
@@ -38,8 +37,7 @@ export class DiagramIconErrorComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x - 1, y: this.data.y - 1};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-google-drive-publish-task',
@@ -35,8 +34,7 @@ export class DiagramIconGoogleDrivePublishTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 6, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-manual-task',
@@ -35,8 +34,7 @@ export class DiagramIconManualTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-message',
@@ -35,8 +34,7 @@ export class DiagramIconMessageComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 6, y: this.data.y + 6};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-mule-task',
@@ -35,8 +34,7 @@ export class DiagramIconMuleTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 2, y: this.data.y + 2};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-receive-task',
@@ -35,8 +34,7 @@ export class DiagramIconReceiveTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 2};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-rest-call-task',
@@ -35,8 +34,7 @@ export class DiagramIconRestCallTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 2, y: this.data.y + 2};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-script-task',
@@ -35,8 +34,7 @@ export class DiagramIconScriptTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-send-task',
@@ -35,8 +34,7 @@ export class DiagramIconSendTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-service-task',
@@ -35,8 +34,7 @@ export class DiagramIconServiceTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-signal',
@@ -38,8 +37,7 @@ export class DiagramIconSignalComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x - 1, y: this.data.y - 1};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-timer',
@@ -39,8 +38,7 @@ export class DiagramIconTimerComponent implements OnInit {
circleOptions: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
timerOptions: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.center.x = this.data.x + (this.data.width / 2);

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-icon-user-task',
@@ -35,8 +34,7 @@ export class DiagramIconUserTaskComponent implements OnInit {
options: any = {stroke: '', fillColors: '', fillOpacity: '', strokeWidth: ''};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.position = {x: this.data.x + 4, y: this.data.y + 4};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-lane',
@@ -40,8 +39,7 @@ export class DiagramLaneComponent implements OnInit {
textTransform: string;
options: any = {stroke: '#000000', fillColors: 'none', fillOpacity: '', strokeWidth: '1', radius: 0};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.rectLeftCorner = {x: this.lane.x, y: this.lane.y};

View File

@@ -18,7 +18,6 @@
/* tslint:disable:component-selector */
import { Component, ElementRef, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { DiagramColorService } from '../../services/diagram-color.service';
@Component({
selector: 'diagram-pool',
@@ -40,8 +39,7 @@ export class DiagramPoolComponent implements OnInit {
textTransform: string;
options: any = {stroke: '#000000', fillColors: 'none', fillOpacity: '', strokeWidth: '1', radius: 0};
constructor(public elementRef: ElementRef,
private diagramColorService: DiagramColorService) {}
constructor(public elementRef: ElementRef) {}
ngOnInit() {
this.rectLeftCorner = {x: this.pool.x, y: this.pool.y};

View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",