inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-1287] compatibility with the new noUnusedLocals rule (#2170)

Browse Source 
* support for noUnusedLocals rule

* clean diagram components

* code cleanup

* Viewer fixes

* code fixes

* code fixes
This commit is contained in:
Denys Vuika
2017-08-04 15:35:15 +01:00
committed by Mario Romano
parent 0f239a1fa3
commit 9d3962b3b5
113 changed files with 190 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ng2-components/ng2-activiti-processlist/src/components/create-process-attachment.component.ts
View File

@@ -35,7 +35,7 @@ export class CreateProcessAttachmentComponent implements OnChanges {
@Output()
success: EventEmitter<any> = new EventEmitter<any>();
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService) {
if (translateService) {

2
ng2-components/ng2-activiti-processlist/src/components/process-attachment-list.component.ts
View File

@@ -41,7 +41,7 @@ export class ProcessAttachmentListComponent implements OnChanges {
attachments: any[] = [];
isLoading: boolean = true;
constructor(private translateService: AlfrescoTranslationService,
constructor(translateService: AlfrescoTranslationService,
private activitiContentService: ActivitiContentService,
private contentService: ContentService,
private thumbnailService: ThumbnailService) {

3
ng2-components/ng2-activiti-processlist/src/components/process-comments.component.ts
View File

@@ -41,8 +41,7 @@ export class ProcessCommentsComponent {
* Constructor
* @param translate Translation service
*/
constructor(private translate: AlfrescoTranslationService) {
constructor(translate: AlfrescoTranslationService) {
if (translate) {
translate.addTranslationFolder('ng2-activiti-processlist', 'assets/ng2-activiti-processlist');
}

2
ng2-components/ng2-activiti-processlist/src/components/process-filters.component.spec.ts
View File

@@ -53,7 +53,7 @@ describe('ActivitiFilters', () => {
beforeEach(() => {
logService = new LogServiceMock();
activitiService = new ProcessService(null, logService);
filterList = new ProcessFiltersComponent(null, activitiService, logService);
filterList = new ProcessFiltersComponent(null, activitiService);
});
it('should return the filter task list', (done) => {

9
ng2-components/ng2-activiti-processlist/src/components/process-filters.component.ts
View File

@@ -16,13 +16,11 @@
*/
import { Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable, Observer } from 'rxjs/Rx';
import { FilterParamsModel, FilterProcessRepresentationModel } from './../models/filter-process.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
@Component({
selector: 'adf-process-instance-filters, activiti-process-instance-filters',
templateUrl: './process-filters.component.html',
@@ -58,9 +56,8 @@ export class ProcessFiltersComponent implements OnInit, OnChanges {
filters: FilterProcessRepresentationModel [] = [];
constructor(private translate: AlfrescoTranslationService,
private activiti: ProcessService,
private logService: LogService) {
constructor(translate: AlfrescoTranslationService,
private activiti: ProcessService) {
this.filter$ = new Observable<FilterProcessRepresentationModel>(observer => this.filterObserver = observer).share();
if (translate) {

4
ng2-components/ng2-activiti-processlist/src/components/process-instance-details.component.ts
View File

@@ -25,8 +25,6 @@ import { ProcessService } from './../services/process.service';
import { ProcessInstanceHeaderComponent } from './process-instance-header.component';
import { ProcessInstanceTasksComponent } from './process-instance-tasks.component';
declare let dialogPolyfill: any;
@Component({
selector: 'adf-process-instance-details, activiti-process-instance-details',
templateUrl: './process-instance-details.component.html',
@@ -68,7 +66,7 @@ export class ProcessInstanceDetailsComponent implements OnChanges {
* @param translate Translation service
* @param activitiProcess Process service
*/
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService,
private logService: LogService) {

7
ng2-components/ng2-activiti-processlist/src/components/process-instance-header.component.ts
View File

@@ -16,11 +16,9 @@
*/
import { Component, Input, OnChanges, SimpleChanges } from '@angular/core';
import { AlfrescoTranslationService, CardViewDateItemModel, CardViewItem, CardViewTextItemModel, LogService } from 'ng2-alfresco-core';
import { AlfrescoTranslationService, CardViewDateItemModel, CardViewItem, CardViewTextItemModel } from 'ng2-alfresco-core';
import { ProcessInstance } from '../models/process-instance.model';
declare let componentHandler: any;
@Component({
selector: 'adf-process-instance-header, activiti-process-instance-header',
templateUrl: './process-instance-header.component.html',
@@ -33,8 +31,7 @@ export class ProcessInstanceHeaderComponent implements OnChanges {
properties: CardViewItem [];
constructor(private translate: AlfrescoTranslationService,
private logService: LogService) {
constructor(translate: AlfrescoTranslationService) {
if (translate) {
translate.addTranslationFolder('ng2-activiti-processlist', 'assets/ng2-activiti-processlist');

3
ng2-components/ng2-activiti-processlist/src/components/process-instance-tasks.component.ts
View File

@@ -23,7 +23,6 @@ import { Observable, Observer } from 'rxjs/Rx';
import { ProcessInstance } from '../models/process-instance.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
declare let dialogPolyfill: any;
@Component({
@@ -66,7 +65,7 @@ export class ProcessInstanceTasksComponent implements OnInit, OnChanges {
@Output()
taskClick: EventEmitter<TaskDetailsEvent> = new EventEmitter<TaskDetailsEvent>();
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService,
private logService: LogService) {
if (translate) {

3
ng2-components/ng2-activiti-processlist/src/components/process-instance-variables.component.ts
View File

@@ -22,7 +22,6 @@ import { DataCellEvent, DataTableAdapter, ObjectDataRow, ObjectDataTableAdapter
import { ProcessInstanceVariable } from './../models/process-instance-variable.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
declare let dialogPolyfill: any;
@Component({
@@ -68,7 +67,7 @@ export class ProcessInstanceVariablesComponent implements OnInit, OnChanges {
* @param translate Translation service
* @param activitiProcess Process service
*/
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService) {
if (translate) {

2
ng2-components/ng2-activiti-processlist/src/components/processlist.component.ts
View File

@@ -70,7 +70,7 @@ export class ProcessInstanceListComponent implements OnChanges, AfterContentInit
];
constructor(private processService: ProcessService,
private translate: AlfrescoTranslationService) {
translate: AlfrescoTranslationService) {
if (translate !== null) {
translate.addTranslationFolder('ng2-activiti-processlist', 'assets/ng2-activiti-processlist');
}

5
ng2-components/ng2-activiti-processlist/src/components/start-process.component.ts
View File

@@ -23,9 +23,6 @@ import { ProcessDefinitionRepresentation } from './../models/process-definition.
import { ProcessInstance } from './../models/process-instance.model';
import { ProcessService } from './../services/process.service';
declare let componentHandler: any;
declare let dialogPolyfill: any;
@Component({
selector: 'adf-start-process, activiti-start-process',
templateUrl: './start-process.component.html',
@@ -59,7 +56,7 @@ export class StartProcessInstanceComponent implements OnChanges {
errorMessageId: string = '';
constructor(private translate: AlfrescoTranslationService,
constructor(translate: AlfrescoTranslationService,
private activitiProcess: ProcessService) {
if (translate) {

1
ng2-components/ng2-activiti-processlist/src/services/process.service.spec.ts
View File

@@ -34,7 +34,6 @@ import { ProcessFilterRequestRepresentation } from '../models/process-instance-f
import { ProcessInstanceVariable } from '../models/process-instance-variable.model';
import { ProcessService } from './process.service';
declare let jasmine: any;
describe('ProcessService', () => {
let service: ProcessService;

3
ng2-components/ng2-activiti-processlist/tsconfig.json
View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",