[ADF-1287] compatibility with the new noUnusedLocals rule (#2170)

* support for noUnusedLocals rule

* clean diagram components

* code cleanup

* Viewer fixes

* code fixes

* code fixes

ng2-components/ng2-alfresco-core/src/components/context-menu/context-menu-holder.component.ts

@@ -67,8 +67,8 @@ export class ContextMenuHolderComponent {
     isShown = false;
     private mouseLocation: { left: number, top: number } = {left: 0, top: 0};
 
-    constructor(private _contextMenuService: ContextMenuService) {
-        _contextMenuService.show.subscribe(e => this.showMenu(e.event, e.obj));
+    constructor(contextMenuService: ContextMenuService) {
+        contextMenuService.show.subscribe(e => this.showMenu(e.event, e.obj));
     }
 
     get locationCss() {

ng2-components/ng2-alfresco-core/src/services/search.service.spec.ts

@@ -28,8 +28,6 @@ import { SearchService } from './search.service';
 import { StorageService } from './storage.service';
 import { UserPreferencesService } from './user-preferences.service';
 
-declare let jasmine: any;
-
 describe('SearchService', () => {
 
     let service: SearchService;

ng2-components/ng2-alfresco-core/tsconfig.json

@@ -43,7 +43,8 @@
             "es2015",
             "dom"
         ],
-        "suppressImplicitAnyIndexErrors": true
+        "suppressImplicitAnyIndexErrors": true,
+        "noUnusedLocals": true
     },
     "exclude": [
         "demo",