inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-1287] compatibility with the new noUnusedLocals rule (#2170)

Browse Source 
* support for noUnusedLocals rule

* clean diagram components

* code cleanup

* Viewer fixes

* code fixes

* code fixes
This commit is contained in:
Denys Vuika
2017-08-04 15:35:15 +01:00
committed by Mario Romano
parent 0f239a1fa3
commit 9d3962b3b5
113 changed files with 190 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ng2-components/ng2-alfresco-documentlist/src/components/breadcrumb/dropdown-breadcrumb.component.spec.ts
View File

@@ -41,8 +41,6 @@ import { fakeNodeWithCreatePermission } from '../../assets/document-list.compone
import { DocumentListComponent } from '../document-list.component';
import { DropdownBreadcrumbComponent } from './dropdown-breadcrumb.component';
declare let jasmine: any;
describe('DropdownBreadcrumb', () => {
let component: DropdownBreadcrumbComponent;

8
ng2-components/ng2-alfresco-documentlist/src/components/content-node-selector/content-node-selector.component.spec.ts
View File

@@ -19,7 +19,7 @@ import { DebugElement, EventEmitter } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { MD_DIALOG_DATA, MdDialogRef } from '@angular/material';
import { By } from '@angular/platform-browser';
import { MinimalNodeEntryEntity, NodePaging } from 'alfresco-js-api';
import { MinimalNodeEntryEntity } from 'alfresco-js-api';
import { AlfrescoTranslationService, CoreModule, SearchService, SiteModel } from 'ng2-alfresco-core';
import { DataTableModule } from 'ng2-alfresco-datatable';
import { MaterialModule } from '../../material.module';
@@ -44,12 +44,6 @@ const ONE_FOLDER_RESULT = {
}
};
const NO_RESULT = {
list: {
entries: []
}
};
describe('ContentNodeSelectorComponent', () => {
let component: ContentNodeSelectorComponent;

2
ng2-components/ng2-alfresco-documentlist/src/components/content-node-selector/content-node-selector.component.ts
View File

@@ -47,7 +47,7 @@ export class ContentNodeSelectorComponent {
select: EventEmitter<MinimalNodeEntryEntity> = new EventEmitter<MinimalNodeEntryEntity>();
constructor(private searchService: SearchService,
@Optional() private translateService: AlfrescoTranslationService,
@Optional() translateService: AlfrescoTranslationService,
@Optional() @Inject(MD_DIALOG_DATA) public data?: ContentNodeSelectorComponentData,
@Optional() private containingDialog?: MdDialogRef<ContentNodeSelectorComponent>) {

8
ng2-components/ng2-alfresco-documentlist/src/components/document-list.component.spec.ts
View File

@@ -18,7 +18,7 @@
import { NgZone, SimpleChange, TemplateRef } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { AlfrescoTranslationService, CoreModule } from 'ng2-alfresco-core';
import { DataColumn, DataRowEvent, DataTableComponent } from 'ng2-alfresco-datatable';
import { DataColumn, DataTableComponent } from 'ng2-alfresco-datatable';
import { DataTableModule } from 'ng2-alfresco-datatable';
import { Observable, Subject } from 'rxjs/Rx';
import { FileNode, FolderNode } from '../assets/document-library.model.mock';
@@ -31,7 +31,7 @@ import {
import { MaterialModule } from '../material.module';
import { ContentActionModel } from '../models/content-action.model';
import { NodeMinimal, NodeMinimalEntry, NodePaging } from '../models/document-library.model';
import { ImageResolver, RowFilter, ShareDataRow } from './../data/share-datatable-adapter';
import { ImageResolver, RowFilter } from './../data/share-datatable-adapter';
import { DocumentListService } from './../services/document-list.service';
import { DocumentListComponent } from './document-list.component';
import { DocumentMenuActionComponent } from './document-menu-action.component';
@@ -747,7 +747,6 @@ describe('DocumentList', () => {
it('should emit [nodeClick] event on row click', () => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
spyOn(documentList, 'onNodeClick').and.callThrough();
documentList.onNodeClick(node);
@@ -756,7 +755,6 @@ describe('DocumentList', () => {
it('should emit node-click DOM event', (done) => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
const htmlElement = fixture.debugElement.nativeElement as HTMLElement;
htmlElement.addEventListener('node-click', (e: CustomEvent) => {
@@ -768,7 +766,6 @@ describe('DocumentList', () => {
it('should emit [nodeDblClick] event on row double-click', () => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
spyOn(documentList, 'onNodeDblClick').and.callThrough();
documentList.onNodeDblClick(node);
@@ -777,7 +774,6 @@ describe('DocumentList', () => {
it('should emit node-dblclick DOM event', (done) => {
let node = new NodeMinimalEntry();
let row = new ShareDataRow(node, null, null);
const htmlElement = fixture.debugElement.nativeElement as HTMLElement;
htmlElement.addEventListener('node-dblclick', (e: CustomEvent) => {

2
ng2-components/ng2-alfresco-documentlist/src/components/document-list.component.ts
View File

@@ -21,7 +21,7 @@ import {
} from '@angular/core';
import { MinimalNodeEntity, MinimalNodeEntryEntity, NodePaging, Pagination } from 'alfresco-js-api';
import { AlfrescoTranslationService, DataColumnListComponent } from 'ng2-alfresco-core';
import { DataCellEvent, DataColumn, DataRow, DataRowActionEvent, DataRowEvent, DataSorting, DataTableComponent, ObjectDataColumn } from 'ng2-alfresco-datatable';
import { DataCellEvent, DataColumn, DataRowActionEvent, DataSorting, DataTableComponent, ObjectDataColumn } from 'ng2-alfresco-datatable';
import { Observable, Subject } from 'rxjs/Rx';
import { ImageResolver, RowFilter, ShareDataRow, ShareDataTableAdapter } from './../data/share-datatable-adapter';
import { ContentActionModel } from './../models/content-action.model';

1
ng2-components/ng2-alfresco-documentlist/src/data/share-datatable-adapter.ts
View File

@@ -18,7 +18,6 @@
import { DatePipe } from '@angular/common';
import { MinimalNode, MinimalNodeEntity, NodePaging } from 'alfresco-js-api';
import { ObjectUtils } from 'ng2-alfresco-core';
import { PermissionsEnum } from 'ng2-alfresco-core';
import { DataColumn, DataRow, DataSorting, DataTableAdapter } from 'ng2-alfresco-datatable';
import { PermissionStyleModel } from './../models/permissions-style.model';
import { DocumentListService } from './../services/document-list.service';

2
ng2-components/ng2-alfresco-documentlist/src/services/document-actions.service.spec.ts
View File

@@ -15,8 +15,6 @@
* limitations under the License.
*/
import { MdDialog } from '@angular/material';
import { TranslateService } from '@ngx-translate/core';
import { AlfrescoContentService, AlfrescoTranslationService, NotificationService } from 'ng2-alfresco-core';
import { FileNode, FolderNode } from '../assets/document-library.model.mock';
import { DocumentListServiceMock } from '../assets/document-list.service.mock';

1
ng2-components/ng2-alfresco-documentlist/src/services/document-actions.service.ts
View File

@@ -20,7 +20,6 @@ import { MinimalNodeEntity } from 'alfresco-js-api';
import { AlfrescoContentService, AlfrescoTranslationService, NotificationService } from 'ng2-alfresco-core';
import { Observable } from 'rxjs/Observable';
import { Subject } from 'rxjs/Rx';
import { ContentNodeSelectorComponent } from '../components/content-node-selector/content-node-selector.component';
import { ContentActionHandler } from '../models/content-action.model';
import { PermissionModel } from '../models/permissions.model';
import { DocumentListService } from './document-list.service';

2
ng2-components/ng2-alfresco-documentlist/src/services/document-list.service.ts
View File

@@ -26,7 +26,7 @@ export class DocumentListService {
static ROOT_ID = '-root-';
constructor(private authService: AlfrescoAuthenticationService,
constructor(authService: AlfrescoAuthenticationService,
private contentService: AlfrescoContentService,
private apiService: AlfrescoApiService,
private logService: LogService,

1
ng2-components/ng2-alfresco-documentlist/src/services/node-actions.service.ts
View File

@@ -19,7 +19,6 @@ import { EventEmitter, Injectable } from '@angular/core';
import { MdDialog } from '@angular/material';
import { MinimalNodeEntryEntity } from 'alfresco-js-api';
import { AlfrescoContentService, AlfrescoTranslationService } from 'ng2-alfresco-core';
import { Observable } from 'rxjs/Observable';
import { Subject } from 'rxjs/Rx';
import { ContentNodeSelectorComponent } from '../components/content-node-selector/content-node-selector.component';
import { DocumentListService } from './document-list.service';

3
ng2-components/ng2-alfresco-documentlist/tsconfig.json
View File

@@ -43,7 +43,8 @@
"es2015",
"dom"
],
"suppressImplicitAnyIndexErrors": true
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
},
"exclude": [
"demo",